From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: dev@dpdk.org, Olivier MATZ <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] [RFC PATCH 4/5] kni: add support to get gso_size info
Date: Fri, 5 May 2017 12:43:02 +0100 [thread overview]
Message-ID: <0edddcf7-cffb-4f2e-7b9f-681e64cfca38@intel.com> (raw)
In-Reply-To: <1493810472-668-4-git-send-email-hemant.agrawal@nxp.com>
On 5/3/2017 12:21 PM, Hemant Agrawal wrote:
> Inform userspace about gso size info
>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
> lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h | 3 ++-
> lib/librte_eal/linuxapp/kni/kni_net.c | 1 +
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h b/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h
> index 2cd7d9a..91ebed3 100644
> --- a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h
> +++ b/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h
> @@ -125,7 +125,8 @@ struct rte_kni_mbuf {
> uint16_t nb_segs; /**< Number of segments. */
> char pad4[2];
> uint64_t ol_flags; /**< Offload features. */
> - char pad2[4];
> + uint16_t gso_size; /**< TCP Segmentation Offload Information. */
> + char pad2[2];
rte_kni_mbuf and rte_mbuf should be binary compatible. This is
packet_type field of the mbuf struct.
When DPDK application receives the mbuf, how it will know if this
gso_size or packet_type, unless it knows underlying port is KNI. Is it
possible to use udata64 field for this?
Who will use information and how it will be used, can you please provide
some sort of sample?
Thanks,
ferruh
> uint32_t pkt_len; /**< Total pkt len: sum of all segment data_len. */
> uint16_t data_len; /**< Amount of data in segment buffer. */
>
> diff --git a/lib/librte_eal/linuxapp/kni/kni_net.c b/lib/librte_eal/linuxapp/kni/kni_net.c
> index e4a3296..c7648d3 100644
> --- a/lib/librte_eal/linuxapp/kni/kni_net.c
> +++ b/lib/librte_eal/linuxapp/kni/kni_net.c
> @@ -252,6 +252,7 @@
> }
> pkt_kva->pkt_len = len;
> pkt_kva->data_len = len;
> + pkt_kva->gso_size = skb_shinfo(skb)->gso_size; /* passes gso_size from Kernel to GPP */
>
> /* enqueue mbuf into tx_q */
> ret = kni_fifo_put(kni->tx_q, &pkt_va, 1);
>
next prev parent reply other threads:[~2017-05-05 11:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-03 11:21 [dpdk-dev] [RFC PATCH 1/5] kni: change and configure mac address Hemant Agrawal
2017-05-03 11:21 ` [dpdk-dev] [RFC PATCH 2/5] kni: add support for promisc mode set Hemant Agrawal
2017-05-03 11:21 ` [dpdk-dev] [RFC PATCH 3/5] kni: init and change request for mtu Hemant Agrawal
2017-05-03 11:21 ` [dpdk-dev] [RFC PATCH 4/5] kni: add support to get gso_size info Hemant Agrawal
2017-05-03 13:57 ` Alejandro Lucero
2017-05-05 11:43 ` Ferruh Yigit [this message]
2017-05-03 11:21 ` [dpdk-dev] [RFC PATCH 5/5] kni: support multiple userspace process working with kni module Hemant Agrawal
2017-05-05 13:08 ` Ferruh Yigit
2017-05-08 9:50 ` Hemant Agrawal
2017-05-05 11:28 ` [dpdk-dev] [RFC PATCH 1/5] kni: change and configure mac address Ferruh Yigit
2017-05-08 9:59 ` Hemant Agrawal
2017-11-28 22:31 ` Ferruh Yigit
2017-11-30 6:44 ` Hemant Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0edddcf7-cffb-4f2e-7b9f-681e64cfca38@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).