From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Tiwei Bie <tiwei.bie@intel.com>, zhihong.wang@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 0/4] Some fixes for vhost zero copy
Date: Tue, 26 Feb 2019 15:46:41 +0100 [thread overview]
Message-ID: <0ee272f4-ab82-b1b9-2735-434c2d40d229@redhat.com> (raw)
In-Reply-To: <20190222024209.30879-1-tiwei.bie@intel.com>
On 2/22/19 3:42 AM, Tiwei Bie wrote:
> Tiwei Bie (4):
> vhost: restore mbuf first when freeing zmbuf
> vhost: fix potential use-after-free for zero copy mbuf
> vhost: fix potential use-after-free for memory region
> doc: improve vhost zero copy guide
>
> doc/guides/prog_guide/vhost_lib.rst | 3 +++
> lib/librte_vhost/vhost.h | 34 +++++++++++++++++++++++
> lib/librte_vhost/vhost_user.c | 42 ++++++++++++++++++++++-------
> lib/librte_vhost/virtio_net.c | 34 -----------------------
> 4 files changed, 70 insertions(+), 43 deletions(-)
>
Looking at the spec, I think we may need also to drain zmbufs in the
VHOST_USER_SET_VRING_ENABLE for the disable case:
""
If VHOST_USER_F_PROTOCOL_FEATURES has been negotiated, the ring is
initialized
in a disabled state. Client must not pass data to/from the backend until
ring is enabled by
VHOST_USER_SET_VRING_ENABLE with parameter 1, or after it has been
disabled by
VHOST_USER_SET_VRING_ENABLE with parameter 0.
Each ring is initialized in a stopped state, client must not process it
until
ring is started, or *after it has been stopped*.
""
Do you take care of this or I send a patch on top?
Thanks,
Maxime
next prev parent reply other threads:[~2019-02-26 14:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 2:42 Tiwei Bie
2019-02-22 2:42 ` [dpdk-dev] [PATCH 1/4] vhost: restore mbuf first when freeing zmbuf Tiwei Bie
2019-02-26 14:41 ` Maxime Coquelin
2019-02-22 2:42 ` [dpdk-dev] [PATCH 2/4] vhost: fix potential use-after-free for zero copy mbuf Tiwei Bie
2019-02-26 14:42 ` Maxime Coquelin
2019-02-22 2:42 ` [dpdk-dev] [PATCH 3/4] vhost: fix potential use-after-free for memory region Tiwei Bie
2019-02-26 14:42 ` Maxime Coquelin
2019-02-22 2:42 ` [dpdk-dev] [PATCH 4/4] doc: improve vhost zero copy guide Tiwei Bie
2019-02-26 14:44 ` Maxime Coquelin
2019-02-26 14:46 ` Maxime Coquelin [this message]
2019-02-27 1:52 ` [dpdk-dev] [PATCH 0/4] Some fixes for vhost zero copy Tiwei Bie
2019-02-27 8:32 ` Maxime Coquelin
2019-02-27 8:31 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ee272f4-ab82-b1b9-2735-434c2d40d229@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).