From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ravi Kerur <rkerur@gmail.com>
Cc: dpdk-dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v8 2/6] Move common functions in eal.c
Date: Tue, 18 Dec 2018 01:42:58 +0000 [thread overview]
Message-ID: <0eec6652-a608-3616-e428-918ca3e817b6@intel.com> (raw)
In-Reply-To: <1430264809-32599-2-git-send-email-rkerur@gmail.com>
On 4/29/2015 12:46 AM, rkerur at gmail.com (Ravi Kerur) wrote:
> Changes in v8
> Fix ABI warnings by reordering compilation of
> eal_common_sysfs.c
> eal_common_mem_cfg.c
> eal_common_proc_type.c
> eal_common_app_usage.c
>
> Changes in v7
> Fix compilation errors in clang.
>
> Changes in v6
> Split eal_common_system.c and eal_common_runtime.c into
> eal_common_sysfs.c
> eal_common_mem_cfg.c
> eal_common_proc_type.c
> eal_common_app_usage.c
> based on functionality.
>
> Changes in v5
> Rebase to latest code.
>
> Changes in v4
> Remove eal_externs.h file, instead use _get_ and _set_ APIS
> to access those variables.
> Split eal_common.c into eal_common_system.c and
> and eal_common_runtime.c
> rte_eal prefix functions are moved to _runtime_ and
> eal prefix functions are moved to _system_ files respectively.
>
> Changes in v3
> Changed subject to be more explicit on file name inclusion.
>
> Changes in v2
> In function rte_eal_config_create remove #ifdef _BSDAPP_
> and initialize mem_cfg_addr unconditionally.
>
> Changes in v1
> Move common functions in eal.c to librte_eal/common/eal_common.c.
>
> Following functions are moved to eal_common.c file.
>
> struct rte_config *rte_eal_get_configuration(void);
> int eal_parse_sysfs_value(const char *filename, unsigned long *val);
> static void rte_eal_config_create(void);
> enum rte_proc_type_t eal_proc_type_detect(void);
> void rte_eal_config_init(void);
> rte_usage_hook_t rte_set_application_usage_hook(rte_usage_hook_t
> usage_func);
> inline size_t eal_get_hugepage_mem_size(void);
> void eal_check_mem_on_local_socket(void);
> int sync_func(__attribute__((unused)) void *arg);
> inline void rte_eal_mcfg_complete(void);
> int rte_eal_has_hugepages(void);
> enum rte_lcore_role_t rte_eal_lcore_role(unsigned lcore_id);
> enum rte_proc_type_t rte_eal_process_type(void);
>
> Makefile changes to reflect new files added.
> Fix checkpatch warnings and errors.
>
> Signed-off-by: Ravi Kerur <rkerur at gmail.com>
Hi Ravi,
This patch is sitting on patchwork since 2015, I am updating it as rejected, if
it is still relevant please let us know.
Sorry for any inconvenience caused.
next prev parent reply other threads:[~2018-12-18 1:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 23:46 [dpdk-dev] [PATCH v8 0/6] Move common functions in EAL Ravi Kerur
2015-04-28 23:46 ` [dpdk-dev] [PATCH v8 1/6] Move common functions in eal_thread.c Ravi Kerur
2015-04-28 23:46 ` [dpdk-dev] [PATCH v8 2/6] Move common functions in eal.c Ravi Kerur
2018-12-18 1:42 ` Ferruh Yigit [this message]
2018-12-18 1:43 ` Ferruh Yigit
2015-04-28 23:46 ` [dpdk-dev] [PATCH v8 3/6] Move common functions in eal_lcore.c Ravi Kerur
2015-04-28 23:46 ` [dpdk-dev] [PATCH v8 4/6] Move common functions in eal_timer.c Ravi Kerur
2015-04-28 23:46 ` [dpdk-dev] [PATCH v8 5/6] Move common functions in eal_memory.c Ravi Kerur
2015-04-28 23:46 ` [dpdk-dev] [PATCH v8 6/6] Move common functions in eal_pci.c Ravi Kerur
2018-12-18 1:47 ` Ferruh Yigit
2015-04-29 10:14 ` [dpdk-dev] [PATCH v8 0/6] Move common functions in EAL Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0eec6652-a608-3616-e428-918ca3e817b6@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=rkerur@gmail.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).