From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Junjie Chen <junjie.j.chen@intel.com>,
jianfen.tan@intel.com, yliu@fridaylinux.org
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] vhost: dequeue zero copy should restore mbuf before return to pool
Date: Thu, 18 Jan 2018 09:44:41 +0100 [thread overview]
Message-ID: <0f5ea2ca-5684-8c12-a123-dacab2b071d5@redhat.com> (raw)
In-Reply-To: <1516203953-152604-1-git-send-email-junjie.j.chen@intel.com>
On 01/17/2018 04:45 PM, Junjie Chen wrote:
> dequeue zero copy change buf_addr and buf_iova of mbuf, and return
> to mbuf pool without restore them, it breaks vm memory if others allocate
> mbuf from same pool since mbuf reset doesn't reset buf_addr and buf_iova.
>
> Signed-off-by: Junjie Chen <junjie.j.chen@intel.com>
> ---
> v2 changes:
> Remove useless restore
> lib/librte_vhost/virtio_net.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2018-01-18 8:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 10:42 [dpdk-dev] [PATCH] " Junjie Chen
2018-01-17 7:29 ` Tan, Jianfeng
2018-01-17 8:10 ` Chen, Junjie J
2018-01-17 15:45 ` [dpdk-dev] [PATCH v2] " Junjie Chen
2018-01-18 8:44 ` Maxime Coquelin [this message]
2018-01-18 13:16 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f5ea2ca-5684-8c12-a123-dacab2b071d5@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=jianfen.tan@intel.com \
--cc=junjie.j.chen@intel.com \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).