From: Omer Yamac <omer.yamac@ceng.metu.edu.tr>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, ferruh.yigit@amd.com
Subject: Re: [PATCH] drivers: suggestion on removing empty version.map files
Date: Tue, 04 Oct 2022 09:30:39 +0300 [thread overview]
Message-ID: <0f7fe73d49f820e4a1a1d56f9b535bfc@ceng.metu.edu.tr> (raw)
In-Reply-To: <YzrrS6RGL+Ia/ltV@bricha3-MOBL.ger.corp.intel.com>
On 03.10.2022 17:01, Bruce Richardson wrote:
> On Mon, Oct 03, 2022 at 04:59:18PM +0300, Omer Yamac wrote:
>>
>>
>> On 03.10.2022 12:19, Bruce Richardson wrote:
>> > On Mon, Oct 03, 2022 at 09:52:03AM +0300, Abdullah Ömer Yamaç wrote:
>> > > In this patch, we remove all version.map files which include
>> > > only the below part:
>> > > `DPDK_23 {
>> > > local: *;
>> > > };`
>> > >
>> > > Then we modify the meson.build to be able to compile without
>> > > version.map
>> > >
>> > > Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
>> > > Suggested-by: Ferruh Yigit <ferruh.yigit@amd.com>
>> > > ---
>> >
>> > I think you need to flag this as depending on us bumping the meson
>> > version
>> > requirement up to 0.53 as has been proposed. This doesn't work with 0.4x
>> > versions.
>> >
>> Thanks for your warnings.
>> Instead of using fs module, I will use python script that checks file
>> exist
>> or not.
>> If it is okay, I will resubmit the patch.
>
> I'd rather not go down that road unless we really need to. Right now
> the
> empty version.map files are pretty much harmless, so there is no
> compelling
> need to change. Therefore, I'd rather wait to have the meson version
> bumped
> to 0.53 and then have this patch applied, without having to worry about
> using script fallbacks.
I understood; but one thing I'm not sure what should I do? I don't know
how can I flag the meson requirement. Is there any special method or
just a comment in the commit?
>
> /Bruce
Thanks
next prev parent reply other threads:[~2022-10-04 6:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-03 6:52 Abdullah Ömer Yamaç
2022-10-03 9:19 ` Bruce Richardson
2022-10-03 13:59 ` Omer Yamac
2022-10-03 14:01 ` Bruce Richardson
2022-10-04 6:30 ` Omer Yamac [this message]
2022-10-04 8:07 ` Bruce Richardson
2022-10-06 7:19 ` [PATCH 1/2] drivers: suggestion on meson without version file Abdullah Ömer Yamaç
2022-10-06 7:19 ` [PATCH 2/2] drivers: remove the unnecessary version.map Abdullah Ömer Yamaç
2022-10-07 10:30 ` [PATCH 1/2] drivers: suggestion on meson without version file Bruce Richardson
2022-10-10 7:41 ` Omer Yamac
2022-10-10 8:34 ` Bruce Richardson
2022-10-11 11:08 ` [PATCH v2 1/2] build: make version file optional for drivers Abdullah Ömer Yamaç
2022-10-11 11:08 ` [PATCH v2 2/2] drivers: remove the unnecessary version.map Abdullah Ömer Yamaç
2022-10-11 13:10 ` David Marchand
2022-10-11 19:21 ` Omer Yamac
2022-10-12 10:29 ` [PATCH v3 1/2] build: make version file optional for drivers Abdullah Ömer Yamaç
2022-10-12 10:29 ` [PATCH v3 2/2] " Abdullah Ömer Yamaç
2022-10-12 10:42 ` [PATCH v4 1/2] " Abdullah Ömer Yamaç
2022-10-12 10:42 ` [PATCH v4 2/2] drivers: remove the unnecessary Abdullah Ömer Yamaç
2022-10-12 11:32 ` [PATCH v4 1/2] build: make version file optional for drivers Ferruh Yigit
2022-11-14 14:19 ` David Marchand
2022-10-11 12:00 ` [PATCH v2 " Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f7fe73d49f820e4a1a1d56f9b535bfc@ceng.metu.edu.tr \
--to=omer.yamac@ceng.metu.edu.tr \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).