From: fengchengwen <fengchengwen@huawei.com>
To: "Ferruh Yigit" <ferruh.yigit@amd.com>,
"Jerin Jacob" <jerinj@marvell.com>,
"Morten Brørup" <mb@smartsharesystems.com>
Cc: <dev@dpdk.org>, <stable@dpdk.org>
Subject: Re: [PATCH v2 4/8] eventdev: fix calloc parameters
Date: Thu, 25 Jan 2024 10:34:50 +0800 [thread overview]
Message-ID: <0ff05849-6759-5cdc-447d-3c4a78a56790@huawei.com> (raw)
In-Reply-To: <20240124185406.3598985-4-ferruh.yigit@amd.com>
Reviewed-by: Chengwen Feng <fengchengwen@huawei.com>
Thanks
On 2024/1/25 2:54, Ferruh Yigit wrote:
> gcc [1] generates warning [2] about calloc usage, because calloc
> parameter order is wrong, fixing it by replacing parameters.
>
> [1]
> gcc (GCC) 14.0.1 20240124 (experimental)
>
> [2]
> Compiling C object lib/librte_eventdev.a.p/eventdev_rte_eventdev.c.o
> ../lib/eventdev/rte_eventdev.c: In function ‘handle_dev_dump’:
> ../lib/eventdev/rte_eventdev.c:2005:29:
> warning: ‘calloc’ sizes specified with ‘sizeof’ in the earlier
> argument and not in the later argument [-Wcalloc-transposed-args]
> 2005 | buf = calloc(sizeof(char), RTE_TEL_MAX_SINGLE_STRING_LEN);
> | ^~~~
>
> Fixes: a3b7b476d723 ("eventdev: support telemetry dump eventdev")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com>
> ---
> Cc: fengchengwen@huawei.com
> ---
> lib/eventdev/rte_eventdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/eventdev/rte_eventdev.c b/lib/eventdev/rte_eventdev.c
> index 157752868d5b..1c865e993fec 100644
> --- a/lib/eventdev/rte_eventdev.c
> +++ b/lib/eventdev/rte_eventdev.c
> @@ -2002,7 +2002,7 @@ handle_dev_dump(const char *cmd __rte_unused,
>
> RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL);
>
> - buf = calloc(sizeof(char), RTE_TEL_MAX_SINGLE_STRING_LEN);
> + buf = calloc(RTE_TEL_MAX_SINGLE_STRING_LEN, sizeof(char));
> if (buf == NULL)
> return -ENOMEM;
>
>
next prev parent reply other threads:[~2024-01-25 2:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 13:08 [PATCH 1/2] pipeline: " Ferruh Yigit
2023-11-02 13:08 ` [PATCH 2/2] net/nfp: " Ferruh Yigit
2023-11-03 1:26 ` Chaoyong He
2023-11-06 14:26 ` [PATCH 1/2] pipeline: " Dumitrescu, Cristian
2024-01-24 18:53 ` [PATCH v2 1/8] " Ferruh Yigit
2024-01-24 18:53 ` [PATCH v2 2/8] net/nfp: " Ferruh Yigit
2024-01-24 19:01 ` Morten Brørup
2024-01-24 18:54 ` [PATCH v2 3/8] rawdev: " Ferruh Yigit
2024-01-24 18:59 ` Morten Brørup
2024-01-25 2:34 ` fengchengwen
2024-01-25 3:39 ` Hemant Agrawal
2024-01-24 18:54 ` [PATCH v2 4/8] eventdev: " Ferruh Yigit
2024-01-24 18:59 ` Morten Brørup
2024-01-25 2:34 ` fengchengwen [this message]
2024-01-24 18:54 ` [PATCH v2 5/8] dmadev: " Ferruh Yigit
2024-01-24 18:59 ` Morten Brørup
2024-01-25 2:35 ` fengchengwen
2024-01-24 18:54 ` [PATCH v2 6/8] common/mlx5: " Ferruh Yigit
2024-01-24 19:01 ` Morten Brørup
2024-01-26 10:12 ` Dariusz Sosnowski
2024-01-24 18:54 ` [PATCH v2 7/8] net/bnx2x: " Ferruh Yigit
2024-01-24 19:01 ` Morten Brørup
2024-01-24 18:54 ` [PATCH v2 8/8] net/sfc: " Ferruh Yigit
2024-01-24 19:02 ` Morten Brørup
2024-01-25 7:10 ` Andrew Rybchenko
2024-01-24 19:00 ` [PATCH v2 1/8] pipeline: " Morten Brørup
2024-02-18 16:08 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ff05849-6759-5cdc-447d-3c4a78a56790@huawei.com \
--to=fengchengwen@huawei.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=jerinj@marvell.com \
--cc=mb@smartsharesystems.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).