DPDK patches and discussions
 help / color / mirror / Atom feed

From: longtb5@viettel.com.vn
To: reshma pattan <reshma.pattan@intel.com>
Cc: Konstantin Ananyev <konstantin.ananyev@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] latencystats: fix timestamp marking and latency calculation
Date: Tue, 25 Sep 2018 22:22:37 +0700 (ICT)	[thread overview]
Message-ID: <1015925804.3544038.1537888956319.JavaMail.zimbra@viettel.com.vn> (raw)
In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A39E20E@IRSMSX109.ger.corp.intel.com>

Hi Reshma,

I mean in the latencystats document. A few lines about what is taken away
by the library (the mbuf timestamp when PKT_RX_TIMESTAMP is set) would be
very helpful.

Best regards,
BL

----- Original Message -----
From: "reshma pattan" <reshma.pattan@intel.com>
To: longtb5@viettel.com.vn
Cc: "Konstantin Ananyev" <konstantin.ananyev@intel.com>, dev@dpdk.org
Sent: Monday, September 24, 2018 8:07:18 PM
Subject: RE: [PATCH] latencystats: fix timestamp marking and latency calculation

Hi,

> -----Original Message-----
> From: longtb5@viettel.com.vn [mailto:longtb5@viettel.com.vn]
> Sent: Saturday, September 22, 2018 3:58 AM
> To: Pattan, Reshma <reshma.pattan@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; dev@dpdk.org
> Subject: RE: [PATCH] latencystats: fix timestamp marking and latency
> calculation
> 
> Hi Reshma,
> 
> > -----Original Message-----
> > From: reshma.pattan@intel.com [mailto:reshma.pattan@intel.com]
> > Sent: Friday, September 21, 2018 11:02 PM
> > To: longtb5@viettel.com.vn; konstantin.ananyev@intel.com;
> dev@dpdk.org
> > Cc: Reshma Pattan <reshma.pattan@intel.com>
> > Subject: [PATCH] latencystats: fix timestamp marking and latency
> calculation
> >
> > Latency calculation logic is not correct for the case where packets
> > gets dropped before TX. As for the dropped packets, the timestamp is
> > not cleared, and such packets still gets counted for latency
> > calculation in
> next
> > runs, that will result in inaccurate latency measurement.
> >
> > So fix this issue as below,
> >
> > Before setting timestamp in mbuf, check mbuf don't have any prior
> > valid time stamp flag set and after marking the timestamp, set mbuf
> > flags to indicate timestamp is valid.
> >
> > Before calculating timestamp check mbuf flags are set to indicate
> timestamp
> > is valid.
> >
> 
> This solution as suggested by Konstantin is great. Not only does it solve the
> problem but also now the usage of mbuf->timestamp is not exclusive to
> latencystats anymore. The application can make use of timestamp at the
> same as latencystats simply by toggling PKT_RX_TIMESTAMP. I think we
> should update the doc to include this information.
> 

Do you mean latency stats document? Or Mbuf doc.  

Thanks,
Reshma

next prev parent reply	other threads:[~2018-09-25 15:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-21 16:01 Reshma Pattan
2018-09-22  2:58 ` longtb5
2018-09-24 13:07   ` Pattan, Reshma
2018-09-25 15:22     ` longtb5 [this message]
2018-09-24  7:10 ` longtb5
2018-09-25 12:24 ` [dpdk-dev] [PATCH v2] " Reshma Pattan
2018-09-25 14:30   ` Ananyev, Konstantin
2018-09-25 14:51 ` [dpdk-dev] [PATCH v3] " Reshma Pattan
2018-10-25  8:31   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1015925804.3544038.1537888956319.JavaMail.zimbra@viettel.com.vn \
    --to=longtb5@viettel.com.vn \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=reshma.pattan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).