From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@amd.com>
Cc: "Bruce Richardson" <bruce.richardson@intel.com>,
"Morten Brørup" <mb@smartsharesystems.com>,
dev@dpdk.org, "David Marchand" <david.marchand@redhat.com>,
"Tyler Retzlaff" <roretzla@linux.microsoft.com>
Subject: Re: [PATCH v2] devtools: allow variable declaration inside for loop
Date: Thu, 20 Jul 2023 06:05:12 +0200 [thread overview]
Message-ID: <10350121.ag9G3TJQzC@thomas> (raw)
In-Reply-To: <20230503150613.GA7537@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
> > > > > Declaring variable inside for loop is not supported via C89 and it was
> > > > > checked in checkpatch.sh via commit [1].
> > > > > But as DPDK supported C standard is becoming C99/C11 [2], declaring
> > > > > variable inside loop can be allowed.
> > > > >
> > > > > [1]
> > > > > Commit 43e73483a4b8 ("devtools: forbid variable declaration inside
> > > > for")
> > > > >
> > > > > [2]
> > > > > https://dpdk.org/patch/121912
> > > > >
> > > > > Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com>
> > > > > ---
> > > > > Cc: Bruce Richardson <bruce.richardson@intel.com>
> > > > > Cc: David Marchand <david.marchand@redhat.com>
> > > > >
> > > > > v2:
> > > > > * Update coding convention too
> > > > > ---
> > > >
> > > > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> > >
> > > Acked-by: Morten Brørup <mb@smartsharesystems.com>
>
> Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Applied, thanks.
prev parent reply other threads:[~2023-07-20 4:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 9:50 [PATCH v1] " Ferruh Yigit
2023-05-03 10:02 ` Bruce Richardson
2023-05-03 10:23 ` Ferruh Yigit
2023-05-03 10:30 ` [PATCH v2] " Ferruh Yigit
2023-05-03 10:57 ` Bruce Richardson
2023-05-03 12:19 ` Morten Brørup
2023-05-03 15:01 ` Thomas Monjalon
2023-05-03 15:06 ` Tyler Retzlaff
2023-07-20 4:05 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10350121.ag9G3TJQzC@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=mb@smartsharesystems.com \
--cc=roretzla@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).