From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org,
Jianfeng Tan <jianfeng.tan@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Shijith Thotton <shijith.thotton@caviumnetworks.com>,
Gregory Etelson <gregory@weka.io>,
Harish Patil <harish.patil@cavium.com>,
George Prekas <george.prekas@epfl.ch>,
Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>,
Rasesh Mody <rasesh.mody@cavium.com>,
Lee Roberts <lee.roberts@hpe.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Chas Williams <chas3@att.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] igb_uio: remove device reset in release
Date: Wed, 08 Nov 2017 00:57:17 +0100 [thread overview]
Message-ID: <10440492.mlt1TGbLnU@xps> (raw)
In-Reply-To: <20171107222913.65295-1-ferruh.yigit@intel.com>
07/11/2017 23:29, Ferruh Yigit:
> More error reported for device reset in release() [1],
> when device pass-through to the guest, host kernel crash on guest exit.
>
> Removing the reset completely.
>
> This is close to reverting commit b58eedfc7dd5 [2], taking into account
> previous fix to remove reset in open as well [3], but not exactly same.
>
> With latest code, interrupts are enabled in uio open() callback and
> disabled in uio release() callback, so when a DPDK application exit
> device interrupts are disabled. Previously interrupts were only enabled
> once in igb_uio module insert and disabled in module removal.
>
> Also with latest code device set as bus master in open() and master
> cleared in release(), clearing bus master should prevent further DMA
> which was one of the target of the initial patch.
>
> The initial intention was also to reset the device to be sure it has
> been left in proper state, but currently that part is missing because of
> reported problem(s).
>
> Still igb_uio should be safer comparing to the pre b58eedfc7dd5 state.
>
> [1]
> http://dpdk.org/ml/archives/dev/2017-November/081459.html
>
> [2]
> b58eedfc7dd5 ("igb_uio: issue FLR during open and release of device file")
>
> [3]
> f73b38e9245d ("igb_uio: remove device reset in open")
>
> Fixes: e3a64deae2d5 ("igb_uio: prevent reset for bnx2x devices")
> Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of device file")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
We can say you tried hard to make igb_uio cleaner and safer :)
Applied, thanks for the detailed explanations.
next prev parent reply other threads:[~2017-11-07 23:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 19:32 [dpdk-stable] [PATCH] " Ferruh Yigit
2017-11-07 22:29 ` [dpdk-stable] [PATCH v2] " Ferruh Yigit
2017-11-07 23:57 ` Thomas Monjalon [this message]
2017-11-08 5:23 ` [dpdk-stable] [dpdk-dev] " Wu, Jingjing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10440492.mlt1TGbLnU@xps \
--to=thomas@monjalon.net \
--cc=chas3@att.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=george.prekas@epfl.ch \
--cc=gregory@weka.io \
--cc=harish.patil@cavium.com \
--cc=jianfeng.tan@intel.com \
--cc=jingjing.wu@intel.com \
--cc=lee.roberts@hpe.com \
--cc=rasesh.mody@cavium.com \
--cc=sergio.gonzalez.monroy@intel.com \
--cc=shijith.thotton@caviumnetworks.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).