From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Piotr Azarewicz <piotrx.t.azarewicz@intel.com>
Cc: dev@dpdk.org, pablo.de.lara.guarch@intel.com
Subject: Re: [dpdk-dev] [PATCH v3] crypto/aesni_gcm: migration from MB library to ISA-L
Date: Tue, 03 Jan 2017 15:14:46 +0100 [thread overview]
Message-ID: <10528878.kOcN2Qlpj0@xps13> (raw)
In-Reply-To: <1483448523-150510-1-git-send-email-piotrx.t.azarewicz@intel.com>
2017-01-03 14:02, Piotr Azarewicz:
> Current Cryptodev AES-NI GCM PMD is implemented using Multi Buffer
> Crypto library.This patch reimplement the device using ISA-L Crypto
> library: https://github.com/01org/isa-l_crypto.
>
> The migration entailed the following additional support for:
> * GMAC algorithm.
> * 256-bit cipher key.
> * Session-less mode.
> * Out-of place processing
> * Scatter-gatter support for chained mbufs (only out-of place and
> destination mbuf must be contiguous)
>
> Verified current unit tests and added new unit tests to verify new
> functionalities.
>
> Signed-off-by: Piotr Azarewicz <piotrx.t.azarewicz@intel.com>
[...]
> The AES-NI GCM PMD (**librte_pmd_aesni_gcm**) provides poll mode crypto driver
> -support for utilizing Intel multi buffer library (see AES-NI Multi-buffer PMD documentation
> -to learn more about it, including installation).
> -
> -The AES-NI GCM PMD has current only been tested on Fedora 21 64-bit with gcc.
> +support for utilizing Intel ISA-L crypto library, which provides operation acceleration
> +through the AES-NI instruction sets for AES-GCM authenticated cipher algorithm.
Please could you compare these libraries regarding the performance?
[...]
> Features
> --------
> @@ -49,16 +47,21 @@ Cipher algorithms:
> Authentication algorithms:
>
> * RTE_CRYPTO_AUTH_AES_GCM
> +* RTE_CRYPTO_AUTH_AES_GMAC
> +
> +Installation
> +------------
> +
> +To build DPDK with the AESNI_GCM_PMD the user is required to install
> +the ``libisal_crypto`` library in the build environment.
> +For download and more details please visit `<https://github.com/01org/isa-l_crypto>`_.
[...]
> Limitations
> -----------
>
> -* Chained mbufs are not supported.
> +* Chained mbufs are supported but only out-of-place (destination mbuf must be contiguous).
> * Hash only is not supported.
> * Cipher only is not supported.
> -* Only in-place is currently supported (destination address is the same as source address).
> -* Only supports session-oriented API implementation (session-less APIs are not supported).
> * Not performance tuned.
[...]
> --- a/drivers/crypto/aesni_gcm/Makefile
> +++ b/drivers/crypto/aesni_gcm/Makefile
> @@ -31,9 +31,6 @@
> include $(RTE_SDK)/mk/rte.vars.mk
>
> ifneq ($(MAKECMDGOALS),clean)
> -ifeq ($(AESNI_MULTI_BUFFER_LIB_PATH),)
> -$(error "Please define AESNI_MULTI_BUFFER_LIB_PATH environment variable")
> -endif
> endif
>
> # library name
> @@ -50,10 +47,7 @@ LIBABIVER := 1
> EXPORT_MAP := rte_pmd_aesni_gcm_version.map
>
> # external library dependencies
> -CFLAGS += -I$(AESNI_MULTI_BUFFER_LIB_PATH)
> -CFLAGS += -I$(AESNI_MULTI_BUFFER_LIB_PATH)/include
> -LDLIBS += -L$(AESNI_MULTI_BUFFER_LIB_PATH) -lIPSec_MB
> -LDLIBS += -lcrypto
> +LDLIBS += -lisal_crypto
You need to update the script test-build.sh.
Thanks
next prev parent reply other threads:[~2017-01-03 14:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-27 18:53 [dpdk-dev] [PATCH v2] " Michal Jastrzebski
2017-01-03 13:02 ` [dpdk-dev] [PATCH v3] " Piotr Azarewicz
2017-01-03 14:14 ` Thomas Monjalon [this message]
2017-01-05 13:51 ` [dpdk-dev] [PATCH v4] " Piotr Azarewicz
2017-01-05 15:12 ` Thomas Monjalon
2017-01-16 12:37 ` [dpdk-dev] [PATCH v5] " Piotr Azarewicz
2017-01-16 14:42 ` Thomas Monjalon
2017-01-16 15:20 ` Mcnamara, John
2017-01-16 14:43 ` Thomas Monjalon
2017-01-17 7:42 ` Azarewicz, PiotrX T
2017-01-16 16:05 ` Declan Doherty
2017-01-17 11:19 ` [dpdk-dev] [PATCH v6 0/2] " Piotr Azarewicz
2017-01-17 11:19 ` [dpdk-dev] [PATCH v6 1/2] " Piotr Azarewicz
2017-01-17 11:19 ` [dpdk-dev] [PATCH v6 2/2] app/test: add GCM additional tests Piotr Azarewicz
2017-01-18 12:37 ` [dpdk-dev] [PATCH v6 0/2] crypto/aesni_gcm: migration from MB library to ISA-L De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10528878.kOcN2Qlpj0@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=piotrx.t.azarewicz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).