From: "Wiles, Keith" <keith.wiles@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v4] net/tap: fix coverity warning on strncpy
Date: Fri, 17 Feb 2017 16:53:51 +0000 [thread overview]
Message-ID: <10785464-6EE2-460C-9B69-687B4F30609C@intel.com> (raw)
In-Reply-To: <a054a505-5d49-1b74-bfcf-feb4e8dfcb6d@intel.com>
> On Feb 17, 2017, at 10:48 AM, Yigit, Ferruh <ferruh.yigit@intel.com> wrote:
>
> On 2/17/2017 4:34 PM, Wiles, Keith wrote:
>>
>>> On Feb 17, 2017, at 10:21 AM, Yigit, Ferruh <ferruh.yigit@intel.com> wrote:
>>>
>>> On 2/17/2017 3:43 PM, Keith Wiles wrote:
>>>> Calling strncpy with a maximum size argument of 16 bytes on destination
>>>> array "ifr.ifr_ifrn.ifrn_name" of size 16 bytes might leave the
>>>> destination string unterminated.
>>>>
>>>> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
>>>
>>> net/tap: fix possibly unterminated string
>>>
>>> Coverity issue: 1407499
>>> Fixes: 6b38b2725cdb ("net/tap: fix multi-queue support")
>>> Cc: stable@dpdk.org
>>>
>>> Applied to dpdk-next-net/master, thanks.
>>>
>>>
>>> (Updates:
>>> - patch title:
>>> It is preferred to mention from problem solved instead of the tool that
>>> found it.
>>>
>>> - Added coverity tag:
>>> This helps to trace coverity issues, defined syntax is:
>>>
>>> Coverity issue: xxx
>>> Fixes: yyyy
>>>
>>> - Added Cc: tag for stable tree:
>>> In case stable tree wants get this patch, to make patch visible.
>>
>> I agree this is good, but to many rules not listed or checked in the tools. We need a much easier method to submit patches in the format that is defined and checked.
>>
>> Today it is way to hard to know every little internal format for every type of patch. We need to fix this problem to make it easier to submit patches to dpdk.org, we can not continue like this as we grow it will become way to much work for the repo maintainers and the submitter.
>
> That is why I am documenting what has been changed and the reasoning in
> the mail, so I am hoping this is helping others that following the mail
> list sync about rules. Also gives a discussion medium about rules..
Great, but we need to document this on the web site not in email. We can not expect someone (or a new person) to read millions of emails to find these hidden gems, right?
>
>>
>> Using a better tool then submitting via email seems like a better solution as long as we can add the given checks to the tool. Using a tools should also reduce the email traffic for most everyone, but we need to allow anyone to ask for all of the commits to the repo or pull requests like patches.
>>
>> How can we handle these types of issues in the future?
>>
>>> )
>>
>> Regards,
>> Keith
Regards,
Keith
prev parent reply other threads:[~2017-02-17 16:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170217154304.50214-1-keith.wiles@intel.com>
2017-02-17 16:21 ` Ferruh Yigit
2017-02-17 16:34 ` Wiles, Keith
2017-02-17 16:48 ` Ferruh Yigit
2017-02-17 16:53 ` Wiles, Keith [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10785464-6EE2-460C-9B69-687B4F30609C@intel.com \
--to=keith.wiles@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).