From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Dai, Wei" <wei.dai@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Zhang, Helin" <helin.zhang@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Subject: Re: [dpdk-dev] [PATCH 2/7] net/ixgbe/base: remove a compiler warning
Date: Thu, 12 Jan 2017 14:24:24 +0000 [thread overview]
Message-ID: <109611bd-cd54-2e65-fa5e-40455e5aaa99@intel.com> (raw)
In-Reply-To: <49759EB36A64CF4892C1AFEC9231E8D63A3275EF@PGSMSX106.gar.corp.intel.com>
On 1/12/2017 2:08 PM, Dai, Wei wrote:
>> -----Original Message-----
>> From: Yigit, Ferruh
>> Sent: Wednesday, January 11, 2017 11:38 PM
>> To: Dai, Wei <wei.dai@intel.com>; dev@dpdk.org
>> Cc: Zhang, Helin <helin.zhang@intel.com>; Ananyev, Konstantin
>> <konstantin.ananyev@intel.com>
>> Subject: Re: [dpdk-dev] [PATCH 2/7] net/ixgbe/base: remove a compiler warning
>>
>> On 1/10/2017 3:45 PM, Wei Dai wrote:
>>> This patch fixes a compiler warning.
>>
>> I guess compiler warning is because of "mac->led_link_act = i;", since
>> led_link_act is 8bits..
>>
>> But can you please add the compile warning here, to make it more clear to
>> understand what is the issue.
>
> I have compared the generated ixgbe_common.o both from "u16 i" and "u8 I" .
> Two .o files are identical.
> Whether the variable i is defined as u8 or u16, there is no compile warning.
> The version of gcc version is 6.3.1 20161221 (Red Hat 6.3.1-1) (GCC).
> If i is u16, mac->led_link_act = i; should generate a warning, but there is no.
> It is a bit weird .
> As you know, this code is provided by another Intel team.
> I think that it will generate a warning when they build it with their C compiler.
> Anyway, to define i as u8 is better than u16 and we had better keep aligned with them.
Agreed, u8 is better.
>
>>
>>>
>>> Signed-off-by: Wei Dai <wei.dai@intel.com>
>>> ---
>>> drivers/net/ixgbe/base/ixgbe_common.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/ixgbe/base/ixgbe_common.c
>>> b/drivers/net/ixgbe/base/ixgbe_common.c
>>> index 18bb18c..0dd33b8 100644
>>> --- a/drivers/net/ixgbe/base/ixgbe_common.c
>>> +++ b/drivers/net/ixgbe/base/ixgbe_common.c
>>> @@ -1150,7 +1150,7 @@ s32 ixgbe_init_led_link_act_generic(struct
>>> ixgbe_hw *hw) {
>>> struct ixgbe_mac_info *mac = &hw->mac;
>>> u32 led_reg, led_mode;
>>> - u16 i;
>>> + u8 i;
>>>
>>> led_reg = IXGBE_READ_REG(hw, IXGBE_LEDCTL);
>>>
>>>
>
next prev parent reply other threads:[~2017-01-12 14:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 15:45 [dpdk-dev] [PATCH 0/7] update ixgbe shared code to version 2017-01-05 Wei Dai
2017-01-10 15:45 ` [dpdk-dev] [PATCH 1/7] net/ixgbe/base: support Broadwell-DE XFI backplane Wei Dai
2017-01-11 15:37 ` Ferruh Yigit
2017-01-12 13:17 ` Dai, Wei
2017-01-10 15:45 ` [dpdk-dev] [PATCH 2/7] net/ixgbe/base: remove a compiler warning Wei Dai
2017-01-11 15:38 ` Ferruh Yigit
2017-01-12 14:08 ` Dai, Wei
2017-01-12 14:24 ` Ferruh Yigit [this message]
2017-01-10 15:45 ` [dpdk-dev] [PATCH 3/7] net/ixgbe/base: configure speeds for KR/KX backplane Wei Dai
2017-01-10 15:45 ` [dpdk-dev] [PATCH 4/7] net/ixgbe/base: support Marvell 1000BASE-T PHYs Wei Dai
2017-01-10 15:45 ` [dpdk-dev] [PATCH 5/7] net/ixgbe/base: use clause 22 MDIO functions for Marvell PHYs Wei Dai
2017-01-10 15:45 ` [dpdk-dev] [PATCH 6/7] net/ixgbe/base: add some debug traces Wei Dai
2017-01-11 15:38 ` Ferruh Yigit
2017-01-12 14:18 ` Dai, Wei
2017-01-12 14:21 ` Ferruh Yigit
2017-01-10 15:45 ` [dpdk-dev] [PATCH 7/7] net/ixgbe/base: update version of shared code Wei Dai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=109611bd-cd54-2e65-fa5e-40455e5aaa99@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=wei.dai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).