From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Markos Chandras <mchandras@suse.de>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mk: toolchain: gcc: query the compiler macros to obtain the gcc version
Date: Wed, 23 Mar 2016 10:49:27 +0100 [thread overview]
Message-ID: <10969139.eXE434OmqC@xps13> (raw)
In-Reply-To: <56F1CC20.50707@suse.de>
2016-03-22 22:50, Markos Chandras:
> On 22/03/16 22:34, Thomas Monjalon wrote:
> > 2016-03-22 17:13, Markos Chandras:
> >> This is similar to what's being used in the Linux kernel. Querying the
> >> GCC macros directly gives more accurate results compared to -dumpversion
> >> which could vary across distributions.
> >>
> >> Signed-off-by: Markos Chandras <mchandras@suse.de>
> >> ---
> >> In openSUSE Tumbleweed (and in any other SUSE distribution which
> >> uses (or will use) gcc >= 5), gcc -dumpversion returns '5'. This is on
> >> purpose as discussed in https://bugzilla.opensuse.org/show_bug.cgi?id=941428
> >
> > Good to know. It could be in the commit log.
>
> I can add this information to the commit message and send a v2 if needed.
I will apply with this info.
> >> -GCC_VERSION = $(subst .,,$(shell $(CC) -dumpversion | cut -f1-2 -d.))
> >> +GCC_MAJOR = $(shell echo __GNUC__ | $(CC) -E -x c - | tail -n 1)
> >> +GCC_MINOR = $(shell echo __GNUC_MINOR__ | $(CC) -E -x c - | tail -n 1)
> >> +GCC_VERSION = $(GCC_MAJOR)$(GCC_MINOR)
> >
> > Are we sure the minor will always be only one digit?
>
> Well, I can't be sure but minor has always been a single digit since gcc
> >= 3 if I am not mistaken. But does it matter? What if it is two or more
> digits? The previous code did something similar so if you had gcc
> 5.12.34 installed (and lets assume this is what is being returned by
> -dumpversion), it would have returned 512. The comparison would still
> work as it is at the moment no?
Yes, I was asking for an improvement in case it could happen.
But GCC is probably conservative with numbering so we can keep only one digit.
next prev parent reply other threads:[~2016-03-23 9:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 17:13 Markos Chandras
2016-03-22 22:34 ` Thomas Monjalon
2016-03-22 22:50 ` Markos Chandras
2016-03-23 9:49 ` Thomas Monjalon [this message]
2016-03-23 9:56 ` Markos Chandras
2016-03-23 10:00 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10969139.eXE434OmqC@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=mchandras@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).