From: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>
To: Ori Kam <orika@mellanox.com>,
arybchenko@solarflare.com, ferruh.yigit@intel.com,
stephen@networkplumber.org, adrien.mazarguil@6wind.com
Cc: dev@dpdk.org, dekelp@mellanox.com, thomas@monjalon.net,
nelio.laranjeiro@6wind.com, yskoh@mellanox.com,
shahafs@mellanox.com
Subject: Re: [dpdk-dev] [PATCH v2 3/3] ethdev: remove vxlan and nvgre encapsulation commands
Date: Fri, 5 Oct 2018 14:27:15 +0100 [thread overview]
Message-ID: <10c73dc1-dbc8-ce7b-cffb-42f930de28f5@intel.com> (raw)
In-Reply-To: <1537995646-95260-4-git-send-email-orika@mellanox.com>
On 26/09/2018 22:00, Ori Kam wrote:
> This patch removes the VXLAN and NVGRE encapsulation commands.
>
> Those commands are subset of the TUNNEL_ENCAP command so there is no
> need to keep both versions.
>
> Signed-off-by: Ori Kam <orika@mellanox.com>
> ---
> doc/guides/prog_guide/rte_flow.rst | 107 -------------------------------------
> lib/librte_ethdev/rte_flow.h | 103 -----------------------------------
> 2 files changed, 210 deletions(-)
>
> diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst
> index 3ba8018..9e739f3 100644
> --- a/doc/guides/prog_guide/rte_flow.rst
> +++ b/doc/guides/prog_guide/rte_flow.rst
> @@ -1969,113 +1969,6 @@ Implements ``OFPAT_PUSH_MPLS`` ("push a new MPLS tag") as defined by the
> | ``ethertype`` | EtherType |
> +---------------+-----------+
>
> -Action: ``VXLAN_ENCAP``
> -^^^^^^^^^^^^^^^^^^^^^^^
> -
> -Performs a VXLAN encapsulation action by encapsulating the matched flow in the
> -VXLAN tunnel as defined in the``rte_flow_action_vxlan_encap`` flow items
> -definition.
> -
> -This action modifies the payload of matched flows. The flow definition specified
> -in the ``rte_flow_action_tunnel_encap`` action structure must define a valid
> -VLXAN network overlay which conforms with RFC 7348 (Virtual eXtensible Local
> -Area Network (VXLAN): A Framework for Overlaying Virtualized Layer 2 Networks
> -over Layer 3 Networks). The pattern must be terminated with the
> -RTE_FLOW_ITEM_TYPE_END item type.
> -
> -.. _table_rte_flow_action_vxlan_encap:
> -
> -.. table:: VXLAN_ENCAP
> -
> - +----------------+-------------------------------------+
> - | Field | Value |
> - +================+=====================================+
> - | ``definition`` | Tunnel end-point overlay definition |
> - +----------------+-------------------------------------+
> -
> -.. _table_rte_flow_action_vxlan_encap_example:
> -
> -.. table:: IPv4 VxLAN flow pattern example.
> -
> - +-------+----------+
> - | Index | Item |
> - +=======+==========+
> - | 0 | Ethernet |
> - +-------+----------+
> - | 1 | IPv4 |
> - +-------+----------+
> - | 2 | UDP |
> - +-------+----------+
> - | 3 | VXLAN |
> - +-------+----------+
> - | 4 | END |
> - +-------+----------+
> -
> -Action: ``VXLAN_DECAP``
> -^^^^^^^^^^^^^^^^^^^^^^^
> -
> -Performs a decapsulation action by stripping all headers of the VXLAN tunnel
> -network overlay from the matched flow.
> -
> -The flow items pattern defined for the flow rule with which a ``VXLAN_DECAP``
> -action is specified, must define a valid VXLAN tunnel as per RFC7348. If the
> -flow pattern does not specify a valid VXLAN tunnel then a
> -RTE_FLOW_ERROR_TYPE_ACTION error should be returned.
> -
> -This action modifies the payload of matched flows.
> -
> -Action: ``NVGRE_ENCAP``
> -^^^^^^^^^^^^^^^^^^^^^^^
> -
> -Performs a NVGRE encapsulation action by encapsulating the matched flow in the
> -NVGRE tunnel as defined in the``rte_flow_action_tunnel_encap`` flow item
> -definition.
> -
> -This action modifies the payload of matched flows. The flow definition specified
> -in the ``rte_flow_action_tunnel_encap`` action structure must defined a valid
> -NVGRE network overlay which conforms with RFC 7637 (NVGRE: Network
> -Virtualization Using Generic Routing Encapsulation). The pattern must be
> -terminated with the RTE_FLOW_ITEM_TYPE_END item type.
> -
> -.. _table_rte_flow_action_nvgre_encap:
> -
> -.. table:: NVGRE_ENCAP
> -
> - +----------------+-------------------------------------+
> - | Field | Value |
> - +================+=====================================+
> - | ``definition`` | NVGRE end-point overlay definition |
> - +----------------+-------------------------------------+
> -
> -.. _table_rte_flow_action_nvgre_encap_example:
> -
> -.. table:: IPv4 NVGRE flow pattern example.
> -
> - +-------+----------+
> - | Index | Item |
> - +=======+==========+
> - | 0 | Ethernet |
> - +-------+----------+
> - | 1 | IPv4 |
> - +-------+----------+
> - | 2 | NVGRE |
> - +-------+----------+
> - | 3 | END |
> - +-------+----------+
> -
> -Action: ``NVGRE_DECAP``
> -^^^^^^^^^^^^^^^^^^^^^^^
> -
> -Performs a decapsulation action by stripping all headers of the NVGRE tunnel
> -network overlay from the matched flow.
> -
> -The flow items pattern defined for the flow rule with which a ``NVGRE_DECAP``
> -action is specified, must define a valid NVGRE tunnel as per RFC7637. If the
> -flow pattern does not specify a valid NVGRE tunnel then a
> -RTE_FLOW_ERROR_TYPE_ACTION error should be returned.
> -
> -This action modifies the payload of matched flows.
> -
> Action: ``TUNNEL_ENCAP``
> ^^^^^^^^^^^^^^^^^^^^^^^^
>
> diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h
> index e29c561..55521e3 100644
> --- a/lib/librte_ethdev/rte_flow.h
> +++ b/lib/librte_ethdev/rte_flow.h
> @@ -1473,40 +1473,6 @@ enum rte_flow_action_type {
> RTE_FLOW_ACTION_TYPE_OF_PUSH_MPLS,
>
> /**
> - * Encapsulate flow in VXLAN tunnel as defined in
> - * rte_flow_action_vxlan_encap action structure.
> - *
> - * See struct rte_flow_action_vxlan_encap.
> - */
> - RTE_FLOW_ACTION_TYPE_VXLAN_ENCAP,
> -
> - /**
> - * Decapsulate outer most VXLAN tunnel from matched flow.
> - *
> - * If flow pattern does not define a valid VXLAN tunnel (as specified by
> - * RFC7348) then the PMD should return a RTE_FLOW_ERROR_TYPE_ACTION
> - * error.
> - */
> - RTE_FLOW_ACTION_TYPE_VXLAN_DECAP,
> -
> - /**
> - * Encapsulate flow in NVGRE tunnel defined in the
> - * rte_flow_action_nvgre_encap action structure.
> - *
> - * See struct rte_flow_action_nvgre_encap.
> - */
> - RTE_FLOW_ACTION_TYPE_NVGRE_ENCAP,
> -
> - /**
> - * Decapsulate outer most NVGRE tunnel from matched flow.
> - *
> - * If flow pattern does not define a valid NVGRE tunnel (as specified by
> - * RFC7637) then the PMD should return a RTE_FLOW_ERROR_TYPE_ACTION
> - * error.
> - */
> - RTE_FLOW_ACTION_TYPE_NVGRE_DECAP,
> -
> - /**
> * Encapsulate the packet with tunnel header as defined in
> * rte_flow_action_tunnel_encap action structure.
> *
> @@ -1837,75 +1803,6 @@ struct rte_flow_action_of_push_mpls {
> * @warning
> * @b EXPERIMENTAL: this structure may change without prior notice
> *
> - * RTE_FLOW_ACTION_TYPE_VXLAN_ENCAP
> - *
> - * VXLAN tunnel end-point encapsulation data definition
> - *
> - * The tunnel definition is provided through the flow item pattern, the
> - * provided pattern must conform to RFC7348 for the tunnel specified. The flow
> - * definition must be provided in order from the RTE_FLOW_ITEM_TYPE_ETH
> - * definition up the end item which is specified by RTE_FLOW_ITEM_TYPE_END.
> - *
> - * The mask field allows user to specify which fields in the flow item
> - * definitions can be ignored and which have valid data and can be used
> - * verbatim.
> - *
> - * Note: the last field is not used in the definition of a tunnel and can be
> - * ignored.
> - *
> - * Valid flow definition for RTE_FLOW_ACTION_TYPE_VXLAN_ENCAP include:
> - *
> - * - ETH / IPV4 / UDP / VXLAN / END
> - * - ETH / IPV6 / UDP / VXLAN / END
> - * - ETH / VLAN / IPV4 / UDP / VXLAN / END
> - *
> - */
> -struct rte_flow_action_vxlan_encap {
> - /**
> - * Encapsulating vxlan tunnel definition
> - * (terminated by the END pattern item).
> - */
> - struct rte_flow_item *definition;
> -};
> -
> -/**
> - * @warning
> - * @b EXPERIMENTAL: this structure may change without prior notice
> - *
> - * RTE_FLOW_ACTION_TYPE_NVGRE_ENCAP
> - *
> - * NVGRE tunnel end-point encapsulation data definition
> - *
> - * The tunnel definition is provided through the flow item pattern the
> - * provided pattern must conform with RFC7637. The flow definition must be
> - * provided in order from the RTE_FLOW_ITEM_TYPE_ETH definition up the end item
> - * which is specified by RTE_FLOW_ITEM_TYPE_END.
> - *
> - * The mask field allows user to specify which fields in the flow item
> - * definitions can be ignored and which have valid data and can be used
> - * verbatim.
> - *
> - * Note: the last field is not used in the definition of a tunnel and can be
> - * ignored.
> - *
> - * Valid flow definition for RTE_FLOW_ACTION_TYPE_NVGRE_ENCAP include:
> - *
> - * - ETH / IPV4 / NVGRE / END
> - * - ETH / VLAN / IPV6 / NVGRE / END
> - *
> - */
> -struct rte_flow_action_nvgre_encap {
> - /**
> - * Encapsulating vxlan tunnel definition
> - * (terminated by the END pattern item).
> - */
> - struct rte_flow_item *definition;
> -};
> -
> -/**
> - * @warning
> - * @b EXPERIMENTAL: this structure may change without prior notice
> - *
> * RTE_FLOW_ACTION_TYPE_TUNNEL_ENCAP
> *
> * Tunnel end-point encapsulation data definition
Acked-by: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>
next prev parent reply other threads:[~2018-10-05 13:27 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-16 16:53 [dpdk-dev] [PATCH 0/3] add generic L2/L3 tunnel encapsulation actions Ori Kam
2018-09-16 16:53 ` [dpdk-dev] [PATCH 1/3] ethdev: " Ori Kam
2018-09-16 16:53 ` [dpdk-dev] [PATCH 2/3] ethdev: convert testpmd encap commands to new API Ori Kam
2018-09-16 16:53 ` [dpdk-dev] [PATCH 3/3] ethdev: remove vxlan and nvgre encapsulation commands Ori Kam
2018-09-26 21:00 ` [dpdk-dev] [PATCH v2 0/3] ethdev: add generic L2/L3 tunnel encapsulation actions Ori Kam
2018-09-26 21:00 ` [dpdk-dev] [PATCH v2 1/3] " Ori Kam
2018-09-26 21:00 ` [dpdk-dev] [PATCH v2 2/3] app/testpmd: convert testpmd encap commands to new API Ori Kam
2018-09-26 21:00 ` [dpdk-dev] [PATCH v2 3/3] ethdev: remove vxlan and nvgre encapsulation commands Ori Kam
2018-10-05 12:59 ` Ferruh Yigit
2018-10-05 13:26 ` Awal, Mohammad Abdul
2018-10-05 13:27 ` Mohammad Abdul Awal [this message]
2018-10-03 20:38 ` [dpdk-dev] [PATCH v2 0/3] ethdev: add generic L2/L3 tunnel encapsulation actions Thomas Monjalon
2018-10-05 12:57 ` Ferruh Yigit
2018-10-05 14:00 ` Ori Kam
2018-10-07 12:57 ` [dpdk-dev] [PATCH v3 " Ori Kam
2018-10-07 12:57 ` [dpdk-dev] [PATCH v3 1/3] " Ori Kam
2018-10-07 12:57 ` [dpdk-dev] [PATCH v3 2/3] app/testpmd: convert testpmd encap commands to new API Ori Kam
2018-10-07 12:57 ` [dpdk-dev] [PATCH v3 3/3] ethdev: remove vxlan and nvgre encapsulation commands Ori Kam
2018-10-09 16:48 ` [dpdk-dev] [PATCH v3 0/3] ethdev: add generic L2/L3 tunnel encapsulation actions Ferruh Yigit
2018-10-10 6:45 ` Andrew Rybchenko
2018-10-10 9:00 ` Ori Kam
2018-10-10 9:30 ` Andrew Rybchenko
2018-10-10 9:38 ` Thomas Monjalon
2018-10-10 12:02 ` Adrien Mazarguil
2018-10-10 13:17 ` Ori Kam
2018-10-10 16:10 ` Adrien Mazarguil
2018-10-11 8:48 ` Ori Kam
2018-10-11 13:12 ` Adrien Mazarguil
2018-10-11 13:55 ` Ori Kam
2018-10-16 21:40 ` [dpdk-dev] [PATCH v4 0/3] ethdev: add generic raw " Ori Kam
2018-10-16 21:41 ` [dpdk-dev] [PATCH v4 1/3] ethdev: add raw encapsulation action Ori Kam
2018-10-17 7:56 ` Andrew Rybchenko
2018-10-17 8:43 ` Ori Kam
2018-10-22 13:06 ` Andrew Rybchenko
2018-10-22 13:19 ` Ori Kam
2018-10-22 13:27 ` Andrew Rybchenko
2018-10-22 13:32 ` Ori Kam
2018-10-16 21:41 ` [dpdk-dev] [PATCH v4 2/3] app/testpmd: add MPLSoUDP encapsulation Ori Kam
2018-10-16 21:41 ` [dpdk-dev] [PATCH v4 3/3] app/testpmd: add MPLSoGRE encapsulation Ori Kam
2018-10-17 17:07 ` [dpdk-dev] [PATCH v5 0/3] ethdev: add generic raw tunnel encapsulation actions Ori Kam
2018-10-17 17:07 ` [dpdk-dev] [PATCH v5 1/3] ethdev: add raw encapsulation action Ori Kam
2018-10-22 14:15 ` Andrew Rybchenko
2018-10-22 14:31 ` Ori Kam
2018-10-17 17:07 ` [dpdk-dev] [PATCH v5 2/3] app/testpmd: add MPLSoUDP encapsulation Ori Kam
2018-10-17 17:07 ` [dpdk-dev] [PATCH v5 3/3] app/testpmd: add MPLSoGRE encapsulation Ori Kam
2018-10-22 14:45 ` [dpdk-dev] [PATCH v5 0/3] ethdev: add generic raw tunnel encapsulation actions Ferruh Yigit
2018-10-22 17:38 ` [dpdk-dev] [PATCH v6 0/3] ethdev: add generic raw tunnel encapsulation Ori Kam
2018-10-22 17:38 ` [dpdk-dev] [PATCH v6 1/3] ethdev: add raw encapsulation action Ori Kam
2018-10-22 17:38 ` [dpdk-dev] [PATCH v6 2/3] app/testpmd: add MPLSoUDP encapsulation Ori Kam
2018-10-23 9:55 ` Ferruh Yigit
2018-10-22 17:38 ` [dpdk-dev] [PATCH v6 3/3] app/testpmd: add MPLSoGRE encapsulation Ori Kam
2018-10-23 9:56 ` Ferruh Yigit
2018-10-23 9:56 ` [dpdk-dev] [PATCH v6 0/3] ethdev: add generic raw tunnel encapsulation Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10c73dc1-dbc8-ce7b-cffb-42f930de28f5@intel.com \
--to=mohammad.abdul.awal@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=arybchenko@solarflare.com \
--cc=dekelp@mellanox.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=orika@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).