From: "Mattias Rönnblom" <hofors@lysator.liu.se>
To: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
Cc: jerinj@marvell.com, mattias.ronnblom@ericsson.com,
abdullah.sevincer@intel.com, sachin.saxena@oss.nxp.com,
hemant.agrawal@nxp.com, pbhagavatula@marvell.com,
pravin.pathak@intel.com, stable@dpdk.org
Subject: Re: [PATCH v2 07/11] eventdev: fix documentation for counting single-link ports
Date: Tue, 23 Jan 2024 10:48:47 +0100 [thread overview]
Message-ID: <10e10beb-b842-425d-a591-4992e06255cb@lysator.liu.se> (raw)
In-Reply-To: <20240119174346.108905-8-bruce.richardson@intel.com>
On 2024-01-19 18:43, Bruce Richardson wrote:
> The documentation of how single-link port-queue pairs were counted in
> the rte_event_dev_config structure did not match the actual
> implementation and, if following the documentation, certain valid
What "documentation" and what "implementation" are you talking about here?
I'm confused. An DLB2 fix in the form of Eventdev API documentation update.
> port/queue configurations would have been impossible to configure. Fix
> this by changing the documentation to match the implementation - however
> confusing that implementation ends up being.
>
> Bugzilla ID: 1368
> Fixes: 75d113136f38 ("eventdev: express DLB/DLB2 PMD constraints")
> Cc: stable@dpdk.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> lib/eventdev/rte_eventdev.h | 28 ++++++++++++++++++++++------
> 1 file changed, 22 insertions(+), 6 deletions(-)
>
> diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h
> index 4139ccb982..3b8f5b8101 100644
> --- a/lib/eventdev/rte_eventdev.h
> +++ b/lib/eventdev/rte_eventdev.h
> @@ -490,7 +490,10 @@ struct rte_event_dev_info {
> uint32_t dequeue_timeout_ns;
> /**< Configured global dequeue timeout(ns) for this device */
> uint8_t max_event_queues;
> - /**< Maximum event queues supported by this device */
> + /**< Maximum event queues supported by this device.
> + * This excludes any queue-port pairs covered by the
> + * *max_single_link_event_port_queue_pairs* value in this structure.
> + */
> uint32_t max_event_queue_flows;
> /**< Maximum number of flows within an event queue supported by this device*/
> uint8_t max_event_queue_priority_levels;
> @@ -506,7 +509,10 @@ struct rte_event_dev_info {
> * @ref RTE_EVENT_DEV_PRIORITY_HIGHEST and @ref RTE_EVENT_DEV_PRIORITY_LOWEST.
> */
> uint8_t max_event_ports;
> - /**< Maximum number of event ports supported by this device */
> + /**< Maximum number of event ports supported by this device
> + * This excludes any queue-port pairs covered by the
> + * *max_single_link_event_port_queue_pairs* value in this structure.
> + */
> uint8_t max_event_port_dequeue_depth;
> /**< Maximum number of events that can be dequeued at a time from an event port
> * on this device.
> @@ -618,13 +624,23 @@ struct rte_event_dev_config {
> */
> uint8_t nb_event_queues;
> /**< Number of event queues to configure on this device.
> - * This value cannot exceed @ref rte_event_dev_info.max_event_queues
> - * returned by rte_event_dev_info_get()
> + * This value *includes* any single-link queue-port pairs to be used.
> + * This value cannot exceed @ref rte_event_dev_info.max_event_queues +
> + * @ref rte_event_dev_info.max_single_link_event_port_queue_pairs
> + * returned by rte_event_dev_info_get().
> + * The number of non-single-link queues i.e. this value less
> + * *nb_single_link_event_port_queues* in this struct, cannot exceed
> + * @ref rte_event_dev_info.max_event_queues
> */
> uint8_t nb_event_ports;
> /**< Number of event ports to configure on this device.
> - * This value cannot exceed @ref rte_event_dev_info.max_event_ports
> - * returned by rte_event_dev_info_get()
> + * This value *includes* any single-link queue-port pairs to be used.
> + * This value cannot exceed @ref rte_event_dev_info.max_event_ports +
> + * @ref rte_event_dev_info.max_single_link_event_port_queue_pairs
> + * returned by rte_event_dev_info_get().
> + * The number of non-single-link ports i.e. this value less
> + * *nb_single_link_event_port_queues* in this struct, cannot exceed
> + * @ref rte_event_dev_info.max_event_ports
> */
> uint32_t nb_event_queue_flows;
> /**< Max number of flows needed for a single event queue on this device.
next prev parent reply other threads:[~2024-01-23 9:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240118134557.73172-1-bruce.richardson@intel.com>
2024-01-18 13:45 ` [PATCH v1 7/7] " Bruce Richardson
[not found] ` <20240119174346.108905-1-bruce.richardson@intel.com>
2024-01-19 17:43 ` [PATCH v2 07/11] " Bruce Richardson
2024-01-23 9:48 ` Mattias Rönnblom [this message]
2024-01-23 9:56 ` Bruce Richardson
2024-01-31 16:18 ` Bruce Richardson
[not found] ` <20240221103221.933238-1-bruce.richardson@intel.com>
2024-02-21 10:32 ` [PATCH v4 12/12] eventdev: fix doxygen processing of event vector struct Bruce Richardson
2024-02-26 6:53 ` [EXT] " Pavan Nikhilesh Bhagavatula
2024-03-04 15:35 ` Thomas Monjalon
2024-03-04 15:49 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10e10beb-b842-425d-a591-4992e06255cb@lysator.liu.se \
--to=hofors@lysator.liu.se \
--cc=abdullah.sevincer@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=jerinj@marvell.com \
--cc=mattias.ronnblom@ericsson.com \
--cc=pbhagavatula@marvell.com \
--cc=pravin.pathak@intel.com \
--cc=sachin.saxena@oss.nxp.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).