From: "Guo, Jia" <jia.guo@intel.com>
To: "Yu, DapengX" <dapengx.yu@intel.com>,
"Wang, Haiyue" <haiyue.wang@intel.com>,
"Yang, Qiming" <qiming.yang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Yu, DapengX" <dapengx.yu@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v3] net/ixgbe: disable NFS filtering
Date: Tue, 26 Jan 2021 03:36:29 +0000 [thread overview]
Message-ID: <11023810106f47adbcd2186cc810753a@intel.com> (raw)
In-Reply-To: <20210126030308.517216-1-dapengx.yu@intel.com>
Acked-by: Jeff Guo <jia.guo@intel.com>
> -----Original Message-----
> From: dapengx.yu@intel.com <dapengx.yu@intel.com>
> Sent: Tuesday, January 26, 2021 11:03 AM
> To: Guo, Jia <jia.guo@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>;
> Yang, Qiming <qiming.yang@intel.com>
> Cc: dev@dpdk.org; Yu, DapengX <dapengx.yu@intel.com>; stable@dpdk.org
> Subject: [PATCH v3] net/ixgbe: disable NFS filtering
>
> From: Dapeng Yu <dapengx.yu@intel.com>
>
> Disable NFS header filtering whether NFS packets coalescing are required or
> not, in order to make RSS can work on NFS packets.
>
> The code without the patch does follow datasheet, but not consistent with
> the ixgbe kernel driver. It causes NFS packets to be filtered and make them
> flow into queue 0, before RSS can work on them.
>
> Fixes: b826efba6de4 ("net/ixgbe: align register setting when RSC is disabled")
> Fixes: 8eecb3295aed ("ixgbe: add LRO support")
> Cc: stable@dpdk.org
>
> Signed-off-by: Dapeng Yu <dapengx.yu@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_rxtx.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
> index cc8f70e6d..2efd054f7 100644
> --- a/drivers/net/ixgbe/ixgbe_rxtx.c
> +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> @@ -4923,15 +4923,11 @@ ixgbe_set_rsc(struct rte_eth_dev *dev)
> /* RFCTL configuration */
> rfctl = IXGBE_READ_REG(hw, IXGBE_RFCTL);
> if ((rsc_capable) && (rx_conf->offloads &
> DEV_RX_OFFLOAD_TCP_LRO))
> - /*
> - * Since NFS packets coalescing is not supported - clear
> - * RFCTL.NFSW_DIS and RFCTL.NFSR_DIS when RSC is
> - * enabled.
> - */
> - rfctl &= ~(IXGBE_RFCTL_RSC_DIS | IXGBE_RFCTL_NFSW_DIS
> |
> - IXGBE_RFCTL_NFSR_DIS);
> + rfctl &= ~IXGBE_RFCTL_RSC_DIS;
> else
> rfctl |= IXGBE_RFCTL_RSC_DIS;
> + /* disable NFS filtering */
> + rfctl |= IXGBE_RFCTL_NFSW_DIS | IXGBE_RFCTL_NFSR_DIS;
> IXGBE_WRITE_REG(hw, IXGBE_RFCTL, rfctl);
>
> /* If LRO hasn't been requested - we are done here. */
> --
> 2.27.0
next prev parent reply other threads:[~2021-01-26 3:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 9:27 [dpdk-stable] [PATCH] " dapengx.yu
2021-01-22 5:33 ` Guo, Jia
2021-01-22 7:06 ` Yu, DapengX
2021-01-25 3:10 ` [dpdk-stable] [PATCH v2] " dapengx.yu
2021-01-26 2:11 ` Guo, Jia
2021-01-26 2:19 ` Yu, DapengX
2021-01-26 3:03 ` [dpdk-stable] [PATCH v3] " dapengx.yu
2021-01-26 3:36 ` Guo, Jia [this message]
2021-01-26 4:36 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11023810106f47adbcd2186cc810753a@intel.com \
--to=jia.guo@intel.com \
--cc=dapengx.yu@intel.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).