From: Thomas Monjalon <thomas@monjalon.net>
To: Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: dev@dpdk.org, slawomirx.mrozowicz@intel.com,
cristian.dumitrescu@intel.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v3] examples/qos_sched: fix core limit for lower num of lcore
Date: Fri, 21 Jul 2017 17:38:21 +0300 [thread overview]
Message-ID: <11060553.V3FFf1BMrP@xps> (raw)
In-Reply-To: <1500451990-31199-1-git-send-email-hemant.agrawal@nxp.com>
19/07/2017 11:13, Hemant Agrawal:
> APP_MAX_LCORES is hardcoded as 64.
> This will cause build err when RTE_MAX_LCORE is less then 64.
>
> "args.c:127:22: error: iteration 8 invokes undefined behavior
> [-Werror=aggressive-loop-optimizations]
> if (cfg->lcore_role[i] == ROLE_RTE)
> ~~~~~~~~~~~~~~~^~~
> args.c:126:2: note: within this loop
> for (i = 0; i < APP_MAX_LCORE; i++) {"
>
> Fixes: d52b5e735aa3 ("examples/qos_sched: fix lcore limit")
> Cc: stable@dpdk.org
>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
> v3: fix as per review comment of Thomas
Applied, thanks
prev parent reply other threads:[~2017-07-21 14:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 5:49 [dpdk-stable] [PATCH] " Hemant Agrawal
2017-07-17 8:37 ` [dpdk-stable] [PATCH v2] " Hemant Agrawal
2017-07-19 5:24 ` Thomas Monjalon
2017-07-19 7:58 ` Hemant Agrawal
2017-07-19 8:13 ` [dpdk-stable] [PATCH v3] " Hemant Agrawal
2017-07-21 14:38 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11060553.V3FFf1BMrP@xps \
--to=thomas@monjalon.net \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=slawomirx.mrozowicz@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).