From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] devtools: add test script for meson builds
Date: Sat, 26 May 2018 11:32:53 +0200 [thread overview]
Message-ID: <11072939.itZiRipOQY@xps> (raw)
In-Reply-To: <20180525151858.GA18500@bricha3-MOBL.ger.corp.intel.com>
25/05/2018 17:18, Bruce Richardson:
> On Fri, May 25, 2018 at 04:51:58PM +0200, Thomas Monjalon wrote:
> > +default_path=$PATH
> > +
> > +# Load config options
> > +. $(dirname $(readlink -e $0))/load-devel-config
> > +
>
> Why is this needed here, it seems to be called before each individual
> config anyway.
Right, it can be removed from here.
> > +reset_env ()
> > +{
> > + export PATH=$default_path
> > + unset CROSS
> > + unset ARMV8_CRYPTO_LIB_PATH
> > + unset FLEXRAN_SDK
> > + unset LIBMUSDK_PATH
> > + unset LIBSSO_SNOW3G_PATH
> > + unset LIBSSO_KASUMI_PATH
> > + unset LIBSSO_ZUC_PATH
> > + unset PQOS_INSTALL_PATH
>
> These variables bar PATH are unused by meson build, so should be removed
> here to avoid giving the impression they are use.
Actually they should be used when compiling.
PATH can be used to allow a toolchain which is not in the standard path.
And dependencies _PATH variables can be specified only for some builds.
Example: I have libsso only for x86 64-bit, so I do not set it
for 32-bit or ARM builds. The config file reads DPDK_TARGET to know.
Note: DPDK_TARGET is not yet set correctly for every builds in this version.
> $CROSS is used by the
> script so perhaps it can be kept. However, the whole point of the
> cross-files is that you include all the needed details of your compiler
> there. I think we should move away from using the CROSS value completely,
> and use the cross-files properly.
Yes we can remove CROSS if it is redundant with config files in config/arm/.
But I do not understand why these files cannot be agnostic regarding the
name (CROSS) of the toolchain.
To me it is very strange to have the binary names hard-linked in the configs.
Anyway, this discussion is out of the scope of this script.
So I am for removing the CROSS variable and use aarch64-linux-gnu-gcc
as it is hard written in every ARM configs for now.
> > +cd $(dirname $(readlink -m $0))/..
> > +
> I don't think we should force the builds to be always put into the base
> directory. Instead of using cd, I think we should instead capture the base
> directory path and pass that to meson.
OK to not force the directory.
You want to build in the current directory?
If yes, we can just remove this "cd" and no need to pass a base directory
to meson.
> > +load_config ()
> > +{
> > + reset_env
> > + . $(dirname $(readlink -e $0))/load-devel-config
> > + MESON=${MESON:-meson}
> > +}
> Why does this need to be done each time?
Because the config could be different for each build (see above).
next prev parent reply other threads:[~2018-05-26 9:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 12:32 [dpdk-dev] [PATCH] " Bruce Richardson
2018-04-24 14:36 ` Bruce Richardson
2018-04-24 14:38 ` Bruce Richardson
2018-05-25 14:51 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2018-05-25 15:18 ` Bruce Richardson
2018-05-26 9:32 ` Thomas Monjalon [this message]
2018-05-28 9:33 ` Bruce Richardson
2018-05-28 10:26 ` Thomas Monjalon
2018-05-28 13:20 ` Bruce Richardson
2018-05-29 10:38 ` Thomas Monjalon
2018-05-29 10:59 ` Bruce Richardson
2018-05-26 9:54 ` [dpdk-dev] [PATCH v3] " Thomas Monjalon
2018-05-26 11:21 ` [dpdk-dev] [PATCH v4] " Thomas Monjalon
2018-05-28 9:39 ` Bruce Richardson
2018-05-29 14:42 ` [dpdk-dev] [PATCH v5] " Thomas Monjalon
2018-05-29 14:58 ` Richardson, Bruce
2018-05-29 15:37 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11072939.itZiRipOQY@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).