From: Thomas Monjalon <thomas@monjalon.net>
To: Marek Pazdan <mpazdan@arista.com>
Cc: Ferruh Yigit <ferruh.yigit@amd.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
dev@dpdk.org
Subject: Re: [PATCH] lib: add get/set link settings interface
Date: Wed, 03 Apr 2024 18:13:38 +0200 [thread overview]
Message-ID: <11571616.jrtcCam0TZ@thomas> (raw)
In-Reply-To: <CAJUFdiGAnnmtXc1GhUe=CAQya5BYFhcLFiUx1WVs86-msdKvgw@mail.gmail.com>
03/04/2024 16:59, Marek Pazdan:
> Hi Thomas,
>
> Information like advertising: speed, pause, autonegotiation etc. and that
> same for link partner advertising.
speed and duplex are already provided in some existing API.
> I try to mimic ethtool since it's a common, well known and widely used tool
> so adding an API which provides the same set of information in case the
> interface is passthrough to dpdk will be useful I think.
DPDK API is widely used as well :)
I am not sure adding a new API for the same thing is a good idea.
> I've 2 more patches dependent on the one we are discussing now, but I need
> patchwork id to add dependency information. I need moderator approval for
> the current patch.
I've approved your mails,
but you would not need a manual approval if you register.
Note that you can disable receiving other threads in ML options.
See an explanation here:
https://www.dpdk.org/first-patch-submission-to-the-dpdk-open-source-project/
> On Wed, Apr 3, 2024 at 4:48 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> > 03/04/2024 15:59, Marek Pazdan:
> > > There are link settings parameters available from PMD drivers level
> > > which are currently not exposed to the user via consistent interface.
> > > When interface is available for system level those information can
> > > be acquired with 'ethtool DEVNAME' (ioctl: ETHTOOL_SLINKSETTINGS/
> > > ETHTOOL_GLINKSETTINGS). There are use cases where
> > > physical interface is passthrough to dpdk driver and is not available
> > > from system level. Information provided by ioctl carries information
> > > useful for link auto negotiation settings among others.
> >
> > Which information is missing exactly?
> > Why are you trying to mimic ethtool API?
> >
> > Please let's add what is missing instead of adding a full new API.
next prev parent reply other threads:[~2024-04-03 16:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 23:59 [PATCH] igc/ixgbe: " Marek Pazdan
2024-03-27 11:12 ` Bruce Richardson
2024-04-03 13:40 ` [PATCH] lib: " Marek Pazdan
2024-04-03 16:49 ` Tyler Retzlaff
2024-04-04 7:09 ` David Marchand
2024-04-05 0:55 ` Tyler Retzlaff
2024-04-05 0:56 ` Tyler Retzlaff
2024-04-05 8:58 ` David Marchand
2024-04-05 13:05 ` Dodji Seketeli
2024-04-03 13:59 ` Marek Pazdan
2024-04-03 14:48 ` Thomas Monjalon
2024-04-03 14:59 ` Marek Pazdan
2024-04-03 16:13 ` Thomas Monjalon [this message]
2024-04-03 17:23 ` Stephen Hemminger
2024-04-03 22:08 ` Marek Pazdan
2024-04-03 23:38 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11571616.jrtcCam0TZ@thomas \
--to=thomas@monjalon.net \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=mpazdan@arista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).