From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>, dev@dpdk.org
Cc: Scott Branden <scott.branden@broadcom.com>
Subject: Re: [dpdk-dev] [PATCH 3/4] mk: allow kernel artifacts to be located in output directory
Date: Fri, 30 Mar 2018 11:35:25 +0100 [thread overview]
Message-ID: <11afc40e-bb2b-b58c-87a9-7b841ed5412a@intel.com> (raw)
In-Reply-To: <20180321180629.58318-4-ajit.khaparde@broadcom.com>
On 3/21/2018 6:06 PM, Ajit Khaparde wrote:
> From: Scott Branden <scott.branden@broadcom.com>
>
> Allow kernel artifacts to be located in output directory specific
> by RTE_KERNELDIR_OUT.
How to use this variable, I tried following but kernel modules are still in same
place:
- make RTE_KERNELDIR_OUT=/tmp/kmod O=ferruh DESTDIR=/tmp/ferruh
- make RTE_KERNELDIR_OUT=/tmp/kmod O=ferruh DESTDIR=/tmp/ferruh install
- make RTE_KERNELDIR_OUT=/tmp/kmod O=ferruh DESTDIR=/tmp/ferruh modules_install
/tmp/kmod not created.
And what we are fixing here, what was wrong with old code?
> If RTE_KERNELDIR_OUT not specified than
> source directory RTE_KERNEL is used.
${RTE_KERNELDIR} is used as external Linux kernel source folder, why we are want
to put artifacts into kernel source?
>
> Signed-off-by: Scott Branden <scott.branden@broadcom.com>
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> ---
> mk/rte.module.mk | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/mk/rte.module.mk b/mk/rte.module.mk
> index 1ada528a0..e2e1af716 100644
> --- a/mk/rte.module.mk
> +++ b/mk/rte.module.mk
> @@ -39,6 +39,9 @@ _postinstall: build
> .PHONY: build
> build: _postbuild
>
> +# Allow kernel artifacts to be located in a different location that source
> +RTE_KERNELDIR_OUT ?= ${RTE_KERNELDIR}
> +
> # Link all sources in build directory
> %_link: FORCE
> $(if $(call compare,$(notdir $*),$*),\
> @@ -48,7 +51,7 @@ build: _postbuild
> # build module
> $(MODULE).ko: $(SRCS_LINKS)
> @if [ ! -f $(notdir Makefile) ]; then ln -nfs $(SRCDIR)/Makefile . ; fi
> - @$(MAKE) -C $(RTE_KERNELDIR) M=$(CURDIR) O=$(RTE_KERNELDIR) \
> + @$(MAKE) -C $(RTE_KERNELDIR) M=$(CURDIR) O=$(RTE_KERNELDIR_OUT) \
> CC="$(KERNELCC)" CROSS_COMPILE=$(CROSS) V=$(if $V,1,0)
>
> # install module in $(RTE_OUTPUT)/kmod
> @@ -59,7 +62,7 @@ $(RTE_OUTPUT)/kmod/$(MODULE).ko: $(MODULE).ko
>
> # install module
> modules_install:
> - @$(MAKE) -C $(RTE_KERNELDIR) M=$(CURDIR) O=$(RTE_KERNELDIR) \
> + @$(MAKE) -C $(RTE_KERNELDIR) M=$(CURDIR) O=$(RTE_KERNELDIR_OUT) \
> modules_install
>
> .PHONY: clean
> @@ -69,7 +72,7 @@ clean: _postclean
> .PHONY: doclean
> doclean:
> @if [ ! -f $(notdir Makefile) ]; then ln -nfs $(SRCDIR)/Makefile . ; fi
> - $(Q)$(MAKE) -C $(RTE_KERNELDIR) M=$(CURDIR) O=$(RTE_KERNELDIR) clean
> + $(Q)$(MAKE) -C $(RTE_KERNELDIR) M=$(CURDIR) O=$(RTE_KERNELDIR_OUT) clean
> @$(foreach FILE,$(SRCS-y) $(SRCS-n) $(SRCS-),\
> if [ -h $(notdir $(FILE)) ]; then rm -f $(notdir $(FILE)) ; fi ;)
> @if [ -h $(notdir Makefile) ]; then rm -f $(notdir Makefile) ; fi
>
next prev parent reply other threads:[~2018-03-30 10:35 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 18:06 [dpdk-dev] [PATCH 0/4] bnxt patchset Ajit Khaparde
2018-03-21 18:06 ` [dpdk-dev] [PATCH 1/4] introduce Broadcom Stingray Ajit Khaparde
2018-03-30 10:34 ` Ferruh Yigit
2018-03-30 18:54 ` Scott Branden
2018-03-21 18:06 ` [dpdk-dev] [PATCH 2/4] net/bnxt: add support for Stingray PF devices ids Ajit Khaparde
2018-03-30 10:35 ` Ferruh Yigit
2018-03-30 18:24 ` Scott Branden
2018-04-10 0:20 ` [dpdk-dev] [PATCH v4 0/3] bnxt patchset to support Stingray product family Ajit Khaparde
2018-04-10 0:20 ` [dpdk-dev] [PATCH v4 1/3] introduce Broadcom Stingray Ajit Khaparde
2018-04-10 0:20 ` [dpdk-dev] [PATCH v4 2/3] net/bnxt: add support for Stingray PF devices ids Ajit Khaparde
2018-04-10 0:20 ` [dpdk-dev] [PATCH v4 3/3] doc: add Broadcom Stingray SoC support to release notes Ajit Khaparde
2018-04-11 19:07 ` Ferruh Yigit
2018-04-13 21:07 ` [dpdk-dev] [PATCH v5 1/3] introduce Broadcom Stingray Ajit Khaparde
2018-04-13 21:07 ` [dpdk-dev] [PATCH v5 2/3] net/bnxt: add support for Stingray PF devices ids Ajit Khaparde
2018-04-13 21:07 ` [dpdk-dev] [PATCH v5 3/3] doc: add Broadcom Stingray SoC support to release notes Ajit Khaparde
2018-04-13 23:07 ` [dpdk-dev] [PATCH v5 1/3] introduce Broadcom Stingray Ferruh Yigit
2018-03-21 18:06 ` [dpdk-dev] [PATCH 3/4] mk: allow kernel artifacts to be located in output directory Ajit Khaparde
2018-03-30 10:35 ` Ferruh Yigit [this message]
2018-03-30 18:23 ` Scott Branden
2018-04-03 14:18 ` Ferruh Yigit
[not found] ` <CACZ4nhuwOp99YiaD75TzQ1igPgnjsayqHLnXyaNmmpySVZefPA@mail.gmail.com>
2018-04-06 18:10 ` Scott Branden
2018-04-06 21:31 ` Ferruh Yigit
2018-04-06 22:32 ` Scott Branden
2018-04-10 14:59 ` Ferruh Yigit
2018-04-10 20:30 ` Scott Branden
2018-03-21 18:06 ` [dpdk-dev] [PATCH 4/4] igb_uio: bind error if pcie bridge Ajit Khaparde
2018-03-26 17:24 ` Ferruh Yigit
2018-03-26 18:05 ` Scott Branden
2018-03-26 18:20 ` Ferruh Yigit
2018-03-26 19:13 ` Scott Branden
2018-03-26 20:43 ` [dpdk-dev] [PATCH v2] " Ajit Khaparde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11afc40e-bb2b-b58c-87a9-7b841ed5412a@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=scott.branden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).