From: Thomas Monjalon <thomas@monjalon.net>
To: jerb <jonathan.erb@banduracyber.com>
Cc: Stephen Hemminger <sthemmin@microsoft.com>,
dev@dpdk.org, Long Li <longli@microsoft.com>
Subject: Re: [dpdk-dev] [PATCH] bus/vmbus: Fix crash when handling packets in secondary process
Date: Thu, 22 Jul 2021 21:15:48 +0200 [thread overview]
Message-ID: <12614253.dWt8NKk3Zt@thomas> (raw)
In-Reply-To: <BY5PR21MB150616D609C9AC15AA9C2848CEE39@BY5PR21MB1506.namprd21.prod.outlook.com>
21/07/2021 02:17, Long Li:
> From: Stephen Hemminger <sthemmin@microsoft.com>
> >
> > Looks good, minor comment. You don't have to check for NULL before calling
> > rte_free().
> > Rte_free(NULL) is a NOP like free(NULL).
> >
> > Sorry for top posting; but if you send to my Microsoft account you are stuck
> > with what Outlook can do...
> >
> From: jerb <jonathan.erb@banduracyber.com>
> >
> > Have secondary processes construct their own copy of primary channel with
> > own mappings.
> >
> > Remove vmbus_channel primary ptr from struct mapped_vmbus_resource as
> > its not used.
> >
> > Populate virtual memory address "addr" in struct rte_mem_resource for
> > secondary processes as netvsc will attempt to reference it thus causing a crash.
> > It was initialized for primary processes but not for secondary.
> >
> > Signed-off-by: jerb <jonathan.erb@banduracyber.com>
Please give your complete name.
> Looks good.
>
> This should also go to stable.
Please send a v2 with Fixes and Cc: stable@dpdk.org lines
as documented in the contributor's guide.
If you don't know how to do, the maintainers can help.
Thank you
prev parent reply other threads:[~2021-07-22 19:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 14:58 jerb
2021-07-20 15:28 ` Stephen Hemminger
2021-07-21 0:17 ` Long Li
2021-07-22 19:15 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12614253.dWt8NKk3Zt@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=jonathan.erb@banduracyber.com \
--cc=longli@microsoft.com \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).