From: Ferruh Yigit <ferruh.yigit@intel.com>
To: dev@dpdk.org
Cc: Sony Chacko <sony.chacko@qlogic.com>,
Harish Patil <harish.patil@qlogic.com>,
Rasesh Mody <rasesh.mody@qlogic.com>
Subject: Re: [dpdk-dev] [PATCH] net/bnx2x: fix icc build error
Date: Mon, 17 Oct 2016 13:11:43 +0100 [thread overview]
Message-ID: <12674be5-bed0-6e61-7506-b6bb19460c97@intel.com> (raw)
In-Reply-To: <20160930144515.1770-1-ferruh.yigit@intel.com>
On 9/30/2016 3:45 PM, Ferruh Yigit wrote:
> When bnx2x debug config enabled, icc (ICC) 17.0.0 20160721
> gives the following compilation error:
>
> .../drivers/net/bnx2x/elink.c(6682):
> error #3656: variable "fw_ver1" may be used before its value is set
> PMD_DRV_LOG(DEBUG,
> ^
>
> According logic in the code, this error is a false positive,
> but since this is not in the fast path, fixing compiler error by
> assigning initial value to variable.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> drivers/net/bnx2x/elink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnx2x/elink.c b/drivers/net/bnx2x/elink.c
> index 149cc97..d9a72f0 100644
> --- a/drivers/net/bnx2x/elink.c
> +++ b/drivers/net/bnx2x/elink.c
> @@ -6645,7 +6645,7 @@ static elink_status_t elink_8073_8727_external_rom_boot(struct bnx2x_softc *sc,
> uint8_t port)
> {
> uint32_t count = 0;
> - uint16_t fw_ver1, fw_msgout;
> + uint16_t fw_ver1 = 0, fw_msgout;
> elink_status_t rc = ELINK_STATUS_OK;
>
> /* Boot port from external ROM */
>
Since this is an compilation fix, I believe it is good to have this in
the release, can you please review the patch?
Thanks,
ferruh
next prev parent reply other threads:[~2016-10-17 12:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 14:45 Ferruh Yigit
2016-10-17 12:11 ` Ferruh Yigit [this message]
2016-10-17 18:04 ` Mody, Rasesh
2016-10-19 9:24 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12674be5-bed0-6e61-7506-b6bb19460c97@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=harish.patil@qlogic.com \
--cc=rasesh.mody@qlogic.com \
--cc=sony.chacko@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).