From: Thomas Monjalon <thomas@monjalon.net>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: Fady Bader <fady@mellanox.com>,
dev@dpdk.org, tbashar@mellanox.com, talshn@mellanox.com,
yohadt@mellanox.com, harini.ramakrishnan@microsoft.com,
ocardona@microsoft.com, pallavi.kadam@intel.com,
ranjit.menon@intel.com, olivier.matz@6wind.com,
arybchenko@solarflare.com, mdr@ashroe.eu, nhorman@tuxdriver.com
Subject: Re: [dpdk-dev] [PATCH v2 2/4] mempool: use generic memory management
Date: Mon, 01 Jun 2020 23:14:41 +0200 [thread overview]
Message-ID: <12936534.z0KI8IRTVO@thomas> (raw)
In-Reply-To: <20200601225921.371ebfa6@sovereign>
01/06/2020 21:59, Dmitry Kozlyuk:
> 1. What do you think about changing rte_ to rte_eal_ prefix for memory
> management wrappers in MM series as Andrew Rybchenko suggested for v1? Since
> the functions are DPDK-internal, this sounds reasonable to me.
For lib-internal function, the prefix should not start with rte_.
For exported function (even if internal), the prefix should be rte_[component]_.
For memory related functions, rte_mem_ is better than rte_eal_.
next prev parent reply other threads:[~2020-06-01 21:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 10:31 [dpdk-dev] [PATCH v2 0/4] build mempool on Windows Fady Bader
2020-06-01 10:31 ` [dpdk-dev] [PATCH v2 1/4] eal: disable function versioning " Fady Bader
2020-06-01 19:55 ` Neil Horman
2020-06-01 21:46 ` [dpdk-dev] [EXTERNAL] " Omar Cardona
2020-06-02 10:27 ` Neil Horman
2020-06-02 10:40 ` Thomas Monjalon
2020-06-11 10:09 ` Kinsella, Ray
2020-06-01 10:31 ` [dpdk-dev] [PATCH v2 2/4] mempool: use generic memory management Fady Bader
2020-06-01 19:59 ` Dmitry Kozlyuk
2020-06-01 20:47 ` Ranjit Menon
2020-06-01 21:14 ` Thomas Monjalon [this message]
2020-06-02 7:40 ` Andrew Rybchenko
2020-06-01 10:31 ` [dpdk-dev] [PATCH v2 3/4] eal: export needed functions for mempool Fady Bader
2020-06-01 10:31 ` [dpdk-dev] [PATCH v2 4/4] mempool: mempool build on Windows Fady Bader
2020-06-02 7:41 ` Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12936534.z0KI8IRTVO@thomas \
--to=thomas@monjalon.net \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=fady@mellanox.com \
--cc=harini.ramakrishnan@microsoft.com \
--cc=mdr@ashroe.eu \
--cc=nhorman@tuxdriver.com \
--cc=ocardona@microsoft.com \
--cc=olivier.matz@6wind.com \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
--cc=talshn@mellanox.com \
--cc=tbashar@mellanox.com \
--cc=yohadt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).