From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 0/8] bnxt patchset
Date: Thu, 20 Jul 2017 11:02:46 +0100 [thread overview]
Message-ID: <12e05afb-d540-be7a-6d26-2229fd74a969@intel.com> (raw)
In-Reply-To: <20170720044826.44103-1-ajit.khaparde@broadcom.com>
On 7/20/2017 5:48 AM, Ajit Khaparde wrote:
> Hi,
> This patch set fixes some of the issues found during testing.
> Please apply.
>
> Thanks
>
> net/bnxt: fix log levels for non error conditions.
> net/bnxt: fix to avoid a segfault
> net/bnxt: fix vnic cleanup
> net/bnxt: fix set link config
> net/bnxt: reset VF stats during initialization
> net/bnxt: fix VLAN antispoof configuration code
> net/bnxt: check invalid l2_filter_id
> net/bnxt: fix to free a filter before reusing it
Getting following build errors, fyi:
.../drivers/net/bnxt/rte_pmd_bnxt.c:464:8: error: variable 'rc' is used
uninitialized whenever 'if' condition is false
[-Werror,-Wsometimes-uninitialized]
if (bnxt_hwrm_cfa_l2_set_rx_mask(bp, &vnic,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
.../drivers/net/bnxt/rte_pmd_bnxt.c:471:9: note: uninitialized use
occurs here
return rc;
^~
.../drivers/net/bnxt/rte_pmd_bnxt.c:464:4: note: remove the 'if' if its
condition is always true
if (bnxt_hwrm_cfa_l2_set_rx_mask(bp, &vnic,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
.../drivers/net/bnxt/rte_pmd_bnxt.c:462:7: error: variable 'rc' is used
uninitialized whenever 'if' condition is false
[-Werror,-Wsometimes-uninitialized]
if (bnxt_hwrm_vnic_qcfg(bp, &vnic,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
.../drivers/net/bnxt/rte_pmd_bnxt.c:471:9: note: uninitialized use
occurs here
return rc;
^~
.../drivers/net/bnxt/rte_pmd_bnxt.c:462:3: note: remove the 'if' if its
condition is always true
if (bnxt_hwrm_vnic_qcfg(bp, &vnic,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
.../drivers/net/bnxt/rte_pmd_bnxt.c:454:6: error: variable 'rc' is used
uninitialized whenever 'if' condition is true
[-Werror,-Wsometimes-uninitialized]
if (dflt_vnic < 0) {
^~~~~~~~~~~~~
.../drivers/net/bnxt/rte_pmd_bnxt.c:471:9: note: uninitialized use
occurs here
return rc;
^~
.../drivers/net/bnxt/rte_pmd_bnxt.c:454:2: note: remove the 'if' if its
condition is always false
if (dflt_vnic < 0) {
^~~~~~~~~~~~~~~~~~~~
.../drivers/net/bnxt/rte_pmd_bnxt.c:440:8: note: initialize the variable
'rc' to silence this warning
int rc;
^
= 0
3 errors generated.
next prev parent reply other threads:[~2017-07-20 10:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 4:48 Ajit Khaparde
2017-07-20 4:48 ` [dpdk-dev] [PATCH 1/8] net/bnxt: fix log levels for non error conditions Ajit Khaparde
2017-07-20 4:48 ` [dpdk-dev] [PATCH 2/8] net/bnxt: fix to avoid a segfault Ajit Khaparde
2017-07-20 9:56 ` Ferruh Yigit
2017-07-20 4:48 ` [dpdk-dev] [PATCH 3/8] net/bnxt: fix vnic cleanup Ajit Khaparde
2017-07-20 4:48 ` [dpdk-dev] [PATCH 4/8] net/bnxt: fix set link config Ajit Khaparde
2017-07-20 4:48 ` [dpdk-dev] [PATCH 5/8] net/bnxt: reset VF stats during initialization Ajit Khaparde
2017-07-20 4:48 ` [dpdk-dev] [PATCH 6/8] net/bnxt: fix VLAN antispoof configuration code Ajit Khaparde
2017-07-20 4:48 ` [dpdk-dev] [PATCH 7/8] net/bnxt: check invalid l2_filter_id Ajit Khaparde
2017-07-20 4:48 ` [dpdk-dev] [PATCH 8/8] net/bnxt: fix to free a filter before reusing it Ajit Khaparde
2017-07-20 10:02 ` Ferruh Yigit [this message]
2017-07-21 3:22 ` [dpdk-dev] [PATCH v2 0/8] bnxt patchset Ajit Khaparde
2017-07-21 3:22 ` [dpdk-dev] [PATCH v2 1/8] net/bnxt: fix log levels for non error conditions Ajit Khaparde
2017-07-21 3:22 ` [dpdk-dev] [PATCH v2 2/8] net/bnxt: fix to avoid a segfault Ajit Khaparde
2017-07-21 19:09 ` Stephen Hurd
2017-07-21 3:22 ` [dpdk-dev] [PATCH v2 3/8] net/bnxt: fix vnic cleanup Ajit Khaparde
2017-07-21 3:22 ` [dpdk-dev] [PATCH v2 4/8] net/bnxt: fix set link config Ajit Khaparde
2017-07-21 3:22 ` [dpdk-dev] [PATCH v2 5/8] net/bnxt: reset VF stats during initialization Ajit Khaparde
2017-07-21 3:22 ` [dpdk-dev] [PATCH v2 6/8] net/bnxt: fix VLAN antispoof configuration code Ajit Khaparde
2017-07-21 3:22 ` [dpdk-dev] [PATCH v2 7/8] net/bnxt: check invalid l2_filter_id Ajit Khaparde
2017-07-21 3:22 ` [dpdk-dev] [PATCH v2 8/8] net/bnxt: fix to free a filter before reusing it Ajit Khaparde
2017-07-21 9:31 ` [dpdk-dev] [PATCH v2 0/8] bnxt patchset Ferruh Yigit
2017-08-24 16:29 [dpdk-dev] [PATCH " Ajit Khaparde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12e05afb-d540-be7a-6d26-2229fd74a969@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).