From: Shreyansh Jain <shreyansh.jain@nxp.com>
To: John McNamara <john.mcnamara@intel.com>
Cc: <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] doc: update release notes for 17.05
Date: Wed, 10 May 2017 10:33:19 +0530 [thread overview]
Message-ID: <13057507-77df-4d72-8505-767946a5afd5@nxp.com> (raw)
In-Reply-To: <afe8254d-9ca1-b2e8-c0b0-300503cf3d5e@nxp.com>
On Wednesday 10 May 2017 10:29 AM, Shreyansh Jain wrote:
> Hello John,
>
> Some super trivial comments inline:
>
> On Tuesday 09 May 2017 10:26 PM, John McNamara wrote:
>> Fix grammar, spelling and formatting of DPDK 17.05 release notes.
>>
>> Signed-off-by: John McNamara <john.mcnamara@intel.com>
>> ---
>>
>> V2: Added updated MLX4/5 text. This patch supercedes patch 24166.
>>
>> doc/guides/rel_notes/release_17_05.rst | 197
>> +++++++++++++++------------------
>> 1 file changed, 91 insertions(+), 106 deletions(-)
>>
>> diff --git a/doc/guides/rel_notes/release_17_05.rst
>> b/doc/guides/rel_notes/release_17_05.rst
>> index 4b47ae1..f911711 100644
>> --- a/doc/guides/rel_notes/release_17_05.rst
>> +++ b/doc/guides/rel_notes/release_17_05.rst
>> @@ -41,16 +41,18 @@ New Features
>> Also, make sure to start the actual text at the margin.
>> =========================================================
>>
>> -* **Reorganized the mbuf structure.**
>> +* **Reorganized mbuf structure.**
>> +
>> + The mbuf structure has been reorganized as follows:
>>
>> * Align fields to facilitate the writing of ``data_off``,
>> ``refcnt``, and
>> ``nb_segs`` in one operation.
>> * Use 2 bytes for port and number of segments.
>> - * Move the sequence number in the second cache line.
>> + * Move the sequence number to the second cache line.
>> * Add a timestamp field.
>> * Set default value for ``refcnt``, ``next`` and ``nb_segs`` at
>> mbuf free.
>>
>> -* **Added mbuf raw free API**
>> +* **Added mbuf raw free API.**
>>
>> Moved ``rte_mbuf_raw_free()`` and ``rte_pktmbuf_prefree_seg()``
>> functions to
>> the public API.
>> @@ -58,14 +60,14 @@ New Features
>> * **Added free Tx mbuf on demand API.**
>>
>> Added a new function ``rte_eth_tx_done_cleanup()`` which allows an
>> application
>> - to request the driver to release mbufs from their Tx ring that are
>> no longer
>> - in use, independent of whether or not the ``tx_rs_thresh`` has been
>> crossed.
>> + to request the driver to release mbufs from that are no longer in
>> use from a
>
> isn't the 'that' in '..mbufs from that are no...' above extra?
>
Actually, the 'from' is extra in the line above, not 'that'.
next prev parent reply other threads:[~2017-05-10 4:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-09 16:25 [dpdk-dev] [PATCH v1] " John McNamara
2017-05-09 16:56 ` [dpdk-dev] [PATCH v2] " John McNamara
2017-05-10 4:59 ` Shreyansh Jain
2017-05-10 5:03 ` Shreyansh Jain [this message]
2017-05-10 18:56 ` Mcnamara, John
2017-05-10 19:01 ` [dpdk-dev] [PATCH v3] " John McNamara
2017-05-10 20:52 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13057507-77df-4d72-8505-767946a5afd5@nxp.com \
--to=shreyansh.jain@nxp.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).