From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 0/3] logging enhancements
Date: Wed, 04 Apr 2018 13:37:37 +0200 [thread overview]
Message-ID: <13489506.7h5fhggtRA@xps> (raw)
In-Reply-To: <20180223211752.28651-1-stephen@networkplumber.org>
23/02/2018 22:17, Stephen Hemminger:
> The current dynamic logging has some awkward user interface choices.
> It uses integers for log levels which requires user to know the
> mapping between numeric and symbolic values.
>
> A bigger problem was the choice of regular expressions and option
> format for dynamic logging. Dynamic log names are seperated with
> a period and the wildcard character for regular expressions is
> a period. It is just a happy accident the expressions like:
> "pmd.net.virtio.*"
> work as expected. This patch set adds a more usable solution
> with filename style matching.
>
> Also, the choice of comma as seperator for log-level option was
> not consistent with other options. For other options, comma is
> used to seperate list of equal values as in:
> -l 1,2,3
> Since new match required a backwards compatiable option the
> colon is now used to seperate name and value.
>
> So:
> --log-level='pmd.net.virtio.*,7'
> still works as expected. But the prefered syntax is:
> --log-level='pmd.net.virtio.*:info'
+1
This syntax looks better.
> If this is accepted, I think we should mark the old regex style
> matching as deprecated and remove it in 18.11??
Good question. Do we want to deprecate the regex style?
> Also, the dynamic log level pattern stuff is not adaquately
> documented right now. There are only a couple of vague references
> in the current documentation (which this updates).
I think you should document the symbolic log levels in the guide
and in the --help.
next prev parent reply other threads:[~2018-04-04 11:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 20:56 [dpdk-dev] [PATCH 0/3] logging enhancments Stephen Hemminger
2018-02-23 20:56 ` [dpdk-dev] [PATCH 1/3] eal: allow symbolic log levels Stephen Hemminger
2018-02-23 20:56 ` [dpdk-dev] [PATCH 2/3] log: add ability to match dynamic log based on shell pattern Stephen Hemminger
2018-02-23 20:56 ` [dpdk-dev] [PATCH 3/3] doc: update log level matching in documentation Stephen Hemminger
2018-02-23 21:17 ` [dpdk-dev] [PATCH v2 0/3] logging enhancements Stephen Hemminger
2018-02-23 21:17 ` [dpdk-dev] [PATCH v2 1/3] eal: allow symbolic log levels Stephen Hemminger
2018-02-23 21:17 ` [dpdk-dev] [PATCH v2 2/3] log: add ability to match dynamic log based on shell pattern Stephen Hemminger
2018-04-04 11:34 ` Thomas Monjalon
2018-04-23 21:08 ` Thomas Monjalon
2018-04-23 23:59 ` Stephen Hemminger
2018-02-23 21:17 ` [dpdk-dev] [PATCH v2 3/3] doc: update log level matching in documentation Stephen Hemminger
2018-04-04 11:32 ` Thomas Monjalon
2018-04-04 11:37 ` Thomas Monjalon [this message]
2018-04-23 8:15 ` [dpdk-dev] [PATCH v2 0/3] logging enhancements Olivier Matz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13489506.7h5fhggtRA@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).