From: Thomas Monjalon <thomas@monjalon.net>
To: Shreyansh Jain <shreyansh.jain@nxp.com>,
Jianfeng Tan <jianfeng.tan@intel.com>
Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>,
Olivier Matz <olivier.matz@6wind.com>,
Anatoly Burakov <anatoly.burakov@intel.com>
Subject: Re: [dpdk-dev] [PATCH] eal: fix threads block on barrier
Date: Fri, 27 Apr 2018 21:52:26 +0200 [thread overview]
Message-ID: <13763738.ezdo4hZiut@xps> (raw)
In-Reply-To: <HE1PR0402MB27804445AAA3B7116898D4C9908D0@HE1PR0402MB2780.eurprd04.prod.outlook.com>
27/04/2018 19:45, Shreyansh Jain:
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> > Shreyansh Jain <shreyansh.jain@nxp.com> wrote:
> > > From: Jianfeng Tan
> > > > Below commit introduced pthread barrier for synchronization.
> > > > But two IPC threads block on the barrier, and never wake up.
> > > >
> > > > (gdb) bt
> > > > #0 futex_wait (private=0, expected=0, futex_word=0x7fffffffcff4)
> > > > at ../sysdeps/unix/sysv/linux/futex-internal.h:61
> > > > #1 futex_wait_simple (private=0, expected=0,
> > > > futex_word=0x7fffffffcff4)
> > > > at ../sysdeps/nptl/futex-internal.h:135
> > > > #2 __pthread_barrier_wait (barrier=0x7fffffffcff0) at
> > > > pthread_barrier_wait.c:184
> > > > #3 rte_thread_init (arg=0x7fffffffcfe0)
> > > > at ../dpdk/lib/librte_eal/common/eal_common_thread.c:160
> > > > #4 start_thread (arg=0x7ffff6ecf700) at pthread_create.c:333
> > > > #5 clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109
> > > >
> > > > Through analysis, we find the barrier defined on the stack
> > > > could be the root cause. This patch will change to use heap
> > > > memory as the barrier.
> > > >
> > > > Fixes: d651ee4919cd ("eal: set affinity for control threads")
> > > >
> > > > Cc: Olivier Matz <olivier.matz@6wind.com>
> > > > Cc: Anatoly Burakov <anatoly.burakov@intel.com>
> > > >
> > > > Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
> > >
> > > Though I have seen Stephen's comment on this (possibly a library
> > bug), this at least fixes an issue which was dogging dpaa and dpaa2 -
> > generating bus errors and futex errors with variation in core masks
> > provided to applications.
> > >
> > > Thanks a lot for this.
> > >
> > > Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>
Applied, thanks Jianfeng.
> > Could you verify there is not a use after free by using valgrind or
> > some library that poisons memory on free.
>
> I will probably do that soon - but for the time being I don't want
> this issue to block the dpaa/dpaa2 for RC1 - these drivers were
> completely unusable without this patch.
Please Shreyansh, continue the analysis of this bug.
Thanks
next prev parent reply other threads:[~2018-04-27 19:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 16:41 Jianfeng Tan
2018-04-27 16:42 ` Thomas Monjalon
2018-04-27 17:03 ` Stephen Hemminger
2018-04-27 17:36 ` Shreyansh Jain
2018-04-27 17:39 ` Stephen Hemminger
2018-04-27 17:45 ` Shreyansh Jain
2018-04-27 19:52 ` Thomas Monjalon [this message]
2018-04-28 1:21 ` Stephen Hemminger
2018-04-28 4:15 ` Tan, Jianfeng
2018-04-28 1:24 ` Stephen Hemminger
2018-04-28 4:22 ` Tan, Jianfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13763738.ezdo4hZiut@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=olivier.matz@6wind.com \
--cc=shreyansh.jain@nxp.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).