DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@6wind.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v3 00/20] cleanup logs in main PMDs
Date: Wed, 17 Sep 2014 15:46:32 +0200	[thread overview]
Message-ID: <1410961612-8571-1-git-send-email-david.marchand@6wind.com> (raw)

Here is a patchset that reworks the log macro in e1000, ixgbe and i40e PMDs.
The idea behind this is to make it easier to debug some init failures and to be
sure of the datapath selected in these PMDs (rx / tx handlers selection).

The PMDs changes involve adding more debug messages in the default build.
A new eal option has been added to set the default log level, so that you can
render the eal a little less noisy.

I did not change the default log level for now, as some eal log messages are
marked as DEBUG while being interesting (from my point of view).
I suppose we can change the default log level later once the eal has been
cleaned up.

Changes since v2:
- just a respin with Jay comments in mind
* don't introduce \n in one commit then remove them
* indent only the impacted parts before removing \n (so split previous patches)
* remove some "" garbage

Changes since v1:
- continue clean up by always using PMD_*_LOG when logging something in
  PMD (i.e. no more printf, RTE_LOG, DEBUGOUT)
- introduce PMD_DRV_LOG_RAW macro for use by shared driver code
- adopt 'second approach': no more \n in PMD_*_LOG callers. This means that we
  will enforce a 'no \n' policy in logs for PMD.

--
David Marchand

David Marchand (20):
  ixgbe: use the right debug macro
  ixgbe/base: add a raw macro for use by shared code
  ixgbe: indent logs sections
  ixgbe: clean log messages
  ixgbe: always log init messages
  ixgbe: add a message when forcing scatter mode
  ixgbe: add log messages when rx bulk mode is not usable
  i40e: use the right debug macro
  i40e/base: add a raw macro for use by shared code
  i40e: indent logs sections
  i40e: clean log messages
  i40e: always log init messages
  i40e: add log messages when rx bulk mode is not usable
  e1000: use the right debug macro
  e1000/base: add a raw macro for use by shared code
  e1000: indent logs sections
  e1000: clean log messages
  e1000: always log init messages
  e1000: add a message when forcing scatter mode
  eal: set log level from command line

 lib/librte_eal/bsdapp/eal/eal.c                    |   42 ++
 .../bsdapp/eal/include/eal_internal_cfg.h          |    1 +
 lib/librte_eal/linuxapp/eal/eal.c                  |   44 +-
 .../linuxapp/eal/include/eal_internal_cfg.h        |    1 +
 lib/librte_pmd_e1000/e1000/e1000_osdep.h           |    4 +-
 lib/librte_pmd_e1000/e1000_logs.h                  |   18 +-
 lib/librte_pmd_e1000/em_ethdev.c                   |   53 ++-
 lib/librte_pmd_e1000/em_rxtx.c                     |  122 +++---
 lib/librte_pmd_e1000/igb_ethdev.c                  |   85 ++--
 lib/librte_pmd_e1000/igb_pf.c                      |    5 +-
 lib/librte_pmd_e1000/igb_rxtx.c                    |   65 +--
 lib/librte_pmd_i40e/i40e/i40e_osdep.h              |    8 +-
 lib/librte_pmd_i40e/i40e_ethdev.c                  |  451 ++++++++++----------
 lib/librte_pmd_i40e/i40e_ethdev_vf.c               |  166 ++++---
 lib/librte_pmd_i40e/i40e_logs.h                    |   16 +-
 lib/librte_pmd_i40e/i40e_pf.c                      |   79 ++--
 lib/librte_pmd_i40e/i40e_rxtx.c                    |  201 +++++----
 lib/librte_pmd_ixgbe/ixgbe/ixgbe_osdep.h           |    4 +-
 lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c          |   14 +-
 lib/librte_pmd_ixgbe/ixgbe_bypass.c                |   26 +-
 lib/librte_pmd_ixgbe/ixgbe_ethdev.c                |  150 ++++---
 lib/librte_pmd_ixgbe/ixgbe_fdir.c                  |    6 +-
 lib/librte_pmd_ixgbe/ixgbe_logs.h                  |   16 +-
 lib/librte_pmd_ixgbe/ixgbe_pf.c                    |    4 +-
 lib/librte_pmd_ixgbe/ixgbe_rxtx.c                  |  172 +++++---
 25 files changed, 954 insertions(+), 799 deletions(-)

-- 
1.7.10.4

             reply	other threads:[~2014-09-17 13:41 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-17 13:46 David Marchand [this message]
2014-09-17 13:46 ` [dpdk-dev] [PATCH v3 01/20] ixgbe: use the right debug macro David Marchand
2014-09-17 13:46 ` [dpdk-dev] [PATCH v3 02/20] ixgbe/base: add a raw macro for use by shared code David Marchand
2014-09-17 13:46 ` [dpdk-dev] [PATCH v3 03/20] ixgbe: indent logs sections David Marchand
2014-09-17 13:46 ` [dpdk-dev] [PATCH v3 04/20] ixgbe: clean log messages David Marchand
2014-09-17 13:46 ` [dpdk-dev] [PATCH v3 05/20] ixgbe: always log init messages David Marchand
2014-09-17 13:46 ` [dpdk-dev] [PATCH v3 06/20] ixgbe: add a message when forcing scatter mode David Marchand
2014-09-17 13:46 ` [dpdk-dev] [PATCH v3 07/20] ixgbe: add log messages when rx bulk mode is not usable David Marchand
2014-09-17 13:46 ` [dpdk-dev] [PATCH v3 08/20] i40e: use the right debug macro David Marchand
2014-09-17 13:46 ` [dpdk-dev] [PATCH v3 09/20] i40e/base: add a raw macro for use by shared code David Marchand
2014-09-17 13:46 ` [dpdk-dev] [PATCH v3 10/20] i40e: indent logs sections David Marchand
2014-09-17 13:46 ` [dpdk-dev] [PATCH v3 11/20] i40e: clean log messages David Marchand
2014-09-17 13:46 ` [dpdk-dev] [PATCH v3 12/20] i40e: always log init messages David Marchand
2014-09-17 13:46 ` [dpdk-dev] [PATCH v3 13/20] i40e: add log messages when rx bulk mode is not usable David Marchand
2014-09-17 13:46 ` [dpdk-dev] [PATCH v3 14/20] e1000: use the right debug macro David Marchand
2014-09-17 13:46 ` [dpdk-dev] [PATCH v3 15/20] e1000/base: add a raw macro for use by shared code David Marchand
2014-09-17 13:46 ` [dpdk-dev] [PATCH v3 16/20] e1000: indent logs sections David Marchand
2014-09-17 13:46 ` [dpdk-dev] [PATCH v3 17/20] e1000: clean log messages David Marchand
2014-09-17 13:46 ` [dpdk-dev] [PATCH v3 18/20] e1000: always log init messages David Marchand
2014-09-17 13:46 ` [dpdk-dev] [PATCH v3 19/20] e1000: add a message when forcing scatter mode David Marchand
2014-09-17 13:46 ` [dpdk-dev] [PATCH v3 20/20] eal: set log level from command line David Marchand
2014-09-17 14:45   ` Neil Horman
2014-09-18  7:46     ` David Marchand
2014-09-18 10:27       ` Neil Horman
2014-09-19  7:52 ` [dpdk-dev] [PATCH v3 00/20] cleanup logs in main PMDs Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1410961612-8571-1-git-send-email-david.marchand@6wind.com \
    --to=david.marchand@6wind.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).