From: Jean-Mickael Guerin <jean-mickael.guerin@6wind.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 1/2] ixgbe: fix setup of mbuf initializer template
Date: Thu, 4 Dec 2014 15:26:20 +0100 [thread overview]
Message-ID: <1417703181-23093-2-git-send-email-jean-mickael.guerin@6wind.com> (raw)
In-Reply-To: <1417703181-23093-1-git-send-email-jean-mickael.guerin@6wind.com>
Add a compiler barrier to make sure all fields covered by
the marker rearm_data are assigned before the read.
Signed-off-by: Jean-Mickael Guerin <jean-mickael.guerin@6wind.com>
Acked-by: David Marchand <david.marchand@6wind.com>
Fixes: 0ff3324da2 ("ixgbe: rework vector pmd following mbuf changes")
---
lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c
index 579bc46..c1b5a78 100644
--- a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c
+++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c
@@ -739,6 +739,9 @@ ixgbe_rxq_vec_setup(struct igb_rx_queue *rxq)
mb_def.buf_len = rxq->mb_pool->elt_size - sizeof(struct rte_mbuf);
mb_def.port = rxq->port_id;
rte_mbuf_refcnt_set(&mb_def, 1);
+
+ /* prevent compiler reordering: rearm_data covers previous fields */
+ rte_compiler_barrier();
rxq->mbuf_initializer = *((uint64_t *)&mb_def.rearm_data);
return 0;
}
--
2.1.3
next prev parent reply other threads:[~2014-12-04 14:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 14:26 [dpdk-dev] [PATCH 0/2] ixgbe: bug fixes for RX vector mode Jean-Mickael Guerin
2014-12-04 14:26 ` Jean-Mickael Guerin [this message]
2014-12-04 14:39 ` [dpdk-dev] [PATCH 1/2] ixgbe: fix setup of mbuf initializer template Bruce Richardson
2014-12-04 14:42 ` Ananyev, Konstantin
2014-12-04 15:15 ` Jean-Mickael Guerin
2014-12-04 16:22 ` Ananyev, Konstantin
2014-12-05 22:07 ` Thomas Monjalon
2014-12-04 14:26 ` [dpdk-dev] [PATCH 2/2] ixgbe: don't override mbuf buffer length Jean-Mickael Guerin
2014-12-04 14:40 ` Bruce Richardson
2014-12-04 14:50 ` Ananyev, Konstantin
2014-12-04 15:15 ` Bruce Richardson
2014-12-04 15:29 ` Ananyev, Konstantin
2014-12-04 15:32 ` Bruce Richardson
2014-12-04 16:03 ` Jean-Mickael Guerin
2014-12-04 16:20 ` Ananyev, Konstantin
2014-12-04 15:48 ` Thomas Monjalon
2014-12-04 16:05 ` Ananyev, Konstantin
2014-12-04 16:18 ` Ananyev, Konstantin
2014-12-04 16:57 ` Ananyev, Konstantin
2014-12-04 16:58 ` Bruce Richardson
2014-12-04 17:11 ` Jean-Mickael Guerin
2014-12-04 17:19 ` Bruce Richardson
2014-12-04 17:17 ` Ananyev, Konstantin
2014-12-04 17:22 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417703181-23093-2-git-send-email-jean-mickael.guerin@6wind.com \
--to=jean-mickael.guerin@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).