From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 2/2] mempool: fix pages computation to determine number of objects
Date: Mon, 25 May 2015 18:27:46 +0200 [thread overview]
Message-ID: <1432571266-25840-2-git-send-email-adrien.mazarguil@6wind.com> (raw)
In-Reply-To: <1432571266-25840-1-git-send-email-adrien.mazarguil@6wind.com>
In rte_mempool_obj_iter(), even when a single page is required per object,
a loop checks that the the next page is contiguous and drops the first one
otherwise. This commit checks subsequent pages only when several are
required per object.
Also a minor fix for the amount of remaining space that prevents using the
entire region.
Fixes: 148f963fb532 ("xen: core library changes")
Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
---
lib/librte_mempool/rte_mempool.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c
index d1a02a2..3c1efec 100644
--- a/lib/librte_mempool/rte_mempool.c
+++ b/lib/librte_mempool/rte_mempool.c
@@ -175,12 +175,17 @@ rte_mempool_obj_iter(void *vaddr, uint32_t elt_num, size_t elt_sz, size_t align,
pgn += j;
/* do we have enough space left for the next element. */
- if (pgn >= pg_num)
+ if (pgn > pg_num)
break;
- for (k = j;
+ /*
+ * Compute k so that (k - j) is the number of contiguous
+ * pages starting from index j. Note that there is at least
+ * one page.
+ */
+ for (k = j + 1;
k != pgn &&
- paddr[k] + pg_sz == paddr[k + 1];
+ paddr[k - 1] + pg_sz == paddr[k];
k++)
;
--
2.1.0
next prev parent reply other threads:[~2015-05-25 16:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-25 16:27 [dpdk-dev] [PATCH 1/2] mempool: fix returned value on 64 bit after counting objects Adrien Mazarguil
2015-05-25 16:27 ` Adrien Mazarguil [this message]
2015-05-25 18:20 ` [dpdk-dev] [PATCH 2/2] mempool: fix pages computation to determine number of objects Ananyev, Konstantin
2015-05-26 9:14 ` Adrien Mazarguil
2015-05-27 0:41 ` [dpdk-dev] [PATCHv2] " Konstantin Ananyev
2015-05-27 7:52 ` Adrien Mazarguil
2015-05-27 8:40 ` [dpdk-dev] [PATCHv3] " Konstantin Ananyev
2015-05-29 15:58 ` Thomas Monjalon
2015-05-27 0:43 ` [dpdk-dev] [PATCH 1/2] mempool: fix returned value on 64 bit after counting objects Ananyev, Konstantin
2015-05-29 15:57 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432571266-25840-2-git-send-email-adrien.mazarguil@6wind.com \
--to=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).