From: Cyril Chemparathy <cchemparathy@ezchip.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 04/11] eal: allow empty compile time flags
Date: Fri, 19 Jun 2015 12:15:02 -0700 [thread overview]
Message-ID: <1434741309-22415-5-git-send-email-cchemparathy@ezchip.com> (raw)
In-Reply-To: <1434741309-22415-1-git-send-email-cchemparathy@ezchip.com>
The rte_cpu_check_supported() code breaks with a "comparison is always
false due to limited range of data type" when the compile_time_flags[]
array is empty. Assigning the array dimension to a local variable
apparently solves this.
Change-Id: I0ae21f529cf7b6dd9cf0f4532dce9198f4bf4230
Signed-off-by: Cyril Chemparathy <cchemparathy@ezchip.com>
---
lib/librte_eal/common/eal_common_cpuflags.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_cpuflags.c b/lib/librte_eal/common/eal_common_cpuflags.c
index 6fd360c..8ba7b30 100644
--- a/lib/librte_eal/common/eal_common_cpuflags.c
+++ b/lib/librte_eal/common/eal_common_cpuflags.c
@@ -30,6 +30,7 @@
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
+#include <rte_common.h>
#include <rte_cpuflags.h>
/*
@@ -62,10 +63,10 @@ rte_cpu_check_supported(void)
static const enum rte_cpu_flag_t compile_time_flags[] = {
RTE_COMPILE_TIME_CPUFLAGS
};
- unsigned i;
+ unsigned count = RTE_DIM(compile_time_flags), i;
int ret;
- for (i = 0; i < sizeof(compile_time_flags)/sizeof(compile_time_flags[0]); i++) {
+ for (i = 0; i < count; i++) {
ret = rte_cpu_get_flag_enabled(compile_time_flags[i]);
if (ret < 0) {
--
2.1.2
next prev parent reply other threads:[~2015-06-19 19:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 19:14 [dpdk-dev] [PATCH 00/11] Introducing the TILE-Gx platform Cyril Chemparathy
2015-06-19 19:14 ` [dpdk-dev] [PATCH 01/11] test: limit x86 cpuflags checks to x86 builds Cyril Chemparathy
2015-06-19 19:15 ` [dpdk-dev] [PATCH 02/11] hash: fix compilation on non-X86 platforms Cyril Chemparathy
2015-06-19 19:15 ` [dpdk-dev] [PATCH 03/11] hash: check SSE flags only on x86 builds Cyril Chemparathy
2015-06-19 19:15 ` Cyril Chemparathy [this message]
2015-06-19 19:15 ` [dpdk-dev] [PATCH 05/11] memzone: refactor rte_memzone_reserve() variants Cyril Chemparathy
2015-06-19 19:15 ` [dpdk-dev] [PATCH 06/11] memzone: allow multiple pagesizes to be requested Cyril Chemparathy
2015-06-19 19:15 ` [dpdk-dev] [PATCH 07/11] mempool: allow config override on element alignment Cyril Chemparathy
2015-06-19 19:15 ` [dpdk-dev] [PATCH 08/11] tile: add page sizes for TILE-Gx/Mx platforms Cyril Chemparathy
2015-06-19 19:15 ` [dpdk-dev] [PATCH 09/11] tile: initial TILE-Gx support Cyril Chemparathy
2015-06-22 9:39 ` Thomas Monjalon
2015-06-22 16:54 ` Cyril Chemparathy
2015-06-22 17:00 ` Thomas Monjalon
2015-06-22 17:03 ` Cyril Chemparathy
2015-06-22 17:06 ` Thomas Monjalon
2015-06-19 19:15 ` [dpdk-dev] [PATCH 10/11] tile: Add TILE-Gx mPIPE poll mode driver Cyril Chemparathy
2015-06-19 19:15 ` [dpdk-dev] [PATCH 11/11] maintainers: claim responsibility for TILE-Gx platform Cyril Chemparathy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434741309-22415-5-git-send-email-cchemparathy@ezchip.com \
--to=cchemparathy@ezchip.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).