From: Cyril Chemparathy <cchemparathy@ezchip.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 07/11] mempool: allow config override on element alignment
Date: Fri, 19 Jun 2015 12:15:05 -0700 [thread overview]
Message-ID: <1434741309-22415-8-git-send-email-cchemparathy@ezchip.com> (raw)
In-Reply-To: <1434741309-22415-1-git-send-email-cchemparathy@ezchip.com>
On TILE-Gx and TILE-Mx platforms, the buffers fed into the hardware
buffer manager require a 128-byte alignment. With this change, we
allow configuration based override of the element alignment, and
default to RTE_CACHE_LINE_SIZE if left unspecified.
Change-Id: I9cd789d92b0bc9c8f44a633de59bb04d45d927a7
Signed-off-by: Cyril Chemparathy <cchemparathy@ezchip.com>
---
lib/librte_mempool/rte_mempool.c | 16 +++++++++-------
lib/librte_mempool/rte_mempool.h | 6 ++++++
2 files changed, 15 insertions(+), 7 deletions(-)
diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c
index 190cfd9..37823dc 100644
--- a/lib/librte_mempool/rte_mempool.c
+++ b/lib/librte_mempool/rte_mempool.c
@@ -120,10 +120,10 @@ static unsigned optimize_object_size(unsigned obj_size)
nrank = 1;
/* process new object size */
- new_obj_size = (obj_size + RTE_CACHE_LINE_MASK) / RTE_CACHE_LINE_SIZE;
+ new_obj_size = (obj_size + RTE_MEMPOOL_ALIGN_MASK) / RTE_MEMPOOL_ALIGN;
while (get_gcd(new_obj_size, nrank * nchan) != 1)
new_obj_size++;
- return new_obj_size * RTE_CACHE_LINE_SIZE;
+ return new_obj_size * RTE_MEMPOOL_ALIGN;
}
static void
@@ -265,7 +265,7 @@ rte_mempool_calc_obj_size(uint32_t elt_size, uint32_t flags,
#endif
if ((flags & MEMPOOL_F_NO_CACHE_ALIGN) == 0)
sz->header_size = RTE_ALIGN_CEIL(sz->header_size,
- RTE_CACHE_LINE_SIZE);
+ RTE_MEMPOOL_ALIGN);
/* trailer contains the cookie in debug mode */
sz->trailer_size = 0;
@@ -279,9 +279,9 @@ rte_mempool_calc_obj_size(uint32_t elt_size, uint32_t flags,
if ((flags & MEMPOOL_F_NO_CACHE_ALIGN) == 0) {
sz->total_size = sz->header_size + sz->elt_size +
sz->trailer_size;
- sz->trailer_size += ((RTE_CACHE_LINE_SIZE -
- (sz->total_size & RTE_CACHE_LINE_MASK)) &
- RTE_CACHE_LINE_MASK);
+ sz->trailer_size += ((RTE_MEMPOOL_ALIGN -
+ (sz->total_size & RTE_MEMPOOL_ALIGN_MASK)) &
+ RTE_MEMPOOL_ALIGN_MASK);
}
/*
@@ -496,7 +496,7 @@ rte_mempool_xmem_create(const char *name, unsigned n, unsigned elt_size,
* cache-aligned
*/
private_data_size = (private_data_size +
- RTE_CACHE_LINE_MASK) & (~RTE_CACHE_LINE_MASK);
+ RTE_MEMPOOL_ALIGN_MASK) & (~RTE_MEMPOOL_ALIGN_MASK);
if (! rte_eal_has_hugepages()) {
/*
@@ -523,6 +523,7 @@ rte_mempool_xmem_create(const char *name, unsigned n, unsigned elt_size,
* hold mempool header and metadata plus mempool objects.
*/
mempool_size = MEMPOOL_HEADER_SIZE(mp, pg_num) + private_data_size;
+ mempool_size = RTE_ALIGN_CEIL(mempool_size, RTE_MEMPOOL_ALIGN);
if (vaddr == NULL)
mempool_size += (size_t)objsz.total_size * n;
@@ -578,6 +579,7 @@ rte_mempool_xmem_create(const char *name, unsigned n, unsigned elt_size,
/* calculate address of the first element for continuous mempool. */
obj = (char *)mp + MEMPOOL_HEADER_SIZE(mp, pg_num) +
private_data_size;
+ obj = RTE_PTR_ALIGN_CEIL(obj, RTE_MEMPOOL_ALIGN);
/* populate address translation fields. */
mp->pg_num = pg_num;
diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h
index 8be040b..175a793 100644
--- a/lib/librte_mempool/rte_mempool.h
+++ b/lib/librte_mempool/rte_mempool.h
@@ -139,6 +139,12 @@ struct rte_mempool_objsz {
/** Mempool over one chunk of physically continuous memory */
#define MEMPOOL_PG_NUM_DEFAULT 1
+#ifndef RTE_MEMPOOL_ALIGN
+#define RTE_MEMPOOL_ALIGN RTE_CACHE_LINE_SIZE
+#endif
+
+#define RTE_MEMPOOL_ALIGN_MASK (RTE_MEMPOOL_ALIGN - 1)
+
/**
* The RTE mempool structure.
*/
--
2.1.2
next prev parent reply other threads:[~2015-06-19 19:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 19:14 [dpdk-dev] [PATCH 00/11] Introducing the TILE-Gx platform Cyril Chemparathy
2015-06-19 19:14 ` [dpdk-dev] [PATCH 01/11] test: limit x86 cpuflags checks to x86 builds Cyril Chemparathy
2015-06-19 19:15 ` [dpdk-dev] [PATCH 02/11] hash: fix compilation on non-X86 platforms Cyril Chemparathy
2015-06-19 19:15 ` [dpdk-dev] [PATCH 03/11] hash: check SSE flags only on x86 builds Cyril Chemparathy
2015-06-19 19:15 ` [dpdk-dev] [PATCH 04/11] eal: allow empty compile time flags Cyril Chemparathy
2015-06-19 19:15 ` [dpdk-dev] [PATCH 05/11] memzone: refactor rte_memzone_reserve() variants Cyril Chemparathy
2015-06-19 19:15 ` [dpdk-dev] [PATCH 06/11] memzone: allow multiple pagesizes to be requested Cyril Chemparathy
2015-06-19 19:15 ` Cyril Chemparathy [this message]
2015-06-19 19:15 ` [dpdk-dev] [PATCH 08/11] tile: add page sizes for TILE-Gx/Mx platforms Cyril Chemparathy
2015-06-19 19:15 ` [dpdk-dev] [PATCH 09/11] tile: initial TILE-Gx support Cyril Chemparathy
2015-06-22 9:39 ` Thomas Monjalon
2015-06-22 16:54 ` Cyril Chemparathy
2015-06-22 17:00 ` Thomas Monjalon
2015-06-22 17:03 ` Cyril Chemparathy
2015-06-22 17:06 ` Thomas Monjalon
2015-06-19 19:15 ` [dpdk-dev] [PATCH 10/11] tile: Add TILE-Gx mPIPE poll mode driver Cyril Chemparathy
2015-06-19 19:15 ` [dpdk-dev] [PATCH 11/11] maintainers: claim responsibility for TILE-Gx platform Cyril Chemparathy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434741309-22415-8-git-send-email-cchemparathy@ezchip.com \
--to=cchemparathy@ezchip.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).