From: Wang Xiao W <xiao.w.wang@intel.com>
To: dev@dpdk.org
Cc: Wang Xiao W <xiao.w.wang@intel.com>
Subject: [dpdk-dev] [PATCH 07/16] fm10k: mbx_update_max_size does not drop all
Date: Mon, 27 Jul 2015 16:42:30 +0800 [thread overview]
Message-ID: <1437986559-31016-7-git-send-email-xiao.w.wang@intel.com> (raw)
In-Reply-To: <1437986559-31016-1-git-send-email-xiao.w.wang@intel.com>
When we call update_max_size, it does not drop all oversized messages.
This is due to the difficulty in performing this operation, since it is
a FIFO which makes updating anything other than head or tail very
difficult. To fix this, modify validate_msg_size to ensure that we error
out later when trying to transmit the message that could be oversized.
This will generally be a rare condition, as it requires the FIFO to
include a message larger than the max_size negotiated during mailbox
connect. Note that max_size is always smaller than rx.size, so it should
be safe to use here.
Also, update the update_max_size function header comment to clearly
indicate that it does not drop all oversized messages, but only those at
the head of the FIFO.
Signed-off-by: Wang Xiao W <xiao.w.wang@intel.com>
---
drivers/net/fm10k/base/fm10k_mbx.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/net/fm10k/base/fm10k_mbx.c b/drivers/net/fm10k/base/fm10k_mbx.c
index 12f10f8..0cdd24d 100644
--- a/drivers/net/fm10k/base/fm10k_mbx.c
+++ b/drivers/net/fm10k/base/fm10k_mbx.c
@@ -344,7 +344,7 @@ STATIC u16 fm10k_mbx_validate_msg_size(struct fm10k_mbx_info *mbx, u16 len)
} while (total_len < len);
/* message extends out of pushed section, but fits in FIFO */
- if ((len < total_len) && (msg_len <= mbx->rx.size))
+ if ((len < total_len) && (msg_len <= mbx->max_size))
return 0;
/* return length of invalid section */
@@ -1088,12 +1088,15 @@ STATIC void fm10k_mbx_reset_work(struct fm10k_mbx_info *mbx)
}
/**
- * fm10k_mbx_update_max_size - Update the max_size and drop any large messages
+ * fm10k_mbx_update_max_size - Update the max_size and drop large messages
* @mbx: pointer to mailbox
* @size: new value for max_size
*
- * This function will update the max_size value and drop any outgoing messages
- * from the head of the Tx FIFO that are larger than max_size.
+ * This function updates the max_size value and drops any outgoing messages
+ * at the head of the Tx FIFO if they are larger than max_size. It does not
+ * drop all messages, as this is too difficult to parse and remove them from
+ * the FIFO. Instead, rely on the checking to ensure that messages larger
+ * than max_size aren't pushed into the memory buffer.
**/
STATIC void fm10k_mbx_update_max_size(struct fm10k_mbx_info *mbx, u16 size)
{
--
1.9.3
next prev parent reply other threads:[~2015-07-27 8:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-27 8:42 [dpdk-dev] [PATCH 01/16] fm10k: add PF Tx Timestamp mode handler function Wang Xiao W
2015-07-27 8:42 ` [dpdk-dev] [PATCH 02/16] fm10k: add no-op pointer for VF request_tx_timestamp_mode Wang Xiao W
2015-07-27 8:42 ` [dpdk-dev] [PATCH 03/16] fm10k: Set PF queues to unlimited bandwidth Wang Xiao W
2015-07-27 8:42 ` [dpdk-dev] [PATCH 04/16] fm10k: fix fm10k_mbx_write_copy header comment Wang Xiao W
2015-07-27 8:42 ` [dpdk-dev] [PATCH 05/16] fm10k: Add support for ITR scaling based on PCIe link speed Wang Xiao W
2015-07-27 8:42 ` [dpdk-dev] [PATCH 06/16] fm10k: reset head instead of calling update_max_size Wang Xiao W
2015-07-27 8:42 ` Wang Xiao W [this message]
2015-07-27 8:42 ` [dpdk-dev] [PATCH 08/16] fm10k: ensure VF restores itr_scale on stop_hw Wang Xiao W
2015-07-27 8:42 ` [dpdk-dev] [PATCH 09/16] fm10k: ensure itr_scale is set even if we don't know speed Wang Xiao W
2015-07-27 8:42 ` [dpdk-dev] [PATCH 10/16] fm10k: correct VF multicast update Wang Xiao W
2015-07-27 8:42 ` [dpdk-dev] [PATCH 11/16] fm10k: Re-map all possible VF queues after a VFLR Wang Xiao W
2015-07-27 8:42 ` [dpdk-dev] [PATCH 12/16] fm10k: pack TLV overlay structures correctly Wang Xiao W
2015-07-27 8:42 ` [dpdk-dev] [PATCH 13/16] fm10k: 1558 DIR_NEGATIVE bit is actually DIR_POSITIVE Wang Xiao W
2015-07-27 8:42 ` [dpdk-dev] [PATCH 14/16] fm10k: remove err_no reference Wang Xiao W
2015-07-27 8:42 ` [dpdk-dev] [PATCH 15/16] fm10k: fix iov_msg_lport_state_pf re-enable bug Wang Xiao W
2015-07-27 8:42 ` [dpdk-dev] [PATCH 16/16] fm10k: add macro definitions about valid ether addr Wang Xiao W
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437986559-31016-7-git-send-email-xiao.w.wang@intel.com \
--to=xiao.w.wang@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).