DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] eal: fix build with glibc < 2.12
Date: Thu, 26 Oct 2017 23:09:51 +0200	[thread overview]
Message-ID: <14385227.iJrz8hiYyE@xps> (raw)
In-Reply-To: <7f85550c-f992-16eb-2e41-9aae1e6813b2@intel.com>

26/10/2017 16:05, Gonzalez Monroy, Sergio:
> On 25/10/2017 09:36, Ferruh Yigit wrote:
> > build error:
> >    CC rte_cycles.o
> >    cc1: warnings being treated as errors
> >    ...dpdk/lib/librte_eal/common/arch/x86/rte_cycles.c: In function
> >    ‘rdmsr’:
> >    ...dpdk/lib/librte_eal/common/arch/x86/rte_cycles.c:67:2: error:
> >    implicit declaration of function ‘pread’
> >    ...dpdk/lib/librte_eal/common/arch/x86/rte_cycles.c:67:2: error:
> >    nested extern declaration of ‘pread’
> >
> > from pread man page:
> > pread(), pwrite():
> >     _XOPEN_SOURCE >= 500
> >     || /* Since glibc 2.12: */ _POSIX_C_SOURCE >= 200809L
> >
> > For glibc < 2.12 _XOPEN_SOURCE >= 500 is required.
> >
> > Adding _GNU_SOURCE define to the file which implies _XOPEN_SOURCE=700
> >
> > Fixes: ad3516bb4ae1 ("eal/x86: implement arch-specific TSC freq query")
> > Cc: sergio.gonzalez.monroy@intel.com
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Acked-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>

Applied, thanks

      reply	other threads:[~2017-10-26 21:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-25  8:36 Ferruh Yigit
2017-10-26 14:05 ` Gonzalez Monroy, Sergio
2017-10-26 21:09   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14385227.iJrz8hiYyE@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=sergio.gonzalez.monroy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).