From: Bernard Iremonger <bernard.iremonger@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v4 02/20] librte_ether: add fields from rte_pci_driver to rte_eth_dev_data
Date: Wed, 21 Oct 2015 15:50:26 +0100 [thread overview]
Message-ID: <1445439044-2987-3-git-send-email-bernard.iremonger@intel.com> (raw)
In-Reply-To: <1445439044-2987-1-git-send-email-bernard.iremonger@intel.com>
add dev_flags to rte_eth_dev_data, add macros for dev_flags.
add kdrv to rte_eth_dev_data.
add numa_node to rte_eth_dev_data.
add drv_name to rte_eth_dev_data.
use dev_type to distinguish between vdev's and pdev's.
remove pci_dev branches.
update release notes.
Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
---
doc/guides/rel_notes/release_2_2.rst | 3 +++
lib/librte_ether/rte_ethdev.c | 40 +++++++++++++++---------------------
lib/librte_ether/rte_ethdev.h | 15 ++++++++++++++
3 files changed, 35 insertions(+), 23 deletions(-)
diff --git a/doc/guides/rel_notes/release_2_2.rst b/doc/guides/rel_notes/release_2_2.rst
index 4f75cff..455b5a2 100644
--- a/doc/guides/rel_notes/release_2_2.rst
+++ b/doc/guides/rel_notes/release_2_2.rst
@@ -9,6 +9,9 @@ New Features
* Added support for Jumbo Frames.
* Optimize forwarding performance for Chelsio T5 40GbE cards.
+* **Removed the PCI device from vdev PMD's.**
+
+ * This change required modifications to librte_ether and all vdev and pdev PMD's.
Resolved Issues
---------------
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index f593f6e..4187595 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -424,7 +424,7 @@ rte_eth_dev_socket_id(uint8_t port_id)
{
if (!rte_eth_dev_is_valid_port(port_id))
return -1;
- return rte_eth_devices[port_id].pci_dev->numa_node;
+ return rte_eth_devices[port_id].data->numa_node;
}
uint8_t
@@ -503,27 +503,25 @@ rte_eth_dev_get_name_by_port(uint8_t port_id, char *name)
static int
rte_eth_dev_is_detachable(uint8_t port_id)
{
- uint32_t drv_flags;
+ uint32_t dev_flags;
if (!rte_eth_dev_is_valid_port(port_id)) {
PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
return -EINVAL;
}
- if (rte_eth_devices[port_id].dev_type == RTE_ETH_DEV_PCI) {
- switch (rte_eth_devices[port_id].pci_dev->kdrv) {
- case RTE_KDRV_IGB_UIO:
- case RTE_KDRV_UIO_GENERIC:
- case RTE_KDRV_NIC_UIO:
- break;
- case RTE_KDRV_VFIO:
- default:
- return -ENOTSUP;
- }
+ switch (rte_eth_devices[port_id].data->kdrv) {
+ case RTE_KDRV_IGB_UIO:
+ case RTE_KDRV_UIO_GENERIC:
+ case RTE_KDRV_NIC_UIO:
+ case RTE_KDRV_NONE:
+ break;
+ case RTE_KDRV_VFIO:
+ default:
+ return -ENOTSUP;
}
-
- drv_flags = rte_eth_devices[port_id].driver->pci_drv.drv_flags;
- return !(drv_flags & RTE_PCI_DRV_DETACHABLE);
+ dev_flags = rte_eth_devices[port_id].data->dev_flags;
+ return !(dev_flags & RTE_ETH_DEV_DETACHABLE);
}
/* attach the new physical device, then store port_id of the device */
@@ -1143,14 +1141,11 @@ rte_eth_dev_configure(uint8_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,
* If link state interrupt is enabled, check that the
* device supports it.
*/
- if (dev_conf->intr_conf.lsc == 1) {
- const struct rte_pci_driver *pci_drv = &dev->driver->pci_drv;
-
- if (!(pci_drv->drv_flags & RTE_PCI_DRV_INTR_LSC)) {
+ if ((dev_conf->intr_conf.lsc == 1) &&
+ (!(dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC))) {
PMD_DEBUG_TRACE("driver %s does not support lsc\n",
- pci_drv->name);
+ dev->data->drv_name);
return -EINVAL;
- }
}
/*
@@ -1795,8 +1790,7 @@ rte_eth_dev_info_get(uint8_t port_id, struct rte_eth_dev_info *dev_info)
FUNC_PTR_OR_RET(*dev->dev_ops->dev_infos_get);
(*dev->dev_ops->dev_infos_get)(dev, dev_info);
dev_info->pci_dev = dev->pci_dev;
- if (dev->driver)
- dev_info->driver_name = dev->driver->pci_drv.name;
+ dev_info->driver_name = dev->data->drv_name;
}
void
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index 8a8c82b..79d3ecd 100644
--- a/lib/librte_ether/rte_ethdev.h
+++ b/lib/librte_ether/rte_ethdev.h
@@ -1471,8 +1471,23 @@ struct rte_eth_dev_data {
all_multicast : 1, /**< RX all multicast mode ON(1) / OFF(0). */
dev_started : 1, /**< Device state: STARTED(1) / STOPPED(0). */
lro : 1; /**< RX LRO is ON(1) / OFF(0) */
+ uint32_t dev_flags; /**< Flags controlling handling of device. */
+ enum rte_kernel_driver kdrv; /**< Kernel driver passthrough */
+ int numa_node; /**< NUMA node connection */
+ const char *drv_name; /**< Driver name */
};
+/** Device needs PCI BAR mapping (done with either IGB_UIO or VFIO) */
+#define RTE_ETH_DEV_DRV_NEED_MAPPING RTE_PCI_DRV_NEED_MAPPING
+/** Device needs to be unbound even if no module is provided */
+#define RTE_ETH_DEV_DRV_FORCE_UNBIND RTE_PCI_DRV_FORCE_UNBIND
+/** Device supports link state interrupt */
+#define RTE_ETH_DEV_INTR_LSC RTE_PCI_DRV_INTR_LSC
+/** Device supports detaching capability */
+#define RTE_ETH_DEV_DETACHABLE RTE_PCI_DRV_DETACHABLE
+/** Device is a bonded device */
+#define RTE_ETH_DEV_BONDED 0x0020
+
/**
* @internal
* The pool of *rte_eth_dev* structures. The size of the pool
--
1.9.1
next prev parent reply other threads:[~2015-10-21 14:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <PATCH v4>
2015-10-21 14:50 ` [dpdk-dev] [PATCH v4 00/20] remove pci driver from vdevs Bernard Iremonger
2015-10-21 14:50 ` [dpdk-dev] [PATCH v4 01/20] librte_eal: add RTE_KDRV_NONE for vdevs Bernard Iremonger
2015-10-21 14:50 ` Bernard Iremonger [this message]
2015-10-21 14:50 ` [dpdk-dev] [PATCH v4 03/20] librte_ether: add function rte_eth_copy_dev_info() Bernard Iremonger
2015-10-21 14:50 ` [dpdk-dev] [PATCH v4 04/20] null: remove pci device driver Bernard Iremonger
2015-10-21 14:50 ` [dpdk-dev] [PATCH v4 05/20] ring: " Bernard Iremonger
2015-10-21 14:50 ` [dpdk-dev] [PATCH v4 06/20] bonding: " Bernard Iremonger
2015-10-21 14:50 ` [dpdk-dev] [PATCH v4 07/20] pcap: " Bernard Iremonger
2015-10-21 14:50 ` [dpdk-dev] [PATCH v4 08/20] af_packet: " Bernard Iremonger
2015-10-21 14:50 ` [dpdk-dev] [PATCH v4 09/20] xenvirt: " Bernard Iremonger
2015-10-21 14:50 ` [dpdk-dev] [PATCH v4 10/20] mpipe: " Bernard Iremonger
2015-10-21 14:50 ` [dpdk-dev] [PATCH v4 11/20] ixgbe: copy pci device info to eth_dev data Bernard Iremonger
2015-10-21 14:50 ` [dpdk-dev] [PATCH v4 12/20] e1000: " Bernard Iremonger
2015-10-21 14:50 ` [dpdk-dev] [PATCH v4 13/20] i40e: " Bernard Iremonger
2015-10-21 14:50 ` [dpdk-dev] [PATCH v4 14/20] fm10k: " Bernard Iremonger
2015-10-21 14:50 ` [dpdk-dev] [PATCH v4 15/20] bnx2x: " Bernard Iremonger
2015-10-21 14:50 ` [dpdk-dev] [PATCH v4 16/20] cxgbe: " Bernard Iremonger
2015-10-21 14:50 ` [dpdk-dev] [PATCH v4 17/20] enic: " Bernard Iremonger
2015-10-21 14:50 ` [dpdk-dev] [PATCH v4 18/20] mlx4: " Bernard Iremonger
2015-10-21 14:50 ` [dpdk-dev] [PATCH v4 19/20] virtio: " Bernard Iremonger
2015-10-21 14:50 ` [dpdk-dev] [PATCH v4 20/20] vmxnet3: " Bernard Iremonger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445439044-2987-3-git-send-email-bernard.iremonger@intel.com \
--to=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).