From: Alex Williamson <alex.williamson@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Avi Kivity <avi@scylladb.com>
Subject: Re: [dpdk-dev] [PATCH] vfio: support iommu group zero
Date: Wed, 09 Dec 2015 16:22:14 -0700 [thread overview]
Message-ID: <1449703334.15753.476.camel@redhat.com> (raw)
In-Reply-To: <20151209151215.4d88b9d4@xeon-e3>
On Wed, 2015-12-09 at 15:12 -0800, Stephen Hemminger wrote:
> On Wed, 09 Dec 2015 23:49:59 +0100
> Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
>
> > 2015-12-09 13:58, Stephen Hemminger:
> > > On Wed, 09 Dec 2015 22:12:33 +0100
> > > Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> > >
> > > > 2015-12-09 09:55, Stephen Hemminger:
> > > > > The current implementation of VFIO will not with the new no-IOMMU mode
> > > > > in 4.4 kernel. The original code assumed that IOMMU group zero would
> > > > > never be used. Group numbers are assigned starting at zero, and up
> > > > > until now the group numbers came from the hardware which is likely
> > > > > to use group 0 for system devices that are not used with DPDK.
> > > > >
> > > > > The fix is to allow 0 as a valid group and rearrange code
> > > > > to split the return value from the group value.
> > > > >
> > > > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > > > > ---
> > > > > Why was this ignored? It was originally sent on 26 Oct 15 back
> > > > > when IOMMU discussion was lively.
> > > >
> > > > There was no review of this patch.
> > > > The patch has been marked as deferred recently when it was too late
> > > > to do such feature changes in DPDK code:
> > > > http://dpdk.org/dev/patchwork/patch/8035/
> > >
> > > This is why as a fallback the MAINTAINER has to review the patch
> > > or direct a sub-maintainer to do it. I think almost 2 months is
> > > plenty of time for review.
> >
> > 27 October was 3 days before the feature deadline.
> > And you have not pinged about it since then.
> > But that's true I have missed the importance of this patch.
> > Would it help to have it integrated today?
> > Are you sure it won't break something else?
>
> Could the original VFIO submitter from Intel review it.
vfio group 0 has always been valid, but it's unlikely that you'd ever
hit it in regular usage since it will typically be the root bus device.
It's only with no-iommu mode in vfio that it's common, but that's
getting reverted for Linux v4.4, so that may change your priorities
about squeezing this in at the last minute. Thanks,
Alex
next prev parent reply other threads:[~2015-12-09 23:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 17:55 Stephen Hemminger
2015-12-09 21:12 ` Thomas Monjalon
2015-12-09 21:51 ` Stephen Hemminger
2015-12-09 21:58 ` Stephen Hemminger
2015-12-09 22:49 ` Thomas Monjalon
2015-12-09 23:12 ` Stephen Hemminger
2015-12-09 23:22 ` Alex Williamson [this message]
2015-12-10 0:52 ` Stephen Hemminger
2015-12-10 1:52 ` Alex Williamson
2015-12-10 9:57 ` Burakov, Anatoly
2015-12-10 20:30 ` Thomas Monjalon
-- strict thread matches above, loose matches on Subject: below --
2015-10-27 2:34 Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449703334.15753.476.camel@redhat.com \
--to=alex.williamson@redhat.com \
--cc=avi@scylladb.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).