From: Jan Viktorin <viktorin@rehivetech.com>
To: dev@dpdk.org
Cc: Jan Viktorin <viktorin@rehivetech.com>
Subject: [dpdk-dev] [RFC 1/6] eal: introduce rte_bus_device and rte_bus_driver
Date: Mon, 18 Jan 2016 17:03:02 +0100 [thread overview]
Message-ID: <1453132987-20564-2-git-send-email-viktorin@rehivetech.com> (raw)
In-Reply-To: <1453132987-20564-1-git-send-email-viktorin@rehivetech.com>
Define a general represenation of a device and driver in DPDK. The goal is to
get rid of the deep dependency on the PCI. Higher level code should not
reference the bus-specific structures as it does not need to.
PCI infrastructure embeds those structures. Other infrastructures will do the
same.
Suggested-by: David Marchand <david.marchand@6wind.com>
Signed-off-by: Jan Viktorin <viktorin@rehivetech.com>
---
lib/librte_eal/common/include/rte_dev.h | 9 +++++++++
lib/librte_eal/common/include/rte_pci.h | 3 +++
2 files changed, 12 insertions(+)
diff --git a/lib/librte_eal/common/include/rte_dev.h b/lib/librte_eal/common/include/rte_dev.h
index f1b5507..b779705 100644
--- a/lib/librte_eal/common/include/rte_dev.h
+++ b/lib/librte_eal/common/include/rte_dev.h
@@ -50,6 +50,7 @@ extern "C" {
#include <sys/queue.h>
#include <rte_log.h>
+#include <rte_interrupts.h>
__attribute__((format(printf, 2, 0)))
static inline void
@@ -151,6 +152,14 @@ void rte_eal_driver_register(struct rte_driver *driver);
*/
void rte_eal_driver_unregister(struct rte_driver *driver);
+struct rte_bus_driver {
+ const char *name;
+};
+
+struct rte_bus_device {
+ const char *name;
+};
+
/**
* Initalize all the registered drivers in this process
*/
diff --git a/lib/librte_eal/common/include/rte_pci.h b/lib/librte_eal/common/include/rte_pci.h
index 334c12e..10a2306 100644
--- a/lib/librte_eal/common/include/rte_pci.h
+++ b/lib/librte_eal/common/include/rte_pci.h
@@ -83,6 +83,7 @@ extern "C" {
#include <inttypes.h>
#include <rte_interrupts.h>
+#include <rte_dev.h>
TAILQ_HEAD(pci_device_list, rte_pci_device); /**< PCI devices in D-linked Q. */
TAILQ_HEAD(pci_driver_list, rte_pci_driver); /**< PCI drivers in D-linked Q. */
@@ -166,6 +167,7 @@ struct rte_pci_device {
int numa_node; /**< NUMA node connection */
struct rte_devargs *devargs; /**< Device user arguments */
enum rte_kernel_driver kdrv; /**< Kernel driver passthrough */
+ struct rte_bus_device dev; /**< Generic device */
};
/** Any PCI device identifier (vendor, device, ...) */
@@ -209,6 +211,7 @@ struct rte_pci_driver {
pci_devuninit_t *devuninit; /**< Device uninit function. */
const struct rte_pci_id *id_table; /**< ID table, NULL terminated. */
uint32_t drv_flags; /**< Flags contolling handling of device. */
+ struct rte_bus_driver drv; /**< Generic driver */
};
/** Device needs PCI BAR mapping (done with either IGB_UIO or VFIO) */
--
2.7.0
next prev parent reply other threads:[~2016-01-18 16:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 16:03 [dpdk-dev] [RFC 0/6] Preview of a big eal/ethdev cleanup Jan Viktorin
2016-01-18 16:03 ` Jan Viktorin [this message]
2016-01-18 16:03 ` [dpdk-dev] [RFC 2/6] eal: define macro container_of Jan Viktorin
2016-01-18 16:03 ` [dpdk-dev] [RFC 3/6] eal: move devargs from rte_pci_device to rte_device Jan Viktorin
2016-01-18 16:03 ` [dpdk-dev] [RFC 4/6] eal: move numa_node " Jan Viktorin
2016-01-18 16:03 ` [dpdk-dev] [RFC 5/6] eal: move intr_handle " Jan Viktorin
2016-01-18 16:03 ` [dpdk-dev] [RFC 6/6] eal: move driver pointer from rte_pci_device to rte_bus_device Jan Viktorin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453132987-20564-2-git-send-email-viktorin@rehivetech.com \
--to=viktorin@rehivetech.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).