From: Bernard Iremonger <bernard.iremonger@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 3/3] ixgbe: allow use of zero MAC address with VF
Date: Wed, 24 Feb 2016 16:19:06 +0000 [thread overview]
Message-ID: <1456330746-15001-4-git-send-email-bernard.iremonger@intel.com> (raw)
In-Reply-To: <1456330746-15001-1-git-send-email-bernard.iremonger@intel.com>
Reprogram the RAR[0] with a zero MAC address,
to ensure that the VF traffic goes to the PF
after stop, close and detach of the VF.
Fixes: af75078fece3 ("first public release")
Fixes: 00e30184daa0 ("ixgbe: add PF support")
Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
---
drivers/net/ixgbe/ixgbe_ethdev.c | 10 +++++++++-
drivers/net/ixgbe/ixgbe_pf.c | 4 ++--
2 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 759177a..5608f67 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -3902,6 +3902,7 @@ static void
ixgbevf_dev_close(struct rte_eth_dev *dev)
{
struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+ struct ether_addr *addr = (struct ether_addr *)hw->mac.addr;
PMD_INIT_FUNC_TRACE();
@@ -3911,7 +3912,14 @@ ixgbevf_dev_close(struct rte_eth_dev *dev)
ixgbe_dev_free_queues(dev);
- /* reprogram the RAR[0] in case user changed it. */
+ memset(addr->addr_bytes, 0, ETHER_ADDR_LEN);
+
+ /**
+ * reprogram the RAR[0] with a zero mac address.
+ * to ensure that the VF traffic goes to the PF
+ * after stop, close and detach of the VF
+ **/
+
ixgbe_set_rar(hw, 0, hw->mac.addr, 0, IXGBE_RAH_AV);
}
diff --git a/drivers/net/ixgbe/ixgbe_pf.c b/drivers/net/ixgbe/ixgbe_pf.c
index 2ffbd1f..db2dba4 100644
--- a/drivers/net/ixgbe/ixgbe_pf.c
+++ b/drivers/net/ixgbe/ixgbe_pf.c
@@ -1,7 +1,7 @@
/*-
* BSD LICENSE
*
- * Copyright(c) 2010-2015 Intel Corporation. All rights reserved.
+ * Copyright(c) 2010-2016 Intel Corporation. All rights reserved.
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
@@ -445,7 +445,7 @@ ixgbe_vf_set_mac_addr(struct rte_eth_dev *dev, uint32_t vf, uint32_t *msgbuf)
int rar_entry = hw->mac.num_rar_entries - (vf + 1);
uint8_t *new_mac = (uint8_t *)(&msgbuf[1]);
- if (is_valid_assigned_ether_addr((struct ether_addr*)new_mac)) {
+ if (is_unicast_ether_addr((struct ether_addr *)new_mac)) {
rte_memcpy(vfinfo[vf].vf_mac_addresses, new_mac, 6);
return hw->mac.ops.set_rar(hw, rar_entry, new_mac, vf, IXGBE_RAH_AV);
}
--
2.6.3
next prev parent reply other threads:[~2016-02-24 16:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 16:19 [dpdk-dev] [PATCH 0/3] ixgbe fixes Bernard Iremonger
2016-02-24 16:19 ` [dpdk-dev] [PATCH 1/3] ixgbe: cleanup eth_ixgbevf_dev_uninit Bernard Iremonger
2016-02-24 16:19 ` [dpdk-dev] [PATCH 2/3] ixgbe: add more information to the error message Bernard Iremonger
2016-02-24 16:19 ` Bernard Iremonger [this message]
2016-02-26 14:49 ` [dpdk-dev] [PATCH 0/3 v2] ixgbe fixes Bernard Iremonger
2016-02-26 14:49 ` [dpdk-dev] [PATCH 1/3 v2] ixgbe: cleanup eth_ixgbevf_dev_uninit Bernard Iremonger
2016-02-26 14:49 ` [dpdk-dev] [PATCH 2/3 v2] ixgbe: add more information to the error message Bernard Iremonger
2016-02-26 14:49 ` [dpdk-dev] [PATCH 3/3 v2] ixgbe: fix setting of VF MAC address Bernard Iremonger
2016-02-29 17:03 ` [dpdk-dev] [PATCH 0/3 v2] ixgbe fixes Ananyev, Konstantin
2016-03-07 17:38 ` [dpdk-dev] [PATCH v3 0/3] " Bernard Iremonger
2016-03-07 17:38 ` [dpdk-dev] [PATCH v3 1/3] ixgbe: cleanup eth_ixgbevf_dev_uninit Bernard Iremonger
2016-03-07 17:38 ` [dpdk-dev] [PATCH v3 2/3] ixgbe: add more information to the error message Bernard Iremonger
2016-03-07 17:38 ` [dpdk-dev] [PATCH v3 3/3] ixgbe: fix dev_close to remove VF MAC address Bernard Iremonger
2016-03-08 17:10 ` [dpdk-dev] [PATCH v4 0/3] ixgbe fixes Bernard Iremonger
2016-03-08 17:10 ` [dpdk-dev] [PATCH v4 1/3] ixgbe: cleanup eth_ixgbevf_dev_uninit Bernard Iremonger
2016-03-08 17:10 ` [dpdk-dev] [PATCH v4 2/3] ixgbe: add more information to the error message Bernard Iremonger
2016-03-08 17:10 ` [dpdk-dev] [PATCH v4 3/3] ixgbe: fix dev_close to remove VF MAC address Bernard Iremonger
2016-03-09 13:17 ` Ananyev, Konstantin
2016-03-11 17:19 ` [dpdk-dev] [PATCH v4 0/3] ixgbe fixes Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456330746-15001-4-git-send-email-bernard.iremonger@intel.com \
--to=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).