From: John Daley <johndale@cisco.com>
To: dev@dpdk.org
Cc: johndale <johndale@cisco.com>
Subject: [dpdk-dev] [PATCH v4] enic: fix last packet being not sent bug
Date: Tue, 8 Mar 2016 10:49:07 -0800 [thread overview]
Message-ID: <1457462947-22845-1-git-send-email-johndale@cisco.com> (raw)
In-Reply-To: <1456105516-520-1-git-send-email-johndale@cisco.com>
From: johndale <johndale@cisco.com>
The last packet of the tx burst function array was not being
emitted until the subsequent call. The nic descriptor index
was being set to the current tx descriptr instead of one past the
the descriptor as required by nic.
Fixes: d739ba4c6abf ("enic: improve Tx packet rate")
Signed-off-by: John Daley <johndale@cisco.com>
---
Use full nime in 'Signed-off-by', add 'Fixes:'.
drivers/net/enic/base/enic_vnic_wq.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/enic/base/enic_vnic_wq.h b/drivers/net/enic/base/enic_vnic_wq.h
index e3ea574..b019109 100644
--- a/drivers/net/enic/base/enic_vnic_wq.h
+++ b/drivers/net/enic/base/enic_vnic_wq.h
@@ -69,11 +69,11 @@ static inline void enic_vnic_post_wq(struct vnic_wq *wq,
buf->wr_id = wrid;
buf = buf->next;
- if (cq_entry)
- enic_vnic_post_wq_index(wq);
+ wq->ring.desc_avail -= desc_skip_cnt;
wq->to_use = buf;
- wq->ring.desc_avail -= desc_skip_cnt;
+ if (cq_entry)
+ enic_vnic_post_wq_index(wq);
}
#endif /* _ENIC_VNIC_WQ_H_ */
--
2.7.0
next prev parent reply other threads:[~2016-03-08 18:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 1:06 [dpdk-dev] [PATCH] " johndale
2016-02-22 1:28 ` [dpdk-dev] [PATCH v2] " johndale
2016-02-22 1:45 ` [dpdk-dev] [PATCH v3] " johndale
2016-03-08 18:49 ` John Daley [this message]
2016-03-11 17:23 ` [dpdk-dev] [PATCH v4] " Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457462947-22845-1-git-send-email-johndale@cisco.com \
--to=johndale@cisco.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).