From: Pablo de Lara <pablo.de.lara.guarch@intel.com>
To: dev@dpdk.org
Cc: wenzhuo.lu@intel.com, bruce.richardson@intel.com,
Pablo de Lara <pablo.de.lara.guarch@intel.com>
Subject: [dpdk-dev] [PATCH v4 0/3] Fix incorrect max TX queue numbers for ixgbe
Date: Thu, 24 Mar 2016 15:22:01 +0000 [thread overview]
Message-ID: <1458832924-1489-1-git-send-email-pablo.de.lara.guarch@intel.com> (raw)
In-Reply-To: <1458832675-666-1-git-send-email-pablo.de.lara.guarch@intel.com>
IXGBE supports 128 TX queues. However, the full 128 queues
are only available in VT and DCB mode.
In normal default "none" mode (VT/DCB off) the maximum number
of available queues is only 64.
IXGBE doesn't check the mode when reporting the available
number of queues. If a queue larger than 64 is used in default mode,
the TX packets will be dropped silently.
This patchset:
- Modifies the device info to show the correct maximum number of available TX queues,
depending on the mode.
- Adds a check to forbid using a queue number larger than 64
during device configuration (in default mode), so that the problem is
reported as early as possible.
- It also changes the order of where the dev_conf parameters are copied
into the dev structure so that the correct maximum number of queues
is reported for the correct mode.
Changes in v4:
- Split the patch in three smaller patches
- Updated release notes document
Changes in v3:
- Fixed wrong set of TX queues for 82596EB
Changes in v2:
- Reorder memcpy of device configuration in rte_eth_dev_configure(),
so function gets the correct maximum number of queues
(depending on the operation mode), before checking the
requested number of queues.
- Renamed new macro
- Reworded/wrapped commit message
Pablo de Lara (1):
ethdev: copy device configuration earlier
Wenzhuo Lu (2):
ixgbe: fix incorrect tx queue number assignment
ixgbe: fix incorrect max tx queue number
doc/guides/rel_notes/release_16_04.rst | 6 ++++++
drivers/net/ixgbe/ixgbe_ethdev.c | 22 +++++++++++++++++++++-
drivers/net/ixgbe/ixgbe_ethdev.h | 1 +
lib/librte_ether/rte_ethdev.c | 6 +++---
4 files changed, 31 insertions(+), 4 deletions(-)
--
2.5.5
next prev parent reply other threads:[~2016-03-24 15:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 8:08 [dpdk-dev] [PATCH] ixgbe: add TX queue number check Wenzhuo Lu
2016-03-22 8:42 ` Qiu, Michael
2016-03-23 15:28 ` [dpdk-dev] [PATCH v2] ixgbe: add check for tx queue number Pablo de Lara
2016-03-24 8:09 ` Fischetti, Antonio
2016-03-24 8:40 ` Fischetti, Antonio
2016-03-24 10:27 ` De Lara Guarch, Pablo
2016-03-24 15:17 ` [dpdk-dev] [PATCH v3] " Pablo de Lara
2016-03-24 15:22 ` Pablo de Lara [this message]
2016-03-24 15:22 ` [dpdk-dev] [PATCH v4 1/3] ixgbe: fix incorrect tx queue number assignment Pablo de Lara
2016-03-24 16:57 ` Mcnamara, John
2016-03-24 15:22 ` [dpdk-dev] [PATCH v4 2/3] ethdev: copy device configuration earlier Pablo de Lara
2016-03-24 16:57 ` Mcnamara, John
2016-03-24 15:22 ` [dpdk-dev] [PATCH v4 3/3] ixgbe: fix incorrect max tx queue number Pablo de Lara
2016-03-24 16:58 ` Mcnamara, John
2016-03-26 9:10 ` Fischetti, Antonio
2016-03-24 17:44 ` [dpdk-dev] [PATCH v4 0/3] Fix incorrect max TX queue numbers for ixgbe Bruce Richardson
2016-03-24 17:46 ` Bruce Richardson
2016-03-26 9:17 ` [dpdk-dev] [PATCH v3] ixgbe: add check for tx queue number Fischetti, Antonio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458832924-1489-1-git-send-email-pablo.de.lara.guarch@intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).