From: Bernard Iremonger <bernard.iremonger@intel.com>
To: rahul.r.shah@intel.com, wenzhuo.lu@intel.com, dev@dpdk.org
Cc: Bernard Iremonger <bernard.iremonger@intel.com>,
azelezniak <alexz@att.com>
Subject: [dpdk-dev] [RFC PATCH v2 1/5] librte_ether: add internal callback functions
Date: Fri, 26 Aug 2016 10:10:16 +0100 [thread overview]
Message-ID: <1472202620-20487-2-git-send-email-bernard.iremonger@intel.com> (raw)
In-Reply-To: <1472202620-20487-1-git-send-email-bernard.iremonger@intel.com>
add _rte_eth_dev_callback_process_vf function.
add _rte_eth_dev_callback_process_generic function
Adding a callback to the user application on VF to PF mailbox message,
allows passing information to the application controlling the PF
when a VF mailbox event message is received, such as VF reset.
Signed-off-by: azelezniak <alexz@att.com>
Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
---
lib/librte_ether/rte_ethdev.c | 17 ++++++++++
lib/librte_ether/rte_ethdev.h | 61 ++++++++++++++++++++++++++++++++++
lib/librte_ether/rte_ether_version.map | 7 ++++
3 files changed, 85 insertions(+)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index f62a9ec..1388ea3 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -2690,6 +2690,20 @@ void
_rte_eth_dev_callback_process(struct rte_eth_dev *dev,
enum rte_eth_event_type event)
{
+ return _rte_eth_dev_callback_process_generic(dev, event, NULL);
+}
+
+void
+_rte_eth_dev_callback_process_vf(struct rte_eth_dev *dev,
+ enum rte_eth_event_type event, void *param)
+{
+ return _rte_eth_dev_callback_process_generic(dev, event, param);
+}
+
+void
+_rte_eth_dev_callback_process_generic(struct rte_eth_dev *dev,
+ enum rte_eth_event_type event, void *param)
+{
struct rte_eth_dev_callback *cb_lst;
struct rte_eth_dev_callback dev_cb;
@@ -2699,6 +2713,9 @@ _rte_eth_dev_callback_process(struct rte_eth_dev *dev,
continue;
dev_cb = *cb_lst;
cb_lst->active = 1;
+ if (param != NULL)
+ dev_cb.cb_arg = (void *) param;
+
rte_spinlock_unlock(&rte_eth_dev_cb_lock);
dev_cb.cb_fn(dev->data->port_id, dev_cb.event,
dev_cb.cb_arg);
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index b0fe033..4fb0b9c 100644
--- a/lib/librte_ether/rte_ethdev.h
+++ b/lib/librte_ether/rte_ethdev.h
@@ -3047,9 +3047,27 @@ enum rte_eth_event_type {
/**< queue state event (enabled/disabled) */
RTE_ETH_EVENT_INTR_RESET,
/**< reset interrupt event, sent to VF on PF reset */
+ RTE_ETH_EVENT_VF_MBOX, /**< PF mailbox processing callback */
RTE_ETH_EVENT_MAX /**< max value of this enum */
};
+/**
+ * Response sent back to ixgbe driver from user app after callback
+ */
+enum rte_eth_mb_event_rsp {
+ RTE_ETH_MB_EVENT_NOOP_ACK, /**< skip mbox request and ACK */
+ RTE_ETH_MB_EVENT_NOOP_NACK, /**< skip mbox request and NACK */
+ RTE_ETH_MB_EVENT_PROCEED, /**< proceed with mbox request */
+ RTE_ETH_MB_EVENT_MAX /**< max value of this enum */
+};
+
+struct rte_eth_mb_event_param {
+ uint16_t vfid;
+ uint16_t msg_type;
+ uint16_t retval;
+ void *userdata;
+};
+
typedef void (*rte_eth_dev_cb_fn)(uint8_t port_id, \
enum rte_eth_event_type event, void *cb_arg);
/**< user application callback to be registered for interrupts */
@@ -3114,6 +3132,49 @@ void _rte_eth_dev_callback_process(struct rte_eth_dev *dev,
enum rte_eth_event_type event);
/**
+ * @internal Executes all the user application registered callbacks for
+ * the specific device where parameter have to be passed to user application.
+ * It is for DPDK internal user only. User application should not call it
+ * directly.
+ *
+ * @param dev
+ * Pointer to struct rte_eth_dev.
+ * @param event
+ * Eth device interrupt event type.
+ *
+ * @param param
+ * parameters to pass back to user application.
+ *
+ * @return
+ * void
+ */
+
+void
+_rte_eth_dev_callback_process_vf(struct rte_eth_dev *dev,
+ enum rte_eth_event_type event, void *param);
+
+/**
+ * @internal Executes all the user application registered callbacks. Used by:
+ * _rte_eth_dev_callback_process and _rte_eth_dev_callback_process_vf
+ * It is for DPDK internal user only. User application should not call it
+ * directly.
+ *
+ * @param dev
+ * Pointer to struct rte_eth_dev.
+ * @param event
+ * Eth device interrupt event type.
+ *
+ * @param param
+ * parameters to pass back to user application.
+ *
+ * @return
+ * void
+ */
+void
+_rte_eth_dev_callback_process_generic(struct rte_eth_dev *dev,
+ enum rte_eth_event_type event, void *param);
+
+/**
* When there is no rx packet coming in Rx Queue for a long time, we can
* sleep lcore related to RX Queue for power saving, and enable rx interrupt
* to be triggered when rx packect arrives.
diff --git a/lib/librte_ether/rte_ether_version.map b/lib/librte_ether/rte_ether_version.map
index 45ddf44..cb7ef15 100644
--- a/lib/librte_ether/rte_ether_version.map
+++ b/lib/librte_ether/rte_ether_version.map
@@ -139,3 +139,10 @@ DPDK_16.07 {
rte_eth_dev_get_port_by_name;
rte_eth_xstats_get_names;
} DPDK_16.04;
+
+DPDK_16.11 {
+ global:
+
+ _rte_eth_dev_callback_process_generic;
+ _rte_eth_dev_callback_process_vf;
+} DPDK_16.07;
--
2.9.0
next prev parent reply other threads:[~2016-08-26 9:10 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 13:48 [dpdk-dev] [RFC PATCH 0/5] add API's for VF management Bernard Iremonger
2016-08-18 13:48 ` [dpdk-dev] [RFC PATCH 1/5] librte_ether: add internal callback functions Bernard Iremonger
2016-08-18 13:48 ` [dpdk-dev] [RFC PATCH 2/5] net/ixgbe: add callback to user app on VF to PF mbox msg Bernard Iremonger
2016-08-18 13:48 ` [dpdk-dev] [RFC PATCH 3/5] librte_ether: add API's for VF management Bernard Iremonger
2016-08-18 13:48 ` [dpdk-dev] [RFC PATCH 4/5] net/ixgbe: add functions " Bernard Iremonger
2016-08-18 13:48 ` [dpdk-dev] [RFC PATCH 5/5] app/test_pmd: add tests for new API's Bernard Iremonger
2016-08-26 9:10 ` [dpdk-dev] [RFC PATCH v2 0/5] add API's for VF management Bernard Iremonger
2016-08-26 9:10 ` Bernard Iremonger [this message]
2016-09-09 14:10 ` [dpdk-dev] [RFC PATCH v2 1/5] librte_ether: add internal callback functions Jerin Jacob
[not found] ` <3C0218D8B3DD114D8DBFE6B68141FBE3185F9FE7@MISOUT7MSGUSRDI.ITServices.sbc.com>
2016-09-13 8:45 ` Jerin Jacob
[not found] ` <3C0218D8B3DD114D8DBFE6B68141FBE3185FDCDC@MISOUT7MSGUSRDI.ITServices.sbc.com>
2016-09-14 11:28 ` Jerin Jacob
2016-09-22 11:25 ` Iremonger, Bernard
2016-10-03 8:58 ` Iremonger, Bernard
2016-08-26 9:10 ` [dpdk-dev] [RFC PATCH v2 2/5] net/ixgbe: add callback to user app on VF to PF mbox msg Bernard Iremonger
2016-08-26 9:10 ` [dpdk-dev] [RFC PATCH v2 3/5] librte_ether: add API's for VF management Bernard Iremonger
2016-09-09 14:22 ` Jerin Jacob
2016-09-12 16:28 ` Iremonger, Bernard
2016-09-13 9:24 ` Thomas Monjalon
2016-09-15 16:46 ` Iremonger, Bernard
2016-09-22 17:04 ` Thomas Monjalon
2016-09-23 9:20 ` Bruce Richardson
2016-09-23 9:36 ` Thomas Monjalon
2016-09-23 9:53 ` Richardson, Bruce
2016-09-23 13:15 ` Thomas Monjalon
2016-09-23 17:02 ` Iremonger, Bernard
2016-09-23 17:18 ` Thomas Monjalon
2016-09-26 15:37 ` Iremonger, Bernard
2016-09-26 16:59 ` Thomas Monjalon
2016-09-27 10:31 ` Iremonger, Bernard
2016-09-27 13:01 ` Bruce Richardson
2016-09-27 14:13 ` Iremonger, Bernard
2016-09-28 11:23 ` Ananyev, Konstantin
2016-09-28 12:31 ` Iremonger, Bernard
2016-09-28 13:01 ` Richardson, Bruce
2016-09-28 13:03 ` Thomas Monjalon
2016-09-28 13:26 ` Ananyev, Konstantin
2016-09-28 14:24 ` Thomas Monjalon
2016-09-28 14:30 ` Ananyev, Konstantin
2016-09-28 14:48 ` Iremonger, Bernard
2016-09-28 15:00 ` Thomas Monjalon
2016-09-28 15:24 ` Iremonger, Bernard
2016-09-28 14:59 ` Thomas Monjalon
2016-09-28 16:52 ` Ananyev, Konstantin
2016-09-28 18:02 ` Thomas Monjalon
2016-09-30 9:21 ` Bruce Richardson
2016-09-23 10:34 ` Bruce Richardson
2016-08-26 9:10 ` [dpdk-dev] [RFC PATCH v2 4/5] net/ixgbe: add functions " Bernard Iremonger
2016-08-26 9:10 ` [dpdk-dev] [RFC PATCH v2 5/5] app/test_pmd: add tests for new API's Bernard Iremonger
2016-09-11 12:35 ` Yuanhan Liu
2016-09-12 15:57 ` Iremonger, Bernard
2016-09-13 4:34 ` Yuanhan Liu
2016-09-13 8:38 ` Iremonger, Bernard
2016-09-13 8:42 ` Yuanhan Liu
2016-09-07 9:18 ` [dpdk-dev] [RFC PATCH v2 0/5] add API's for VF management Pattan, Reshma
2016-09-09 8:49 ` Pattan, Reshma
2016-09-09 13:02 ` Thomas Monjalon
2016-09-16 11:05 ` [dpdk-dev] [PATCH v3 0/3] " Bernard Iremonger
2016-09-16 11:05 ` [dpdk-dev] [PATCH v3 1/3] librte_ether: " Bernard Iremonger
2016-09-16 11:05 ` [dpdk-dev] [PATCH v3 2/3] net/ixgbe: add functions " Bernard Iremonger
2016-09-16 11:05 ` [dpdk-dev] [PATCH v3 3/3] app/test_pmd: add tests for new API's Bernard Iremonger
2016-09-16 14:15 ` [dpdk-dev] [PATCH v3 0/3] add API's for VF management Bernard Iremonger
2016-09-21 10:20 ` [dpdk-dev] [PATCH v4 " Bernard Iremonger
2016-09-29 14:16 ` [dpdk-dev] [PATCH v5 " Bernard Iremonger
2016-09-30 10:30 ` [dpdk-dev] [PATCH v6 0/2] " Bernard Iremonger
2016-09-30 10:30 ` [dpdk-dev] [PATCH v6 1/2] net/ixgbe: " Bernard Iremonger
2016-10-07 10:45 ` [dpdk-dev] [PATCH v7 0/2] " Bernard Iremonger
2016-10-07 10:45 ` [dpdk-dev] [PATCH v7 1/2] net/ixgbe: " Bernard Iremonger
2016-10-07 10:45 ` [dpdk-dev] [PATCH v7 2/2] app/test_pmd: add tests for new API's Bernard Iremonger
2016-10-11 15:09 ` Ferruh Yigit
2016-10-11 15:41 ` Thomas Monjalon
2016-10-11 15:51 ` Iremonger, Bernard
2016-10-11 16:32 ` Thomas Monjalon
2016-10-11 16:35 ` Iremonger, Bernard
2016-10-12 2:05 ` De Lara Guarch, Pablo
2016-10-12 15:00 ` Iremonger, Bernard
2016-09-30 10:30 ` [dpdk-dev] [PATCH v6 " Bernard Iremonger
2016-09-29 14:16 ` [dpdk-dev] [PATCH v5 1/3] librte_ether: add API for VF management Bernard Iremonger
2016-09-29 14:30 ` Thomas Monjalon
2016-09-29 15:16 ` Iremonger, Bernard
2016-09-29 16:19 ` Thomas Monjalon
2016-09-29 16:38 ` Iremonger, Bernard
2016-09-29 16:45 ` Thomas Monjalon
2016-09-29 14:16 ` [dpdk-dev] [PATCH v5 2/3] net/ixgbe: add API's " Bernard Iremonger
2016-09-29 16:11 ` Reshma Pattan
2016-09-29 16:32 ` Iremonger, Bernard
2016-09-29 16:16 ` Pattan, Reshma
2016-09-29 16:30 ` Iremonger, Bernard
2016-09-29 14:16 ` [dpdk-dev] [PATCH v5 3/3] app/test_pmd: add tests for new API's Bernard Iremonger
2016-09-21 10:20 ` [dpdk-dev] [PATCH v4 1/3] librte_ether: add API's for VF management Bernard Iremonger
2016-09-21 10:20 ` [dpdk-dev] [PATCH v4 2/3] net/ixgbe: add functions " Bernard Iremonger
2016-09-21 10:20 ` [dpdk-dev] [PATCH v4 3/3] app/test_pmd: add tests for new API's Bernard Iremonger
2016-09-16 14:15 ` [dpdk-dev] [PATCH v3 1/3] librte_ether: add API's for VF management Bernard Iremonger
2016-09-16 14:15 ` [dpdk-dev] [PATCH v3 2/3] net/ixgbe: add functions " Bernard Iremonger
2016-09-16 14:15 ` [dpdk-dev] [PATCH v3 3/3] app/test_pmd: add tests for new API's Bernard Iremonger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472202620-20487-2-git-send-email-bernard.iremonger@intel.com \
--to=bernard.iremonger@intel.com \
--cc=alexz@att.com \
--cc=dev@dpdk.org \
--cc=rahul.r.shah@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).