From: Jianfeng Tan <jianfeng.tan@intel.com>
To: dev@dpdk.org
Cc: stable@dpdk.org, yuanhan.liu@linux.intel.com,
Jianfeng Tan <jianfeng.tan@intel.com>
Subject: [dpdk-stable] [PATCH v2 1/3] net/virtio_user: fix queue pair not enabled
Date: Tue, 27 Sep 2016 19:11:04 +0000 [thread overview]
Message-ID: <1475003466-146063-2-git-send-email-jianfeng.tan@intel.com> (raw)
In-Reply-To: <1475003466-146063-1-git-send-email-jianfeng.tan@intel.com>
When virtio_user is used with OVS-DPDK (with mq disabled), it cannot
receive any packets.
It's because when vhost provides VHOST_USER_GET_PROTOCOL_FEATURES,
all queue pairs are initialized in the disabled state. Quote
QEMU/docs/specs/vhost-user.txt:
If VHOST_USER_F_PROTOCOL_FEATURES has not been negotiated, the
ring is initialized in an enabled state.
If VHOST_USER_F_PROTOCOL_FEATURES has been negotiated, the ring
is initialized in a disabled state.
In OVS-DPDK, all queue pairs are in the disabled state by default.
When used with QEMU, QEMU will set it as enabled in the process of
initialization. So this patch is to add similar logic in virtio_user.
Fixes: 37a7eb2ae816 ("net/virtio-user: add device emulation layer")
Reported-by: Ning Li <lining18@jd.com>
Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
---
drivers/net/virtio/virtio_user/virtio_user_dev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c
index 376c9cf..bf1155c 100644
--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c
+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c
@@ -131,6 +131,9 @@ virtio_user_start_device(struct virtio_user_dev *dev)
}
}
+ /* we enable the 1st queue pair by default. */
+ vhost_user_enable_queue_pair(dev->vhostfd, 0, 1);
+
/* After setup all virtqueues, we need to set_features so that these
* features can be set into each virtqueue in vhost side. And before
* that, make sure VHOST_USER_F_PROTOCOL_FEATURES is added if mq is
--
2.7.4
next prev parent reply other threads:[~2016-09-27 19:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1470397003-5782-1-git-send-email-jianfeng.tan@intel.com>
2016-08-29 7:01 ` [dpdk-stable] [dpdk-dev] [PATCH 0/3] fix virtio_user issues Christian Ehrhardt
2016-09-27 19:11 ` [dpdk-stable] [PATCH v2 " Jianfeng Tan
2016-09-27 19:11 ` Jianfeng Tan [this message]
2016-09-28 0:05 ` [dpdk-stable] [PATCH v2 1/3] net/virtio_user: fix queue pair not enabled Yuanhan Liu
2016-09-27 19:11 ` [dpdk-stable] [PATCH v2 2/3] net/virtio_user: fix wrong sequence of messages Jianfeng Tan
2016-09-27 19:11 ` [dpdk-stable] [PATCH v2 3/3] net/virtio_user: fix dev not freed after init error Jianfeng Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475003466-146063-2-git-send-email-jianfeng.tan@intel.com \
--to=jianfeng.tan@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).