DPDK patches and discussions
 help / color / mirror / Atom feed
From: Qi Zhang <qi.z.zhang@intel.com>
To: jingjing.wu@intel.com, helin.zhang@intel.com
Cc: dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>
Subject: [dpdk-dev] [PATCH v2 0/3] net: fix out of order Rx read issue
Date: Tue, 18 Oct 2016 02:29:39 +0800	[thread overview]
Message-ID: <1476728982-39985-1-git-send-email-qi.z.zhang@intel.com> (raw)

In vPMD, when load Rx desc with _mm_loadu_si128, 
volatile point will be cast into non-volatile point.
So GCC is allowed to reorder the load instructions, 
while Rx read's correctness is reply on these load 
instructions to follow a backward sequence strictly, 
so we add compile barrier to prevent compiler reorder.
We already met this issue on i40e with GCC6 and we 
fixed this on ixgbe and fm10k also.

v2: 
- fix check-git-log.sh warning.
- add more detail commit message.

Qi Zhang (3):
  net/i40e: fix out of order Rx read issue
  net/ixgbe: fix out of order Rx read issue
  net/fm10k: fix out of ofder Rx read issue

 drivers/net/fm10k/fm10k_rxtx_vec.c     | 3 +++
 drivers/net/i40e/i40e_rxtx_vec.c       | 3 +++
 drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c | 3 +++
 3 files changed, 9 insertions(+)

-- 
2.7.4

             reply	other threads:[~2016-10-18  1:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-17 18:29 Qi Zhang [this message]
2016-10-17 18:29 ` [dpdk-dev] [PATCH v2 1/3] net/i40e: " Qi Zhang
2016-10-17 18:29 ` [dpdk-dev] [PATCH v2 2/3] net/ixgbe: " Qi Zhang
2016-10-17 18:29 ` [dpdk-dev] [PATCH v2 3/3] net/fm10k: fix out of ofder " Qi Zhang
2016-10-18 11:33 ` [dpdk-dev] [PATCH v2 0/3] net: fix out of order " Ananyev, Konstantin
2016-10-19  9:52   ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476728982-39985-1-git-send-email-qi.z.zhang@intel.com \
    --to=qi.z.zhang@intel.com \
    --cc=dev@dpdk.org \
    --cc=helin.zhang@intel.com \
    --cc=jingjing.wu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).