DPDK patches and discussions
 help / color / mirror / Atom feed
From: "E. Scott Daniels" <daniels@research.att.com>
To: helin.zhang@intel.com, bernard.iremonger@intel.com
Cc: dev@dpdk.org, az5157@att.com,
	"E. Scott Daniels" <daniels@research.att.com>
Subject: [dpdk-dev] [PATCH] net/ixgbe: prevent duplicate callback on list
Date: Wed, 19 Oct 2016 18:23:06 -0400	[thread overview]
Message-ID: <1476915787-28205-1-git-send-email-daniels@research.att.com> (raw)

If rte_eth_dev_callback_register() is invoked with parameters
which match a callback struct that is already on the list, an
attempt is made to add that same struct onto the tail of the
list. Adding a struct which is already on the list will have
undesired results.

This is an edge case, but I think it should be corrected;
patch prevents the attempt to add a struct which is already
on the list.

E. Scott Daniels (1):
  net/ixgbe: prevent duplicate callback on list

 lib/librte_ether/rte_ethdev.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

-- 
1.9.1

             reply	other threads:[~2016-10-19 22:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-19 22:23 E. Scott Daniels [this message]
2016-10-19 22:23 ` E. Scott Daniels
2016-10-20  1:39   ` Lu, Wenzhuo
2016-10-20  2:11     ` Scott Daniels
2016-10-20  2:19       ` Lu, Wenzhuo
2016-10-20  2:31         ` Scott Daniels
2016-10-20 13:35           ` Scott Daniels

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476915787-28205-1-git-send-email-daniels@research.att.com \
    --to=daniels@research.att.com \
    --cc=az5157@att.com \
    --cc=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    --cc=helin.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).