From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: dev@dpdk.org
Cc: Ilya Maximets <i.maximets@samsung.com>
Subject: [dpdk-dev] [PATCH 0/8] net/virtio: fix queue reconfigure issue
Date: Fri, 4 Nov 2016 00:09:52 +0800 [thread overview]
Message-ID: <1478189400-14606-1-git-send-email-yuanhan.liu@linux.intel.com> (raw)
This patchset fixes an issue (virtio/vhost become broken when queue setup
is done 2 or more times, check patch 2 for great details) reported by Ilya
at the late stage of last release. I sensed it would be some amounts of
code work, that I delayed it to this release. However, I failed to make
the fix in the early stage of this release, that we come to the same
situation again: we are being at the late stage of v16.11 :(
However, honestly, I don't want to miss it again in this release, as it
is hard to backport such fix to a stable release. It's not a bug can
be fixed by few lines of code. The virtio init logic is quite wrong that
I need change quite many places to fix it. Meanwhile, I have done my best
to keep the change being as minimal as possible.
Besides that, judging that v16.11 would be a LTS and it's such an severe
bug that should be fixed ASAP (at least, we should make it work in a LTS
release), I then tried hard today to make this patchset, with the hope we
could fix this severe issue at this release.
The issue is decribed in length in patch 4 "net/virtio: allocate queue
at init stage".
Again, it's not a bug can be fixed by one patch, that you see no one
"fix" tag in none of those patches. All below patches work together
to fix this issue.
Thanks.
--yliu
---
Yuanhan Liu (8):
net/virtio: revert "virtio: fix restart"
net/virtio: simplify queue memzone name
net/virtio: simplify queue allocation
net/virtio: allocate queue at init stage
net/virtio: initiate vring at init stage
net/virtio: move queue configure code to proper place
net/virtio: complete init stage at the right place
net/virtio: remove started field
drivers/net/virtio/virtio_ethdev.c | 182 ++++++++++++++++-----------
drivers/net/virtio/virtio_ethdev.h | 10 --
drivers/net/virtio/virtio_pci.h | 3 +-
drivers/net/virtio/virtio_rxtx.c | 247 ++++++++++++++-----------------------
drivers/net/virtio/virtqueue.h | 7 ++
5 files changed, 208 insertions(+), 241 deletions(-)
--
1.9.0
next reply other threads:[~2016-11-03 16:09 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-03 16:09 Yuanhan Liu [this message]
2016-11-03 16:09 ` [dpdk-dev] [PATCH 1/8] net/virtio: revert "virtio: fix restart" Yuanhan Liu
2016-11-03 20:36 ` Maxime Coquelin
2016-11-04 2:00 ` Yuanhan Liu
2016-11-04 8:09 ` Maxime Coquelin
2016-11-04 14:28 ` Yuanhan Liu
2016-11-04 8:10 ` Maxime Coquelin
2016-11-03 16:09 ` [dpdk-dev] [PATCH 2/8] net/virtio: simplify queue memzone name Yuanhan Liu
2016-11-03 20:41 ` Maxime Coquelin
2016-11-03 16:09 ` [dpdk-dev] [PATCH 3/8] net/virtio: simplify queue allocation Yuanhan Liu
2016-11-03 20:48 ` Maxime Coquelin
2016-11-04 1:51 ` Yuanhan Liu
2016-11-03 16:09 ` [dpdk-dev] [PATCH 4/8] net/virtio: allocate queue at init stage Yuanhan Liu
2016-11-03 21:11 ` Maxime Coquelin
2016-11-04 1:50 ` Yuanhan Liu
2016-11-04 8:08 ` Maxime Coquelin
2016-11-04 8:25 ` Maxime Coquelin
2016-11-04 15:21 ` Kevin Traynor
2016-11-04 20:30 ` Kevin Traynor
2016-11-05 6:15 ` Yuanhan Liu
2016-11-03 16:09 ` [dpdk-dev] [PATCH 5/8] net/virtio: initiate vring " Yuanhan Liu
2016-11-04 8:34 ` Maxime Coquelin
2016-11-03 16:09 ` [dpdk-dev] [PATCH 6/8] net/virtio: move queue configure code to proper place Yuanhan Liu
2016-11-04 8:39 ` Maxime Coquelin
2016-11-03 16:09 ` [dpdk-dev] [PATCH 7/8] net/virtio: complete init stage at the right place Yuanhan Liu
2016-11-04 8:44 ` Maxime Coquelin
2016-11-03 16:10 ` [dpdk-dev] [PATCH 8/8] net/virtio: remove started field Yuanhan Liu
2016-11-04 8:46 ` Maxime Coquelin
2016-11-05 9:40 ` [dpdk-dev] [PATCH v2 00/10] net/virtio: fix queue reconfigure issue Yuanhan Liu
2016-11-05 9:40 ` [dpdk-dev] [PATCH v2 01/10] net/virtio: revert fix restart Yuanhan Liu
2016-11-05 9:40 ` [dpdk-dev] [PATCH v2 02/10] net/virtio: simplify queue memzone name Yuanhan Liu
2016-11-05 9:40 ` [dpdk-dev] [PATCH v2 03/10] net/virtio: simplify queue allocation Yuanhan Liu
2016-11-05 9:40 ` [dpdk-dev] [PATCH v2 04/10] net/virtio: allocate queue at init stage Yuanhan Liu
2016-11-07 14:23 ` Thomas Monjalon
2016-11-05 9:41 ` [dpdk-dev] [PATCH v2 05/10] net/virtio: initiate vring " Yuanhan Liu
2016-11-05 9:41 ` [dpdk-dev] [PATCH v2 06/10] net/virtio: move queue configure code to proper place Yuanhan Liu
2016-11-05 9:41 ` [dpdk-dev] [PATCH v2 07/10] net/virtio: complete init stage at the right place Yuanhan Liu
2016-11-05 9:41 ` [dpdk-dev] [PATCH v2 08/10] net/virtio: remove started field Yuanhan Liu
2016-11-05 9:41 ` [dpdk-dev] [PATCH v2 09/10] net/virtio: fix less queues being enabled issue Yuanhan Liu
2016-11-05 9:41 ` [dpdk-dev] [PATCH v2 10/10] net/virtio: fix multiple queue enabling Yuanhan Liu
2016-11-07 9:25 ` Yuanhan Liu
2016-11-07 14:44 ` [dpdk-dev] [PATCH v2 00/10] net/virtio: fix queue reconfigure issue Thomas Monjalon
2016-11-07 15:05 ` Yao, Lei A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478189400-14606-1-git-send-email-yuanhan.liu@linux.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=i.maximets@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).