From: Radu Nicolau <radu.nicolau@intel.com>
To: Shahaf Shuler <shahafs@mellanox.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 09/39] examples/bond: convert to new ethdev offloads API
Date: Mon, 11 Dec 2017 11:08:10 +0000 [thread overview]
Message-ID: <147e40cf-ff76-079b-a6f3-7a9567bd4a36@intel.com> (raw)
In-Reply-To: <20171123121419.144132-10-shahafs@mellanox.com>
On 11/23/2017 12:14 PM, Shahaf Shuler wrote:
> Ethdev offloads API has changed since:
>
> commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API")
> commit cba7f53b717d ("ethdev: introduce Tx queue offloads API")
>
> This commit support the new API.
>
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
> examples/bond/main.c | 68 ++++++++++++++++++++++++++++++++++++++++-------
> 1 file changed, 58 insertions(+), 10 deletions(-)
>
> diff --git a/examples/bond/main.c b/examples/bond/main.c
> index 8e3b1f340..306447e6b 100644
> --- a/examples/bond/main.c
> +++ b/examples/bond/main.c
> @@ -151,11 +151,8 @@ static struct rte_eth_conf port_conf = {
> .mq_mode = ETH_MQ_RX_NONE,
> .max_rx_pkt_len = ETHER_MAX_LEN,
> .split_hdr_size = 0,
> - .header_split = 0, /**< Header Split disabled */
> - .hw_ip_checksum = 0, /**< IP checksum offload enabled */
> - .hw_vlan_filter = 0, /**< VLAN filtering disabled */
> - .jumbo_frame = 0, /**< Jumbo Frame Support disabled */
> - .hw_strip_crc = 1, /**< CRC stripped by hardware */
> + .ignore_offload_bitfield = 1,
> + .offloads = DEV_RX_OFFLOAD_CRC_STRIP,
> },
> .rx_adv_conf = {
> .rss_conf = {
> @@ -174,10 +171,30 @@ slave_port_init(uint16_t portid, struct rte_mempool *mbuf_pool)
> int retval;
> uint16_t nb_rxd = RTE_RX_DESC_DEFAULT;
> uint16_t nb_txd = RTE_TX_DESC_DEFAULT;
> + struct rte_eth_dev_info dev_info;
> + struct rte_eth_rxconf rxq_conf;
> + struct rte_eth_txconf txq_conf;
>
> if (portid >= rte_eth_dev_count())
> rte_exit(EXIT_FAILURE, "Invalid port\n");
>
> + rte_eth_dev_info_get(portid, &dev_info);
> + if ((dev_info.rx_offload_capa & port_conf.rxmode.offloads) !=
> + port_conf.rxmode.offloads) {
> + printf("Some Rx offloads are not supported "
> + "by port %d: requested 0x%lx supported 0x%lx\n",
> + portid, port_conf.rxmode.offloads,
> + dev_info.rx_offload_capa);
> + port_conf.rxmode.offloads &= dev_info.rx_offload_capa;
> + }
> + if ((dev_info.tx_offload_capa & port_conf.txmode.offloads) !=
> + port_conf.txmode.offloads) {
> + printf("Some Tx offloads are not supported "
> + "by port %d: requested 0x%lx supported 0x%lx\n",
> + portid, port_conf.txmode.offloads,
> + dev_info.tx_offload_capa);
> + port_conf.txmode.offloads &= dev_info.tx_offload_capa;
> + }
> retval = rte_eth_dev_configure(portid, 1, 1, &port_conf);
> if (retval != 0)
> rte_exit(EXIT_FAILURE, "port %u: configuration failed (res=%d)\n",
> @@ -189,16 +206,22 @@ slave_port_init(uint16_t portid, struct rte_mempool *mbuf_pool)
> "failed (res=%d)\n", portid, retval);
>
> /* RX setup */
> + rxq_conf = dev_info.default_rxconf;
> + rxq_conf.offloads = port_conf.rxmode.offloads;
> retval = rte_eth_rx_queue_setup(portid, 0, nb_rxd,
> - rte_eth_dev_socket_id(portid), NULL,
> + rte_eth_dev_socket_id(portid),
> + &rxq_conf,
> mbuf_pool);
> if (retval < 0)
> rte_exit(retval, " port %u: RX queue 0 setup failed (res=%d)",
> portid, retval);
>
> /* TX setup */
> + txq_conf = dev_info.default_txconf;
> + txq_conf.txq_flags = ETH_TXQ_FLAGS_IGNORE;
> + txq_conf.offloads = port_conf.txmode.offloads;
> retval = rte_eth_tx_queue_setup(portid, 0, nb_txd,
> - rte_eth_dev_socket_id(portid), NULL);
> + rte_eth_dev_socket_id(portid), &txq_conf);
>
> if (retval < 0)
> rte_exit(retval, "port %u: TX queue 0 setup failed (res=%d)",
> @@ -225,6 +248,9 @@ bond_port_init(struct rte_mempool *mbuf_pool)
> uint8_t i;
> uint16_t nb_rxd = RTE_RX_DESC_DEFAULT;
> uint16_t nb_txd = RTE_TX_DESC_DEFAULT;
> + struct rte_eth_dev_info dev_info;
> + struct rte_eth_rxconf rxq_conf;
> + struct rte_eth_txconf txq_conf;
>
> retval = rte_eth_bond_create("bond0", BONDING_MODE_ALB,
> 0 /*SOCKET_ID_ANY*/);
> @@ -234,6 +260,23 @@ bond_port_init(struct rte_mempool *mbuf_pool)
>
> BOND_PORT = retval;
>
> + rte_eth_dev_info_get(BOND_PORT, &dev_info);
> + if ((dev_info.rx_offload_capa & port_conf.rxmode.offloads) !=
> + port_conf.rxmode.offloads) {
> + printf("Some Rx offloads are not supported "
> + "by port %d: requested 0x%lx supported 0x%lx\n",
> + BOND_PORT, port_conf.rxmode.offloads,
> + dev_info.rx_offload_capa);
> + port_conf.rxmode.offloads &= dev_info.rx_offload_capa;
> + }
> + if ((dev_info.tx_offload_capa & port_conf.txmode.offloads) !=
> + port_conf.txmode.offloads) {
> + printf("Some Tx offloads are not supported "
> + "by port %d: requested 0x%lx supported 0x%lx\n",
> + BOND_PORT, port_conf.txmode.offloads,
> + dev_info.tx_offload_capa);
> + port_conf.txmode.offloads &= dev_info.tx_offload_capa;
> + }
> retval = rte_eth_dev_configure(BOND_PORT, 1, 1, &port_conf);
> if (retval != 0)
> rte_exit(EXIT_FAILURE, "port %u: configuration failed (res=%d)\n",
> @@ -245,16 +288,21 @@ bond_port_init(struct rte_mempool *mbuf_pool)
> "failed (res=%d)\n", BOND_PORT, retval);
>
> /* RX setup */
> + rxq_conf = dev_info.default_rxconf;
> + rxq_conf.offloads = port_conf.rxmode.offloads;
> retval = rte_eth_rx_queue_setup(BOND_PORT, 0, nb_rxd,
> - rte_eth_dev_socket_id(BOND_PORT), NULL,
> - mbuf_pool);
> + rte_eth_dev_socket_id(BOND_PORT),
> + &rxq_conf, mbuf_pool);
> if (retval < 0)
> rte_exit(retval, " port %u: RX queue 0 setup failed (res=%d)",
> BOND_PORT, retval);
>
> /* TX setup */
> + txq_conf = dev_info.default_txconf;
> + txq_conf.txq_flags = ETH_TXQ_FLAGS_IGNORE;
> + txq_conf.offloads = port_conf.txmode.offloads;
> retval = rte_eth_tx_queue_setup(BOND_PORT, 0, nb_txd,
> - rte_eth_dev_socket_id(BOND_PORT), NULL);
> + rte_eth_dev_socket_id(BOND_PORT), &txq_conf);
>
> if (retval < 0)
> rte_exit(retval, "port %u: TX queue 0 setup failed (res=%d)",
Reviewed-by: Radu Nicolau <radu.nicolau@intel.com>
next prev parent reply other threads:[~2017-12-11 11:08 UTC|newest]
Thread overview: 134+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 12:14 [dpdk-dev] [PATCH 00/39] convert examples " Shahaf Shuler
2017-11-23 12:14 ` [dpdk-dev] [PATCH 01/39] examples/l2fwd: convert " Shahaf Shuler
2017-11-24 15:00 ` Andrew Rybchenko
2017-11-26 7:41 ` Shahaf Shuler
2017-11-27 6:34 ` Andrew Rybchenko
2017-11-27 7:03 ` Shahaf Shuler
2017-11-27 7:33 ` Jerin Jacob
2017-11-27 19:41 ` Shahaf Shuler
2017-11-27 7:40 ` Andrew Rybchenko
2017-11-23 12:14 ` [dpdk-dev] [PATCH 02/39] examples/l2fwd-crypto: " Shahaf Shuler
2017-11-23 12:14 ` [dpdk-dev] [PATCH 03/39] examples/l2fwd-jobstats: " Shahaf Shuler
2017-11-23 12:14 ` [dpdk-dev] [PATCH 04/39] examples/l2fwd-keepalive: " Shahaf Shuler
2017-11-23 12:14 ` [dpdk-dev] [PATCH 05/39] examples/l3fwd: move to " Shahaf Shuler
2017-11-23 12:14 ` [dpdk-dev] [PATCH 06/39] examples/l3fwd-acl: convert to new " Shahaf Shuler
2017-12-11 14:48 ` Ananyev, Konstantin
2017-11-23 12:14 ` [dpdk-dev] [PATCH 07/39] examples/l3fwd-power: " Shahaf Shuler
2017-12-11 14:00 ` Hunt, David
2017-11-23 12:14 ` [dpdk-dev] [PATCH 08/39] examples/l3fwd-vf: " Shahaf Shuler
2017-11-23 12:14 ` [dpdk-dev] [PATCH 09/39] examples/bond: " Shahaf Shuler
2017-12-11 11:08 ` Radu Nicolau [this message]
2017-12-04 12:12 ` [dpdk-dev] [PATCH 00/39] convert examples " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 01/39] examples/l2fwd: convert " Shahaf Shuler
2017-12-19 12:16 ` De Lara Guarch, Pablo
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 02/39] examples/l2fwd-crypto: " Shahaf Shuler
2017-12-19 12:18 ` De Lara Guarch, Pablo
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 03/39] examples/l2fwd-jobstats: " Shahaf Shuler
2017-12-19 12:33 ` De Lara Guarch, Pablo
2017-12-21 13:47 ` Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 04/39] examples/l2fwd-keepalive: " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 05/39] examples/l3fwd: move to " Shahaf Shuler
2017-12-12 17:12 ` Ananyev, Konstantin
2017-12-13 7:21 ` Shahaf Shuler
2017-12-13 7:55 ` Jerin Jacob
2017-12-13 12:10 ` Ananyev, Konstantin
2017-12-13 17:32 ` Jerin Jacob
2017-12-21 14:26 ` Shahaf Shuler
2017-12-18 16:00 ` Maciej Czekaj
2017-12-21 14:08 ` Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 06/39] examples/l3fwd-acl: convert to new " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 07/39] examples/l3fwd-power: " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 08/39] examples/l3fwd-vf: " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 09/39] examples/bond: " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 10/39] examples/exception_path: " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 11/39] examples/kni: " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 12/39] examples/ip_fragmentation: convert to new " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 13/39] examples/ip_pipeline: convert to new ethdev " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 14/39] examples/ip_reassembly: " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 15/39] examples/ipsec-secgw: " Shahaf Shuler
2017-12-19 12:38 ` De Lara Guarch, Pablo
2017-12-21 13:45 ` Shahaf Shuler
2018-01-08 16:27 ` De Lara Guarch, Pablo
2018-01-09 7:07 ` Akhil Goyal
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 16/39] examples/ipv4_multicast: " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 17/39] examples/link_status_interrupt: convert to new " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 18/39] examples/load_balancer: convert to new ethdev " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 19/39] examples/multi_process: " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 20/39] examples/netmap_compat: " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 21/39] examples/performance-thread: convert to new " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 22/39] examples/qos_meter: convert to new ethdev " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 23/39] examples/qos_sched: " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 24/39] examples/quota_watermark: " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 25/39] examples/tep_termination: " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 26/39] examples/vhost: " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 27/39] examples/vmdq: " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 28/39] examples/vmdq_dcb: " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 29/39] examples/vm_power_manager: convert to new " Shahaf Shuler
2017-12-12 12:35 ` [dpdk-dev] [PATCH v2 30/39] examples/distributor: convert to new ethdev " Shahaf Shuler
2017-12-12 12:35 ` [dpdk-dev] [PATCH v2 31/39] examples/ethtool: " Shahaf Shuler
2017-12-12 12:35 ` [dpdk-dev] [PATCH v2 32/39] examples/eventdev_pipeline: convert to new " Shahaf Shuler
2017-12-15 15:20 ` Van Haaren, Harry
2017-12-12 12:35 ` [dpdk-dev] [PATCH v2 33/39] examples/flow_classify: convert to new ethdev " Shahaf Shuler
2017-12-12 12:35 ` [dpdk-dev] [PATCH v2 34/39] examples/flow_filtering: " Shahaf Shuler
2017-12-12 12:35 ` [dpdk-dev] [PATCH v2 35/39] examples/packet_ordering: " Shahaf Shuler
2017-12-12 12:35 ` [dpdk-dev] [PATCH v2 36/39] examples/ptpclient: " Shahaf Shuler
2017-12-12 12:35 ` [dpdk-dev] [PATCH v2 37/39] examples/rxtx_callbacks: " Shahaf Shuler
2017-12-12 12:35 ` [dpdk-dev] [PATCH v2 38/39] examples/server_node_efd: " Shahaf Shuler
2017-12-12 12:35 ` [dpdk-dev] [PATCH v2 39/39] examples/skeleton: " Shahaf Shuler
2017-12-26 9:22 ` [dpdk-dev] [PATCH v3 00/39] convert examples " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 01/39] examples/l2fwd: convert " Shahaf Shuler
2018-01-10 12:12 ` De Lara Guarch, Pablo
2018-01-12 13:30 ` Ferruh Yigit
2018-01-14 10:37 ` Shahaf Shuler
2018-01-15 10:20 ` Ferruh Yigit
2018-01-15 11:02 ` Shahaf Shuler
2018-01-15 11:34 ` Ferruh Yigit
2018-01-15 11:41 ` Shahaf Shuler
2018-01-15 11:56 ` Ferruh Yigit
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 02/39] examples/l2fwd-crypto: " Shahaf Shuler
2018-01-10 12:12 ` De Lara Guarch, Pablo
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 03/39] examples/l2fwd-jobstats: " Shahaf Shuler
2018-01-10 12:13 ` De Lara Guarch, Pablo
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 04/39] examples/l2fwd-keepalive: " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 05/39] examples/l3fwd: convert to " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 06/39] examples/l3fwd-acl: convert to new " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 07/39] examples/l3fwd-power: " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 08/39] examples/l3fwd-vf: " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 09/39] examples/bond: " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 10/39] examples/exception_path: " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 11/39] examples/kni: " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 12/39] examples/ip_fragmentation: convert to new " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 13/39] examples/ip_pipeline: convert to new ethdev " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 14/39] examples/ip_reassembly: " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 15/39] examples/ipsec-secgw: " Shahaf Shuler
2018-01-16 11:10 ` Nicolau, Radu
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 16/39] examples/ipv4_multicast: " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 17/39] examples/link_status_interrupt: convert to new " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 18/39] examples/load_balancer: convert to new ethdev " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 19/39] examples/multi_process: " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 20/39] examples/netmap_compat: " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 21/39] examples/performance-thread: convert to new " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 22/39] examples/qos_meter: convert to new ethdev " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 23/39] examples/qos_sched: " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 24/39] examples/quota_watermark: " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 25/39] examples/tep_termination: " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 26/39] examples/vhost: " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 27/39] examples/vmdq: " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 28/39] examples/vmdq_dcb: " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 29/39] examples/vm_power_manager: convert to new " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 30/39] examples/distributor: convert to new ethdev " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 31/39] examples/ethtool: " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 32/39] examples/eventdev_pipeline: convert to new " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 33/39] examples/flow_classify: convert to new ethdev " Shahaf Shuler
2018-01-03 15:09 ` Iremonger, Bernard
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 34/39] examples/flow_filtering: " Shahaf Shuler
2017-12-26 13:57 ` Ori Kam
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 35/39] examples/packet_ordering: " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 36/39] examples/ptpclient: " Shahaf Shuler
2018-01-10 12:14 ` De Lara Guarch, Pablo
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 37/39] examples/rxtx_callbacks: " Shahaf Shuler
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 38/39] examples/server_node_efd: " Shahaf Shuler
2018-01-10 12:15 ` De Lara Guarch, Pablo
2017-12-26 9:23 ` [dpdk-dev] [PATCH v3 39/39] examples/skeleton: " Shahaf Shuler
2018-01-16 16:25 ` [dpdk-dev] [PATCH v3 00/39] convert examples " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=147e40cf-ff76-079b-a6f3-7a9567bd4a36@intel.com \
--to=radu.nicolau@intel.com \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).