From: Ami Sabo <amis@radware.com>
To: <yuanhan.liu@linux.intel.com>, <thomas.monjalon@6wind.com>
Cc: <dev@dpdk.org>, <stable@dpdk.org>, Ami Sabo <amis@radware.com>
Subject: [dpdk-stable] [PATCH v2 0/3] Fix virtio-user multi-process crash.
Date: Thu, 2 Mar 2017 09:51:21 +0200 [thread overview]
Message-ID: <1488441084-6039-1-git-send-email-amis@radware.com> (raw)
In-Reply-To: <1488102926-24158-2-git-send-email-amis@radware.com>
The patchset fixes secondary process crash issue when it tries
to access virtio-user pmd (e.g. via rte_eth_rx_burst).
The crash happens because the secondary process calls, at
virtio_user_pmd_probe() to virtio_user_eth_dev_alloc()->
rte_eth_dev_allocate() instead of eth_dev_attach_secondary(), as it's
done from rte_eth_dev_pci_probe. Therefore, the device is not properly
initialized + the device data maybe overridden by the secondary
process.
The patchset contains 3 patches:
1. Export rte_eth_dev_attach_secondary, so non-pci drivers will be
allowed to call it.
2. Fix the actual bug by calling the function during virtio_user probe.
3. Code style fixes following Yuanhan Lio's comments.
Ami Sabo (3):
lib/librte_ether: export secondary attach function
net/virtio-user: fix multi-process issue
lib/librte_ether: fix code style issues
drivers/net/virtio/virtio_user_ethdev.c | 26 ++++++++++++++++----------
lib/librte_ether/rte_ethdev.c | 6 +++---
lib/librte_ether/rte_ethdev.h | 13 +++++++++++++
lib/librte_ether/rte_ether_version.map | 7 +++++++
4 files changed, 39 insertions(+), 13 deletions(-)
--
v2:
* Fix code style issues following Yuanhan Liu's review.
--
2.7.4
next prev parent reply other threads:[~2017-03-02 7:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1487851096-32479-1-git-send-email-amis@radware.com>
2017-02-26 9:55 ` [dpdk-stable] [PATCH 0/2] " Ami Sabo
2017-02-26 9:55 ` [dpdk-stable] [PATCH 1/2] lib/librte_ether: export secondary attach function Ami Sabo
2017-02-28 6:37 ` Yuanhan Liu
2017-03-02 7:51 ` Ami Sabo [this message]
2017-03-02 7:51 ` [dpdk-stable] [PATCH v2 1/3] " Ami Sabo
2017-03-02 7:51 ` [dpdk-stable] [PATCH v2 2/3] net/virtio-user: fix multi-process issue Ami Sabo
2017-03-02 7:51 ` [dpdk-stable] [PATCH v2 3/3] lib/librte_ether: fix code style issues Ami Sabo
2017-03-02 8:12 ` Yuanhan Liu
2017-03-02 9:00 ` [dpdk-stable] [PATCH 0/2] Fix virtio-user multi-process crash Ami Sabo
2017-03-02 9:00 ` [dpdk-stable] [PATCH 1/2] lib/librte_ether: export secondary attach function Ami Sabo
2017-03-02 9:00 ` [dpdk-stable] [PATCH 2/2] net/virtio-user: fix multi-process issue Ami Sabo
2017-04-14 12:13 ` [dpdk-stable] [PATCH 0/2] Fix virtio-user multi-process crash Thomas Monjalon
2017-02-26 9:55 ` [dpdk-stable] [PATCH 2/2] net/virtio-user: fix multi-process issue Ami Sabo
2017-02-28 6:40 ` Yuanhan Liu
2017-02-28 7:50 ` Ami Sabo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488441084-6039-1-git-send-email-amis@radware.com \
--to=amis@radware.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=thomas.monjalon@6wind.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).