From: Wei Dai <wei.dai@intel.com>
To: dev@dpdk.org, thomas.monjalon@6wind.com, harish.patil@cavium.com,
rasesh.mody@cavium.com, stephen.hurd@broadcom.com,
ajit.khaparde@broadcom.com, wenzhuo.lu@intel.com,
helin.zhang@intel.com, konstantin.ananyev@intel.com,
jingjing.wu@intel.com, jing.d.chen@intel.com,
adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com,
bruce.richardson@intel.com, yuanhan.liu@linux.intel.com,
maxime.coquelin@redhat.com
Cc: Wei Dai <wei.dai@intel.com>
Subject: [dpdk-dev] [PATCH v3 0/3] MAC address fail to be added shouldn't be stored
Date: Wed, 12 Apr 2017 17:02:23 +0800 [thread overview]
Message-ID: <1491987746-10155-1-git-send-email-wei.dai@intel.com> (raw)
Current ethdev always stores MAC address even it fails to be added.
Other function may regard the failed MAC address valid and lead to
some errors. So There is a need to check if the addr is added
successfully or not and discard it if it fails.
In 3rd patch, add a command "add_more_mac_addr port_id base_mac_addr count"
to add more than one MAC address one time.
This command can simplify the test for the first patch.
Normally a MAC address may fails to be added only after many MAC
addresses have been added.
Without this command, a tester may only trigger failed MAC address
by running many times of testpmd command 'mac_addr add' .
---
Changes
v3:
1. Change return value for some specific NIC according to feedbacks
from the community;
2. Add ABI change in release note;
3. Add more detailed commit message.
v2:
fix warnings and erros from check-git-log.sh and checkpatch.pl
Wei Dai (3):
ethdev: fix adding invalid MAC addr
doc: change type of return value of adding MAC addr
app/testpmd: add a command to add many MAC addrs
app/test-pmd/cmdline.c | 55 ++++++++++++++++++++++++++++++++++
doc/guides/rel_notes/release_17_05.rst | 6 ++++
drivers/net/bnx2x/bnx2x_ethdev.c | 7 +++--
drivers/net/bnxt/bnxt_ethdev.c | 12 ++++----
drivers/net/e1000/base/e1000_api.c | 2 +-
drivers/net/e1000/em_ethdev.c | 6 ++--
drivers/net/e1000/igb_ethdev.c | 5 ++--
drivers/net/enic/enic.h | 2 +-
drivers/net/enic/enic_ethdev.c | 4 +--
drivers/net/enic/enic_main.c | 6 ++--
drivers/net/fm10k/fm10k_ethdev.c | 3 +-
drivers/net/i40e/i40e_ethdev.c | 11 +++----
drivers/net/i40e/i40e_ethdev_vf.c | 8 ++---
drivers/net/ixgbe/ixgbe_ethdev.c | 27 +++++++++++------
drivers/net/mlx4/mlx4.c | 14 +++++----
drivers/net/mlx5/mlx5.h | 4 +--
drivers/net/mlx5/mlx5_mac.c | 12 +++++---
drivers/net/qede/qede_ethdev.c | 6 ++--
drivers/net/ring/rte_eth_ring.c | 3 +-
drivers/net/virtio/virtio_ethdev.c | 13 ++++----
lib/librte_ether/rte_ethdev.c | 15 ++++++----
lib/librte_ether/rte_ethdev.h | 2 +-
22 files changed, 157 insertions(+), 66 deletions(-)
--
2.7.4
next reply other threads:[~2017-04-12 9:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 9:02 Wei Dai [this message]
2017-04-12 9:02 ` [dpdk-dev] [PATCH v3 1/3] ethdev: fix adding invalid MAC addr Wei Dai
2017-04-12 9:30 ` Nélio Laranjeiro
2017-04-12 9:02 ` [dpdk-dev] [PATCH v3 2/3] doc: change type of return value of adding " Wei Dai
2017-04-12 9:02 ` [dpdk-dev] [PATCH v3 3/3] app/testpmd: add a command to add many MAC addrs Wei Dai
2017-04-13 8:21 ` [dpdk-dev] [PATCH v4 0/3] MAC address fail to be added shouldn't be stored Wei Dai
2017-04-13 13:54 ` Ananyev, Konstantin
2017-04-13 8:21 ` [dpdk-dev] [PATCH v4 1/3] ethdev: fix adding invalid MAC addr Wei Dai
2017-04-13 8:44 ` Nélio Laranjeiro
2017-04-13 9:22 ` Dai, Wei
2017-04-20 5:31 ` Yuanhan Liu
2017-04-20 21:43 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2017-04-21 6:43 ` [dpdk-dev] " Lu, Wenzhuo
2017-04-29 6:09 ` Dai, Wei
2017-05-02 1:21 ` Lu, Wenzhuo
2017-05-02 1:51 ` Dai, Wei
2017-04-13 8:21 ` [dpdk-dev] [PATCH v4 2/3] doc: change type of return value of adding " Wei Dai
2017-04-14 16:03 ` Mcnamara, John
2017-04-13 8:21 ` [dpdk-dev] [PATCH v4 3/3] app/testpmd: add a command to add many MAC addrs Wei Dai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491987746-10155-1-git-send-email-wei.dai@intel.com \
--to=wei.dai@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=ajit.khaparde@broadcom.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=harish.patil@cavium.com \
--cc=helin.zhang@intel.com \
--cc=jing.d.chen@intel.com \
--cc=jingjing.wu@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=rasesh.mody@cavium.com \
--cc=stephen.hurd@broadcom.com \
--cc=thomas.monjalon@6wind.com \
--cc=wenzhuo.lu@intel.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).