From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: <ferruh.yigit@intel.com>
Cc: <dev@dpdk.org>
Subject: [dpdk-dev] [RFC PATCH 1/5] kni: change and configure mac address
Date: Wed, 3 May 2017 16:51:08 +0530 [thread overview]
Message-ID: <1493810472-668-1-git-send-email-hemant.agrawal@nxp.com> (raw)
This patch adds following:
1. option to configure the mac address during create
2. inform usespace, if mac address is being changed in linux
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
.../linuxapp/eal/include/exec-env/rte_kni_common.h | 3 +++
lib/librte_eal/linuxapp/kni/kni_misc.c | 6 +++++-
lib/librte_eal/linuxapp/kni/kni_net.c | 15 +++++++++++++--
lib/librte_kni/rte_kni.c | 12 ++++++++++++
lib/librte_kni/rte_kni.h | 8 ++++++++
5 files changed, 41 insertions(+), 3 deletions(-)
diff --git a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h b/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h
index 2ac879f..e9fdc73 100644
--- a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h
+++ b/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h
@@ -80,6 +80,7 @@ enum rte_kni_req_id {
RTE_KNI_REQ_UNKNOWN = 0,
RTE_KNI_REQ_CHANGE_MTU,
RTE_KNI_REQ_CFG_NETWORK_IF,
+ RTE_KNI_REQ_CHANGE_MAC_ADDR,
RTE_KNI_REQ_MAX,
};
@@ -92,6 +93,7 @@ struct rte_kni_request {
union {
uint32_t new_mtu; /**< New MTU */
uint8_t if_up; /**< 1: interface up, 0: interface down */
+ uint8_t mac_addr[6]; /**< MAC address for interface */
};
int32_t result; /**< Result for processing request */
} __attribute__((__packed__));
@@ -168,6 +170,7 @@ struct rte_kni_device_info {
/* mbuf size */
unsigned mbuf_size;
+ char macaddr[6]; /**< Mac Address */
};
#define KNI_DEVICE "kni"
diff --git a/lib/librte_eal/linuxapp/kni/kni_misc.c b/lib/librte_eal/linuxapp/kni/kni_misc.c
index 7590f1f..90879fa 100644
--- a/lib/librte_eal/linuxapp/kni/kni_misc.c
+++ b/lib/librte_eal/linuxapp/kni/kni_misc.c
@@ -458,12 +458,16 @@ struct kni_net {
if (kni->lad_dev)
ether_addr_copy(net_dev->dev_addr, kni->lad_dev->dev_addr);
- else
+ else {
/*
* Generate random mac address. eth_random_addr() is the newer
* version of generating mac address in linux kernel.
*/
random_ether_addr(net_dev->dev_addr);
+
+ /* todo - check if user supplied mac address is available*/
+ memcpy(net_dev->dev_addr, dev_info.macaddr, ETH_ALEN);
+ }
ret = register_netdev(net_dev);
if (ret) {
diff --git a/lib/librte_eal/linuxapp/kni/kni_net.c b/lib/librte_eal/linuxapp/kni/kni_net.c
index db9f489..866cbdd 100644
--- a/lib/librte_eal/linuxapp/kni/kni_net.c
+++ b/lib/librte_eal/linuxapp/kni/kni_net.c
@@ -668,12 +668,23 @@
static int
kni_net_set_mac(struct net_device *netdev, void *p)
{
+ int ret;
+ struct rte_kni_request req;
struct sockaddr *addr = p;
+ struct kni_dev *kni;
+
+ kni = netdev_priv(netdev);
+ memset(&req, 0, sizeof(req));
+ req.req_id = RTE_KNI_REQ_CHANGE_MAC_ADDR;
- if (!is_valid_ether_addr((unsigned char *)(addr->sa_data)))
+ if (!is_valid_ether_addr((unsigned char *)(addr->sa_data))) {
return -EADDRNOTAVAIL;
+ }
+ memcpy(req.mac_addr, addr->sa_data, netdev->addr_len);
memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len);
- return 0;
+ ret = kni_net_process_request(kni, &req);
+
+ return (ret == 0 ? req.result : ret);
}
#ifdef HAVE_CHANGE_CARRIER_CB
diff --git a/lib/librte_kni/rte_kni.c b/lib/librte_kni/rte_kni.c
index 52fcd4b..d5a717b 100644
--- a/lib/librte_kni/rte_kni.c
+++ b/lib/librte_kni/rte_kni.c
@@ -52,6 +52,10 @@
#define MAX_MBUF_BURST_NUM 32
+#ifndef ETH_ADDR_LEN
+#define ETH_ADDR_LEN 6
+#endif
+
/* Maximum number of ring entries */
#define KNI_FIFO_COUNT_MAX 1024
#define KNI_FIFO_SIZE (KNI_FIFO_COUNT_MAX * sizeof(void *) + \
@@ -368,6 +372,8 @@ struct rte_kni *
dev_info.group_id = conf->group_id;
dev_info.mbuf_size = conf->mbuf_size;
+ memcpy(dev_info.macaddr, conf->macaddr, ETH_ADDR_LEN);
+
snprintf(ctx->name, RTE_KNI_NAMESIZE, "%s", intf_name);
snprintf(dev_info.name, RTE_KNI_NAMESIZE, "%s", intf_name);
@@ -541,6 +547,11 @@ struct rte_kni *
req->result = kni->ops.config_network_if(\
kni->ops.port_id, req->if_up);
break;
+ case RTE_KNI_REQ_CHANGE_MAC_ADDR: /* Change MAC Address */
+ if (kni->ops.config_mac_address)
+ req->result = kni->ops.config_mac_address(kni->ops.port_id,
+ req->mac_addr);
+ break;
default:
RTE_LOG(ERR, KNI, "Unknown request id %u\n", req->req_id);
req->result = -EINVAL;
@@ -735,6 +746,7 @@ struct rte_kni *
kni->ops.change_mtu = NULL;
kni->ops.config_network_if = NULL;
+ kni->ops.config_mac_address = NULL;
return 0;
}
void
diff --git a/lib/librte_kni/rte_kni.h b/lib/librte_kni/rte_kni.h
index 37deb47..5d2a233 100644
--- a/lib/librte_kni/rte_kni.h
+++ b/lib/librte_kni/rte_kni.h
@@ -59,6 +59,10 @@
struct rte_kni;
struct rte_mbuf;
+#ifndef ETH_ADDR_LEN
+#define ETH_ADDR_LEN 6
+#endif
+
/**
* Structure which has the function pointers for KNI interface.
*/
@@ -70,6 +74,9 @@ struct rte_kni_ops {
/* Pointer to function of configuring network interface */
int (*config_network_if)(uint8_t port_id, uint8_t if_up);
+
+ /* Pointer to function of configuring mac address */
+ int (*config_mac_address)(uint8_t port_id, uint8_t mac_addr[6]);
};
/**
@@ -87,6 +94,7 @@ struct rte_kni_conf {
unsigned mbuf_size; /* mbuf size */
struct rte_pci_addr addr;
struct rte_pci_id id;
+ char macaddr[ETH_ADDR_LEN]; /* MAC address assigned to KNI */
__extension__
uint8_t force_bind : 1; /* Flag to bind kernel thread */
--
1.9.1
next reply other threads:[~2017-05-03 11:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-03 11:21 Hemant Agrawal [this message]
2017-05-03 11:21 ` [dpdk-dev] [RFC PATCH 2/5] kni: add support for promisc mode set Hemant Agrawal
2017-05-03 11:21 ` [dpdk-dev] [RFC PATCH 3/5] kni: init and change request for mtu Hemant Agrawal
2017-05-03 11:21 ` [dpdk-dev] [RFC PATCH 4/5] kni: add support to get gso_size info Hemant Agrawal
2017-05-03 13:57 ` Alejandro Lucero
2017-05-05 11:43 ` Ferruh Yigit
2017-05-03 11:21 ` [dpdk-dev] [RFC PATCH 5/5] kni: support multiple userspace process working with kni module Hemant Agrawal
2017-05-05 13:08 ` Ferruh Yigit
2017-05-08 9:50 ` Hemant Agrawal
2017-05-05 11:28 ` [dpdk-dev] [RFC PATCH 1/5] kni: change and configure mac address Ferruh Yigit
2017-05-08 9:59 ` Hemant Agrawal
2017-11-28 22:31 ` Ferruh Yigit
2017-11-30 6:44 ` Hemant Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493810472-668-1-git-send-email-hemant.agrawal@nxp.com \
--to=hemant.agrawal@nxp.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).