From: Luca Boccassi <bluca@debian.org>
To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] checkpatch: re-enable warnings about split long strings
Date: Mon, 02 Oct 2017 11:01:17 +0100 [thread overview]
Message-ID: <1506938477.7585.1.camel@debian.org> (raw)
In-Reply-To: <20170929153749.9806-1-stephen@networkplumber.org>
On Fri, 2017-09-29 at 08:37 -0700, Stephen Hemminger wrote:
> The Linux kernel style policy about strings is that strings should
> be always put on one line. This makes sense since a typical use
> case is for a user to type the error message into a search engine
> or grep, and it won't be found if split across lines.
> This patch just re-enables that check.
>
> Yes, lots of DPDK code now splits strings, that doesn't
> make it right.
>
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
> ---
> devtools/checkpatches.sh | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
> index a56c41a301c0..3e6081dd673e 100755
> --- a/devtools/checkpatches.sh
> +++ b/devtools/checkpatches.sh
> @@ -44,7 +44,6 @@ options="$options --show-types"
> options="$options --ignore=LINUX_VERSION_CODE,FILE_PATH_CHANGES,\
> VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\
> PREFER_KERNEL_TYPES,BIT_MACRO,CONST_STRUCT,\
> -SPLIT_STRING,LONG_LINE_STRING,\
> LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\
> NEW_TYPEDEFS,COMPARISON_TO_NULL"
>
Acked-by: Luca Boccassi <bluca@debian.org>
+1 - being able to reliably Google/grep across such a large code base
is extremely useful
--
Kind regards,
Luca Boccassi
next prev parent reply other threads:[~2017-10-02 10:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-29 15:37 Stephen Hemminger
2017-10-02 10:01 ` Luca Boccassi [this message]
2017-10-02 11:53 ` Adrien Mazarguil
2017-10-02 13:46 ` Bruce Richardson
2017-10-02 16:21 ` Adrien Mazarguil
2017-10-03 10:38 ` Bruce Richardson
2017-10-03 10:56 ` Adrien Mazarguil
2019-03-28 19:02 ` Ferruh Yigit
2019-03-28 19:02 ` Ferruh Yigit
2019-03-28 19:03 ` Ferruh Yigit
2019-03-28 19:03 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506938477.7585.1.camel@debian.org \
--to=bluca@debian.org \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).